All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: mxc: all three imx51 TOs use TO1 version of sdma script
Date: Mon, 13 Jun 2011 15:37:24 +0800	[thread overview]
Message-ID: <1307950645-26529-6-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1307950645-26529-1-git-send-email-shawn.guo@linaro.org>

Though there are three TOs of imx51 soc, the sdma script never
changes since TO1, which means all three TOs of imx51 uses TO1
version of sdma script.

The current code passes TO number to imx-sdma driver to load
different firmware for different TO.  That means we have to prepare
3 identical firmwares, sdma-imx25-to1.bin sdma-imx25-to2.bin and
sdma-imx25-to3.bin, to have the kernel capable of running on all
three TOs.  This just makes no sense.

The patch removes the TO number passing and get the default TO1
version of sdma firmware work for all TOs.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 arch/arm/plat-mxc/devices/platform-imx-dma.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-mxc/devices/platform-imx-dma.c b/arch/arm/plat-mxc/devices/platform-imx-dma.c
index c64f015..2091540 100644
--- a/arch/arm/plat-mxc/devices/platform-imx-dma.c
+++ b/arch/arm/plat-mxc/devices/platform-imx-dma.c
@@ -196,8 +196,6 @@ static int __init imxXX_add_imx_dma(void)
 
 #if defined(CONFIG_SOC_IMX51)
 	if (cpu_is_mx51()) {
-		int to_version = mx51_revision() >> 4;
-		imx51_imx_sdma_data.pdata.to_version = to_version;
 		imx51_imx_sdma_data.pdata.script_addrs = &addr_imx51;
 		ret = imx_add_imx_sdma(&imx51_imx_sdma_data);
 	} else
-- 
1.7.4.1

  parent reply	other threads:[~2011-06-13  7:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13  7:37 [PATCH 0/6] Some fixes and cleanup on imx-dma device registration Shawn Guo
2011-06-13  7:37 ` [PATCH 1/6] ARM: mxc: imx-sdma device gets 16K iosize than 4K Shawn Guo
2011-06-13  7:37 ` [PATCH 2/6] ARM: mxc: sdma on imx25 is a V2 block Shawn Guo
2011-06-13  7:37 ` [PATCH 3/6] ARM: mxc: change imx-dma default to_version to 1 Shawn Guo
2011-06-13  7:37 ` [PATCH 4/6] ARM: mxc: imx-dma on imx25 has no other TO version but TO1 Shawn Guo
2011-06-13  7:37 ` Shawn Guo [this message]
2011-06-13 12:36   ` [PATCH 5/6] ARM: mxc: all three imx51 TOs use TO1 version of sdma script Fabio Estevam
2011-06-13 13:05     ` Shawn Guo
2011-06-14  6:20   ` [PATCH v2 " Shawn Guo
2011-06-14 20:38     ` Sascha Hauer
2011-06-15  4:29       ` Shawn Guo
2011-06-16  7:30         ` Sascha Hauer
2011-06-16 11:51           ` Shawn Guo
2011-06-17  1:59             ` Fabio Estevam
2011-06-17  2:27               ` Shawn Guo
2011-06-20  7:20                 ` Sascha Hauer
2011-06-13  7:37 ` [PATCH 6/6] ARM: mxc: clean up imx-dma device registration Shawn Guo
2011-06-20 14:50   ` Shawn Guo
2011-06-21 14:41     ` Shawn Guo
2011-06-21 15:13       ` Wolfram Sang
2011-06-22  2:43         ` Shawn Guo
2011-06-22  6:33           ` Wolfram Sang
2011-06-21 22:57     ` Sascha Hauer
2011-06-22  2:53       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307950645-26529-6-git-send-email-shawn.guo@linaro.org \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.