All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "THOMSON, Adam (Adam)" <adam.thomson@alcatel-lucent.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: RE: [PATCH upstream] nand: nand_base: Always initialise oob_poi before writing OOB data
Date: Wed, 22 Jun 2011 13:57:04 +0300	[thread overview]
Message-ID: <1308740228.18119.70.camel@sauron> (raw)
In-Reply-To: <E14CAA9D00C5044EACE0C59FC2A1C7F5059AB4DD8D@FRMRSSXCHMBSC1.dc-m.alcatel-lucent.com>

On Wed, 2011-06-22 at 12:41 +0200, THOMSON, Adam (Adam) wrote:
> Artem Wrote:
> 
> >
> > Added the -stable CC here and pushed to l2-mtd-2.6.git with
> > some modifications.
> >
> 
> This is probably my fault, but the mail previous to this had the
> version which contained the stable line.

I did not figure out why you sent 2 separate patches. Usually it is one
patch which goes upstream, then GregKH and others pick it up and back
ports to various stable trees. If they have issues, they may come and
ask for help. So there should be 1 patch.

>  That patch version (v3)did
> not remove the final memset from nand_do_write_oob, as you requested.

Did I request so? I thought I just expressed a thought that the memset
is redundant and should be killed, and I thought you'd take a deeper
look and decide whether it is safe to do or not.

> Named both patches the same as they were pretty much indentical,
> except for the memset. Didn't know the convention for patch naming
> where one was going to stable, and the other to the latest so
> marked the latest as upstream to differentiate.

So do we need that memset or not? :-)

-- 
Best Regards,
Artem Bityutskiy

  reply	other threads:[~2011-06-22 10:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 14:52 [PATCH upstream] nand: nand_base: Always initialise oob_poi before writing OOB data THOMSON, Adam (Adam)
2011-06-22  5:55 ` Artem Bityutskiy
2011-06-22 10:41   ` THOMSON, Adam (Adam)
2011-06-22 10:57     ` Artem Bityutskiy [this message]
2011-06-22 11:08       ` THOMSON, Adam (Adam)
2011-06-22 15:40         ` THOMSON, Adam (Adam)
2011-06-23  8:22           ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308740228.18119.70.camel@sauron \
    --to=dedekind1@gmail.com \
    --cc=adam.thomson@alcatel-lucent.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.