From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC606C83000 for ; Tue, 28 Apr 2020 20:55:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C67620B80 for ; Tue, 28 Apr 2020 20:55:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="EbpVeAgF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C67620B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTXFX-00043v-BG; Tue, 28 Apr 2020 20:54:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTXFW-00043q-E9 for xen-devel@lists.xenproject.org; Tue, 28 Apr 2020 20:54:38 +0000 X-Inumbo-ID: 782ed33c-8992-11ea-98c8-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 782ed33c-8992-11ea-98c8-12813bfff9fa; Tue, 28 Apr 2020 20:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1588107276; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=vtgMfbKlG7tTO0fahEHKsiKahuUO8TfrKT+QDlOVgps=; b=EbpVeAgFuWIbio9deIK+mLbAXWV7TTPMGYcYzu9TiEU0JPRRTY+hb3Pu HKmElkzcGsi2YrKxLRwhJrNLP+D5Me1PYjEMEY/aVcM90Uw6gmErXeDTX 2G0vg6plGspaj3chSGSp3I4Pdjwis7p1Fxm+lGjyEqJWRR59xrv5z374n g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: jSqHBU5uG/lWXYn6GIU52x7haex7qbb861udEKyjJOJNlOkil53pFu3+Hx9r+bpZfz0LBUNkbm pZznoZrIJRAY+hS3F8nl63l6w2vh3kbG3t3LtbC29YTZF4LaJ21HvTnKSuEnUOQRI2/BHeJzAm 9Cb2jlJe0f1OjRtdJh99WdbK9fO2gxT8BNaLgCq0pAcE7GRju8kGdRi9RxQJqoQfteUZAz6A8x OEC6dMPNoIJKwBHSzrGVdUCqZGLQ6ZAZXPefuMgKW5fGE2cKoZLoyOrJGe3JqeacKCpjdoRerd Tx4= X-SBRS: 2.7 X-MesageID: 16713410 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,328,1583211600"; d="scan'208";a="16713410" Subject: Re: [PATCH] tools/xenstore: don't store domU's mfn of ring page in xensotred To: Juergen Gross , References: <20200428155144.8253-1-jgross@suse.com> From: Andrew Cooper Message-ID: <130909f7-e9e2-93b4-5b54-aa55178d1bd3@citrix.com> Date: Tue, 28 Apr 2020 21:54:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200428155144.8253-1-jgross@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 28/04/2020 16:51, Juergen Gross wrote: > The XS_INTRODUCE command has two parameters: the mfn (or better: gfn) > of the domain's xenstore ring page and the event channel of the > domain for communicating with Xenstore. > > The gfn is not really needed. It is stored in the per-domain struct > in xenstored and in case of another XS_INTRODUCE for the domain it > is tested to match the original value. If it doesn't match the > command is aborted via EINVAL. > > Today there shouldn't be multiple XS_INTRODUCE requests for the same > domain issued, so the mfn/gfn can just be ignored and multiple > XS_INTRODUCE commands can be rejected without testing the mfn/gfn. > > Signed-off-by: Juergen Gross In hindsight, this is cleanup following c/s 38eeb3864d "tools/xenstored: Drop mapping of the ring via foreign map". Acked-by: Andrew Cooper