From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] eglibc-locale: fix localedef packaging
Date: Thu, 30 Jun 2011 12:17:22 +0100 [thread overview]
Message-ID: <1309432642.2551.131.camel@phil-desktop> (raw)
In-Reply-To: <1309355375.20015.383.camel@rex>
On Wed, 2011-06-29 at 14:49 +0100, Richard Purdie wrote:
> On Wed, 2011-06-29 at 14:36 +0100, Phil Blundell wrote:
> > On Tue, 2011-06-28 at 22:32 +0200, Koen Kooi wrote:
> > > From http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/testlab/commit/?h=yocto&id=0d0e14cda2ddd881d09798b0e6edd8086aa9b6d9
> > >
> > > +libc6 -> libc6_dev;
> > >
> > > So libc6 now depends on libc6-dev :(
> >
> > I guess it would be straightforward to patch insane.bbclass to detect
> > that particular failure (which does indeed seem to happen to libc
> > distressingly often). It already diagnoses the case where a package
> > erroneously depends on a -dbg package, and I can't think of any reason
> > why the same logic couldn't be applied to -dev.
>
> I'd love to see a patch for this! :)
Your wish, naturally, is my command. I've built micro-base-image with
this and verified that I didn't get any false positives; I also checked
(via some manual fiddling) that it did indeed detect the case that we
want it to.
I guess it might be a good idea for someone to test it with a slightly
larger dataset before actually checking it in, just in case.
p.
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 35809b9..f7e5524 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -103,6 +103,7 @@ def package_qa_get_machine_dict():
# 8 - .la contains reference to the workdir
# 9 - LDFLAGS ignored
# 10 - Build paths in binaries
+# 11 - package depends on devel package
def package_qa_clean_path(path,d):
""" Remove the common prefix from the path. In this case it is the TMPDIR"""
@@ -134,6 +135,7 @@ def package_qa_write_error(error_class, name, path, d):
".la contains reference to the workdir",
"LDFLAGS ignored",
"package contains reference to tmpdir paths",
+ "package depends on devel package",
]
log_path = os.path.join( bb.data.getVar('T', d, True), "log.qa_package" )
@@ -493,12 +495,14 @@ def package_qa_check_rdepends(pkg, pkgdest, d):
# Now check the RDEPENDS
rdepends = bb.utils.explode_deps(bb.data.getVar('RDEPENDS', localdata, True) or "")
-
# Now do the sanity check!!!
for rdepend in rdepends:
if "-dbg" in rdepend:
error_msg = "%s rdepends on %s" % (pkgname,rdepend)
sane = package_qa_handle_error(2, error_msg, pkgname, rdepend, d)
+ if (not "-dev" in pkg and not "-staticdev" in pkg) and rdepend.endswith("-dev"):
+ error_msg = "%s rdepends on %s" % (pkgname, rdepend)
+ sane = package_qa_handle_error(11, error_msg, pkgname, rdepend, d)
return sane
next prev parent reply other threads:[~2011-06-30 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 15:30 [PATCH] eglibc-locale: fix localedef packaging Koen Kooi
2011-06-28 16:11 ` Richard Purdie
2011-06-28 20:32 ` Koen Kooi
2011-06-29 13:36 ` Phil Blundell
2011-06-29 13:49 ` Richard Purdie
2011-06-30 11:17 ` Phil Blundell [this message]
2011-06-30 11:24 ` Koen Kooi
2011-06-30 13:04 ` Phil Blundell
2011-06-30 13:40 ` Koen Kooi
2011-06-30 14:54 ` Richard Purdie
2011-06-30 14:54 ` Richard Purdie
2011-06-30 15:53 ` Saul Wold
2011-07-05 13:05 ` Richard Purdie
2011-06-29 22:31 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309432642.2551.131.camel@phil-desktop \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.