All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Leblond <eric@regit.org>
Cc: Patrick McHardy <kaber@trash.net>,
	sclark46@earthlink.net, Kuzin Andrey <kuzinandrey@yandex.ru>,
	Anders Nilsson Plymoth <lanilsson@gmail.com>,
	netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: netfilter queue throughput slowdown
Date: Thu, 30 Jun 2011 19:45:19 +0200	[thread overview]
Message-ID: <1309455919.2515.3.camel@edumazet-laptop> (raw)
In-Reply-To: <1309453730.5846.31.camel@tiger.regit.org>

Le jeudi 30 juin 2011 à 19:07 +0200, Eric Leblond a écrit :

> As the verdict failure is bound to occur in a high load time,
> retransmission of the verdict (which is necessary) will not help the
> system to recover. Userspace has to deal with it but it has another
> consequences which is that userspace software may suffer of case where
> successive failures occurs.
> 
> In this scope, Florian's patch "netfilter: nfqueue: batch verdict
> support" could be really useful. It could be used by userspace to
> trigger an decide on all stucked packets. Issuing a massive ACCEPT could
> lead to dynosaurus packet coming from ancient time but it could be ok if
> batch occurs enough often.
> 
> Is there a plan to accept it in mainstream ?

Given that apparently some apps are not aware some of their verdicts are
lost, I consider the BATCH idea would be a bad idea, unless DROP is
used.

If you have any doubt, only sane thing is to drop packets, not accept
them.

Maybe a single queue flag is needed : DROP_OLD_PACKETS, if user
application is handling packets in order.

Every time a verdict is given by application, automatically DROP all
previous un-verdicted packets.



--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-06-30 17:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  9:17 netfilter queue throughput slowdown Anders Nilsson Plymoth
2011-06-29  9:47 ` Eric Dumazet
2011-06-29  9:55   ` Anders Nilsson Plymoth
2011-06-29 10:08     ` Eric Dumazet
2011-06-30  6:20       ` Kuzin Andrey
2011-06-30  6:47         ` Eric Dumazet
2011-06-30  7:36           ` Kuzin Andrey
2011-06-30 11:34             ` Eric Dumazet
2011-06-30 11:59               ` Patrick McHardy
2011-06-30 15:15                 ` Eric Dumazet
2011-06-30 14:32                   ` Stephen Clark
2011-06-30 14:51                     ` Patrick McHardy
2011-06-30 17:07                       ` Eric Leblond
2011-06-30 17:45                         ` Eric Dumazet [this message]
2011-06-30 18:08                           ` Eric Leblond
2011-07-01  6:39                           ` Amos Jeffries
2011-07-01  7:00                           ` [RFC] nfnetlink_queue not scalable Eric Dumazet
2011-07-01  7:49                             ` Florian Westphal
2011-07-01 15:27                               ` [PATCH 1/2] nfnetlink: add RCU in nfnetlink_rcv_msg() Eric Dumazet
2011-07-01 14:11                                 ` Florian Westphal
2011-07-05 13:22                                 ` Patrick McHardy
2011-07-18 14:06                                 ` Patrick McHardy
2011-07-01 15:08                           ` netfilter queue throughput slowdown Anders Nilsson Plymoth
2011-06-30 22:24                   ` Sam Roberts
2011-07-01  4:53                     ` Eric Dumazet
2011-06-30 22:26         ` Sam Roberts
2011-07-01  4:52           ` Eric Dumazet
2011-07-02 12:25 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309455919.2515.3.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=eric@regit.org \
    --cc=kaber@trash.net \
    --cc=kuzinandrey@yandex.ru \
    --cc=lanilsson@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sclark46@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.