All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: mxs/tx28: according to the TX28's datasheet D4-D7 are not used for MMC0
@ 2011-07-05 10:06 Uwe Kleine-König
  2011-07-05 16:59 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2011-07-05 10:06 UTC (permalink / raw)
  To: linux-arm-kernel

The pins are actually used (not in mainline yet):

	D4 -> SSP2_D0
	D5 -> GPIO
	D6 -> GPIO
	D7 -> GPIO for owire

so their pinmapping for SSP0 is wrong.

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-mxs/mach-tx28.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-mxs/mach-tx28.c b/arch/arm/mach-mxs/mach-tx28.c
index b65e371..068e540 100644
--- a/arch/arm/mach-mxs/mach-tx28.c
+++ b/arch/arm/mach-mxs/mach-tx28.c
@@ -101,14 +101,6 @@ static const iomux_cfg_t tx28_stk5v3_pads[] __initconst = {
 		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
 	MX28_PAD_SSP0_DATA3__SSP0_D3 |
 		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
-	MX28_PAD_SSP0_DATA4__SSP0_D4 |
-		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
-	MX28_PAD_SSP0_DATA5__SSP0_D5 |
-		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
-	MX28_PAD_SSP0_DATA6__SSP0_D6 |
-		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
-	MX28_PAD_SSP0_DATA7__SSP0_D7 |
-		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
 	MX28_PAD_SSP0_CMD__SSP0_CMD |
 		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
 	MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT |
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: mxs/tx28: according to the TX28's datasheet D4-D7 are not used for MMC0
  2011-07-05 10:06 [PATCH] ARM: mxs/tx28: according to the TX28's datasheet D4-D7 are not used for MMC0 Uwe Kleine-König
@ 2011-07-05 16:59 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2011-07-05 16:59 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jul 05, 2011 at 12:06:36PM +0200, Uwe Kleine-K?nig wrote:
> The pins are actually used (not in mainline yet):
> 
> 	D4 -> SSP2_D0
> 	D5 -> GPIO
> 	D6 -> GPIO
> 	D7 -> GPIO for owire
> 
> so their pinmapping for SSP0 is wrong.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Applied for next.

Sascha

> ---
>  arch/arm/mach-mxs/mach-tx28.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/mach-mxs/mach-tx28.c b/arch/arm/mach-mxs/mach-tx28.c
> index b65e371..068e540 100644
> --- a/arch/arm/mach-mxs/mach-tx28.c
> +++ b/arch/arm/mach-mxs/mach-tx28.c
> @@ -101,14 +101,6 @@ static const iomux_cfg_t tx28_stk5v3_pads[] __initconst = {
>  		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
>  	MX28_PAD_SSP0_DATA3__SSP0_D3 |
>  		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
> -	MX28_PAD_SSP0_DATA4__SSP0_D4 |
> -		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
> -	MX28_PAD_SSP0_DATA5__SSP0_D5 |
> -		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
> -	MX28_PAD_SSP0_DATA6__SSP0_D6 |
> -		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
> -	MX28_PAD_SSP0_DATA7__SSP0_D7 |
> -		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
>  	MX28_PAD_SSP0_CMD__SSP0_CMD |
>  		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
>  	MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT |
> -- 
> 1.7.5.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-07-05 16:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-05 10:06 [PATCH] ARM: mxs/tx28: according to the TX28's datasheet D4-D7 are not used for MMC0 Uwe Kleine-König
2011-07-05 16:59 ` Sascha Hauer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.