All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
@ 2011-07-05 12:19 ` Jan Weitzel
  0 siblings, 0 replies; 8+ messages in thread
From: Jan Weitzel @ 2011-07-05 12:19 UTC (permalink / raw)
  To: linux-omap, linux-arm-kernel; +Cc: khilman, tony, Jan Weitzel

The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
clock44xx_data.c

Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
---
 arch/arm/mach-omap2/gpmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 130034b..34bcd17 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -708,7 +708,7 @@ static int __init gpmc_init(void)
 		l = OMAP34XX_GPMC_BASE;
 		gpmc_irq = INT_34XX_GPMC_IRQ;
 	} else if (cpu_is_omap44xx()) {
-		ck = "gpmc_ck";
+		ck = "gpmc_ick";
 		l = OMAP44XX_GPMC_BASE;
 		gpmc_irq = OMAP44XX_IRQ_GPMC;
 	}
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
@ 2011-07-05 12:19 ` Jan Weitzel
  0 siblings, 0 replies; 8+ messages in thread
From: Jan Weitzel @ 2011-07-05 12:19 UTC (permalink / raw)
  To: linux-arm-kernel

The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
clock44xx_data.c

Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
---
 arch/arm/mach-omap2/gpmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 130034b..34bcd17 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -708,7 +708,7 @@ static int __init gpmc_init(void)
 		l = OMAP34XX_GPMC_BASE;
 		gpmc_irq = INT_34XX_GPMC_IRQ;
 	} else if (cpu_is_omap44xx()) {
-		ck = "gpmc_ck";
+		ck = "gpmc_ick";
 		l = OMAP44XX_GPMC_BASE;
 		gpmc_irq = OMAP44XX_IRQ_GPMC;
 	}
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
  2011-07-05 12:19 ` Jan Weitzel
@ 2011-07-05 16:49   ` Santosh Shilimkar
  -1 siblings, 0 replies; 8+ messages in thread
From: Santosh Shilimkar @ 2011-07-05 16:49 UTC (permalink / raw)
  To: Jan Weitzel
  Cc: linux-omap, linux-arm-kernel, Kevin Hilman, tony, Benoit Cousson

+ Benoit

On 7/5/2011 5:19 AM, Jan Weitzel wrote:
> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
> clock44xx_data.c
>
> Signed-off-by: Jan Weitzel<j.weitzel@phytec.de>
This happened after renaming the clock-nodes some time back.
Looks good to me as a fix though in long run GPMC should be
moved to hwmod to avoid such naming issues

> ---
>   arch/arm/mach-omap2/gpmc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 130034b..34bcd17 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -708,7 +708,7 @@ static int __init gpmc_init(void)
>   		l = OMAP34XX_GPMC_BASE;
>   		gpmc_irq = INT_34XX_GPMC_IRQ;
>   	} else if (cpu_is_omap44xx()) {
> -		ck = "gpmc_ck";
> +		ck = "gpmc_ick";
>   		l = OMAP44XX_GPMC_BASE;
>   		gpmc_irq = OMAP44XX_IRQ_GPMC;
>   	}


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
@ 2011-07-05 16:49   ` Santosh Shilimkar
  0 siblings, 0 replies; 8+ messages in thread
From: Santosh Shilimkar @ 2011-07-05 16:49 UTC (permalink / raw)
  To: linux-arm-kernel

+ Benoit

On 7/5/2011 5:19 AM, Jan Weitzel wrote:
> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
> clock44xx_data.c
>
> Signed-off-by: Jan Weitzel<j.weitzel@phytec.de>
This happened after renaming the clock-nodes some time back.
Looks good to me as a fix though in long run GPMC should be
moved to hwmod to avoid such naming issues

> ---
>   arch/arm/mach-omap2/gpmc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 130034b..34bcd17 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -708,7 +708,7 @@ static int __init gpmc_init(void)
>   		l = OMAP34XX_GPMC_BASE;
>   		gpmc_irq = INT_34XX_GPMC_IRQ;
>   	} else if (cpu_is_omap44xx()) {
> -		ck = "gpmc_ck";
> +		ck = "gpmc_ick";
>   		l = OMAP44XX_GPMC_BASE;
>   		gpmc_irq = OMAP44XX_IRQ_GPMC;
>   	}

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
  2011-07-05 16:49   ` Santosh Shilimkar
@ 2011-07-05 18:35     ` Kevin Hilman
  -1 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2011-07-05 18:35 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: Jan Weitzel, linux-omap, linux-arm-kernel, tony, Benoit Cousson

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> + Benoit
>
> On 7/5/2011 5:19 AM, Jan Weitzel wrote:
>> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
>> clock44xx_data.c
>>
>> Signed-off-by: Jan Weitzel<j.weitzel@phytec.de>
> This happened after renaming the clock-nodes some time back.
> Looks good to me as a fix though in long run GPMC should be
> moved to hwmod to avoid such naming issues

In fact, Benoit has already done it[1] as part of his last series:
[PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2)

Kevin

[1] http://marc.info/?l=linux-omap&m=130955728217211&w=2

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
@ 2011-07-05 18:35     ` Kevin Hilman
  0 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2011-07-05 18:35 UTC (permalink / raw)
  To: linux-arm-kernel

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> + Benoit
>
> On 7/5/2011 5:19 AM, Jan Weitzel wrote:
>> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
>> clock44xx_data.c
>>
>> Signed-off-by: Jan Weitzel<j.weitzel@phytec.de>
> This happened after renaming the clock-nodes some time back.
> Looks good to me as a fix though in long run GPMC should be
> moved to hwmod to avoid such naming issues

In fact, Benoit has already done it[1] as part of his last series:
[PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2)

Kevin

[1] http://marc.info/?l=linux-omap&m=130955728217211&w=2

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
  2011-07-05 18:35     ` Kevin Hilman
@ 2011-07-05 18:42       ` Santosh Shilimkar
  -1 siblings, 0 replies; 8+ messages in thread
From: Santosh Shilimkar @ 2011-07-05 18:42 UTC (permalink / raw)
  To: Kevin Hilman
  Cc: Jan Weitzel, linux-omap, linux-arm-kernel, tony, Benoit Cousson

On 7/5/2011 11:35 AM, Kevin Hilman wrote:
> Santosh Shilimkar<santosh.shilimkar@ti.com>  writes:
>
>> + Benoit
>>
>> On 7/5/2011 5:19 AM, Jan Weitzel wrote:
>>> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
>>> clock44xx_data.c
>>>
>>> Signed-off-by: Jan Weitzel<j.weitzel@phytec.de>
>> This happened after renaming the clock-nodes some time back.
>> Looks good to me as a fix though in long run GPMC should be
>> moved to hwmod to avoid such naming issues
>
> In fact, Benoit has already done it[1] as part of his last series:
> [PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2)
>
Ohh yes. I remember now about the discussion with him on the GPMC patch
which he did as a followup patch to mine similar clock framework
patch [1]

Thanks for the link.

Regards
Santosh
[1] https://patchwork.kernel.org/patch/937422/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
@ 2011-07-05 18:42       ` Santosh Shilimkar
  0 siblings, 0 replies; 8+ messages in thread
From: Santosh Shilimkar @ 2011-07-05 18:42 UTC (permalink / raw)
  To: linux-arm-kernel

On 7/5/2011 11:35 AM, Kevin Hilman wrote:
> Santosh Shilimkar<santosh.shilimkar@ti.com>  writes:
>
>> + Benoit
>>
>> On 7/5/2011 5:19 AM, Jan Weitzel wrote:
>>> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
>>> clock44xx_data.c
>>>
>>> Signed-off-by: Jan Weitzel<j.weitzel@phytec.de>
>> This happened after renaming the clock-nodes some time back.
>> Looks good to me as a fix though in long run GPMC should be
>> moved to hwmod to avoid such naming issues
>
> In fact, Benoit has already done it[1] as part of his last series:
> [PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2)
>
Ohh yes. I remember now about the discussion with him on the GPMC patch
which he did as a followup patch to mine similar clock framework
patch [1]

Thanks for the link.

Regards
Santosh
[1] https://patchwork.kernel.org/patch/937422/

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-07-05 18:42 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-05 12:19 [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick Jan Weitzel
2011-07-05 12:19 ` Jan Weitzel
2011-07-05 16:49 ` Santosh Shilimkar
2011-07-05 16:49   ` Santosh Shilimkar
2011-07-05 18:35   ` Kevin Hilman
2011-07-05 18:35     ` Kevin Hilman
2011-07-05 18:42     ` Santosh Shilimkar
2011-07-05 18:42       ` Santosh Shilimkar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.