From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgdRm-0004vp-HP for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:56:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgdRj-0008NT-Es for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:56:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgdRi-0008N9-Mx for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:56:19 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6CDuHGT028521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 12 Jul 2011 09:56:17 -0400 From: Alon Levy Date: Tue, 12 Jul 2011 16:55:30 +0300 Message-Id: <1310478932-25370-18-git-send-email-alevy@redhat.com> In-Reply-To: <1310478932-25370-1-git-send-email-alevy@redhat.com> References: <1310478932-25370-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com This can happen if there is an interface_get_command issued when the server has been stopped. easy to trigger - do stop/cont a few times (three seem to be enough). The "solution" of ignoring the request is bad, but better then aborting and a real solution would probably be in spice to not call get_command in the first place. --- hw/qxl.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 8a9463e..0585f02 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1406,7 +1406,10 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t events) uint32_t old_pending; uint32_t le_events = cpu_to_le32(events); - assert(d->ssd.running); + if (!d->ssd.running) { + fprintf(stderr, "qxl: not sending interrupt %d while stopped\n", events); + return; + } old_pending = __sync_fetch_and_or(&d->ram->int_pending, le_events); if ((old_pending & le_events) == le_events) { return; -- 1.7.6