From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgdRn-0004wK-LW for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:56:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgdRk-0008Nl-Ui for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:56:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgdRk-0008NP-0Y for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:56:20 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6CDuIt7009194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 12 Jul 2011 09:56:18 -0400 From: Alon Levy Date: Tue, 12 Jul 2011 16:55:31 +0300 Message-Id: <1310478932-25370-19-git-send-email-alevy@redhat.com> In-Reply-To: <1310478932-25370-1-git-send-email-alevy@redhat.com> References: <1310478932-25370-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. --- hw/qxl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 0585f02..1d6acce 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1175,8 +1175,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) case QXL_IO_LOG: break; default: - if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) + if (d->mode != QXL_MODE_VGA) { break; + } dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n", __FUNCTION__, io_port, io_port_to_string(io_port)); /* be nice to buggy guest drivers */ -- 1.7.6