All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alon Levy <alevy@redhat.com>
To: qemu-devel@nongnu.org
Cc: yhalperi@redhat.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCHv4 10/11] qxl: only disallow specific io's in vga mode
Date: Wed, 13 Jul 2011 17:49:56 +0300	[thread overview]
Message-ID: <1310568597-24181-11-git-send-email-alevy@redhat.com> (raw)
In-Reply-To: <1310568597-24181-1-git-send-email-alevy@redhat.com>

Since the driver is still in operation even after moving to UNDEFINED, i.e.
by destroying primary in any way.

Signed-off-by: Alon Levy <alevy@redhat.com>
---
 hw/qxl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/hw/qxl.c b/hw/qxl.c
index b34e8d0..5ea4c76 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1163,8 +1163,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val)
     case QXL_IO_LOG:
         break;
     default:
-        if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT)
+        if (d->mode != QXL_MODE_VGA) {
             break;
+        }
         dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n",
             __func__, io_port, io_port_to_string(io_port));
         /* be nice to buggy guest drivers */
-- 
1.7.6

  parent reply	other threads:[~2011-07-13 14:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 14:49 [Qemu-devel] [PATCHv4 00/11] async + suspend reworked Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 01/11] spice: add worker wrapper functions Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 02/11] spice: add qemu_spice_display_init_common Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 03/11] qxl: remove qxl_destroy_primary() Alon Levy
2011-07-14  8:33   ` Gerd Hoffmann
2011-07-14  9:27     ` Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 04/11] qxl: fix surface tracking & locking Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 05/11] qxl: add io_port_to_string Alon Levy
2011-07-14  8:37   ` Gerd Hoffmann
2011-07-14  8:52     ` Alon Levy
2011-07-14  8:40   ` Gerd Hoffmann
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 06/11] qxl: error handling fixes and cleanups Alon Levy
2011-07-14  8:42   ` Gerd Hoffmann
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments Alon Levy
2011-07-14  8:43   ` Gerd Hoffmann
2011-07-14  8:51     ` Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 08/11] qxl: bump pci rev Alon Levy
2011-07-14  8:44   ` Gerd Hoffmann
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 09/11] qxl: use QXL_REVISION_* Alon Levy
2011-07-14  8:46   ` Gerd Hoffmann
2011-07-14 10:06     ` Alon Levy
2011-07-13 14:49 ` Alon Levy [this message]
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 11/11] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310568597-24181-11-git-send-email-alevy@redhat.com \
    --to=alevy@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yhalperi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.