From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 2/6] drm/radeon: ATOM Endian fix for
	atombios_crtc_program_pll()
Date: Thu, 14 Jul 2011 07:40:44 +1000
Message-ID: <1310593244.4968.263.camel@pasglop>
References: <1310538495.4968.92.camel@pasglop>
	<CADnq5_Om6yhCC3Jo0mcqmXWj=moBu6RV1c3=Hns9pmQOTcLqDg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <CADnq5_Om6yhCC3Jo0mcqmXWj=moBu6RV1c3=Hns9pmQOTcLqDg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Alex Deucher <alexdeucher@gmail.com>
Cc: xorg-driver-ati@lists.x.org, dri-devel@lists.freedesktop.org, =?ISO-8859-1?Q?C=E9dric?= Cano <ccano@interfaceconcept.com>
List-Id: dri-devel@lists.freedesktop.org

On Wed, 2011-07-13 at 10:38 -0400, Alex Deucher wrote:

> >                case 6:
> > -                       args.v6.ulCrtcPclkFreq.ucCRTC = crtc_id;
> > -                       args.v6.ulCrtcPclkFreq.ulPixelClock = cpu_to_le32(clock / 10);
> > +                       args.v6.ulDispEngClkFreq = cpu_to_le32(crtc_id << 24 | clock / 10);
> 
> For clarity (i can never remember op precedence), you might put:
> 
> cpu_to_le32((crtc_id << 24) | (clock / 10));

I can't either but I have a nice chart printed on my wall :-)

I can respin if you really want but the above is correct.

Cheers,
Ben.

> Other than that,
> 
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> 
> 
> >                        args.v6.ucRefDiv = ref_div;
> >                        args.v6.usFbDiv = cpu_to_le16(fb_div);
> >                        args.v6.ulFbDivDecFrac = cpu_to_le32(frac_fb_div * 100000);
> >
> >
> >
> >