From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 4/6] drm/radeon: Add a rmb() in IH processing
Date: Fri, 15 Jul 2011 14:43:25 +1000
Message-ID: <1310705005.4968.306.camel@pasglop>
References: <1310538499.4968.94.camel@pasglop>
	<CAEdQ38GOgh6nnLCcTu4Z0mFurKCtmcMz8ycrw_xQSgMyQtieAA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <CAEdQ38GOgh6nnLCcTu4Z0mFurKCtmcMz8ycrw_xQSgMyQtieAA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Matt Turner <mattst88@gmail.com>
Cc: xorg-driver-ati@lists.x.org, Cedric Cano <ccano@interfaceconcept.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Fri, 2011-07-15 at 04:19 +0000, Matt Turner wrote:
> On Wed, Jul 13, 2011 at 6:28 AM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > We should have a read memory barrier between reading the WPTR from
> > memory and reading ring entries based on that value (ie, we need to
> > ensure both loads are done in order by the CPU).
> >
> > It could be argued that the MMIO reads in r600_ack_irq() might be
> > enough to get that barrier but I prefer keeping an explicit one just
> > in case.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> >
> > (resent adding dri-devel to the CC list to hit patchwork)
> >
> > drivers/gpu/drm/radeon/r600.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> > index 3c86b15..7e5c801 100644
> > --- a/drivers/gpu/drm/radeon/r600.c
> > +++ b/drivers/gpu/drm/radeon/r600.c
> > @@ -3312,6 +3312,9 @@ int r600_irq_process(struct radeon_device *rdev)
> >        }
> >
> >  restart_ih:
> > +       /* Order reading of wptr vs. reading of IH ring data */
> > +       wmb();
> > +
> >        /* display interrupts */
> >        r600_irq_ack(rdev);
> 
> The subject line says rmb(), but this says wmb(). Just want to verify
> what you have is correct.

Nice spotting, it's a typo and should have been rmb(). I'll fix it and
respin.

Cheers,
Ben