From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tarun Kanti DebBarma Subject: [PATCH v4 REPOST 19/20] gpio/omap: optimize suspend and resume functions Date: Sat, 16 Jul 2011 13:45:51 +0530 Message-ID: <1310804152-9243-20-git-send-email-tarun.kanti@ti.com> References: <1310804152-9243-1-git-send-email-tarun.kanti@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:49852 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757Ab1GPIQm (ORCPT ); Sat, 16 Jul 2011 04:16:42 -0400 In-Reply-To: <1310804152-9243-1-git-send-email-tarun.kanti@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: linux-omap@vger.kernel.org Cc: khilman@ti.com, santosh.shilimkar@ti.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Tarun Kanti DebBarma There is no need to operate on all the banks every time the function is called. Just operate on the current bank passed by the framework. Signed-off-by: Tarun Kanti DebBarma --- drivers/gpio/gpio-omap.c | 53 +++++++++++++++++++++------------------------ 1 files changed, 25 insertions(+), 28 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 6f52395..02a6c04 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1061,6 +1061,8 @@ static int __devinit omap_gpio_probe(struct platform_device *pdev) goto err_free; } + platform_set_drvdata(pdev, bank); + pm_runtime_enable(bank->dev); pm_runtime_irq_safe(bank->dev); if (IS_ERR_VALUE(pm_runtime_get_sync(bank->dev) < 0)) { @@ -1093,26 +1095,23 @@ err_exit: static int omap_gpio_suspend(struct device *dev) { - struct gpio_bank *bank; - - pm_runtime_get_sync(dev); + struct platform_device *pdev = to_platform_device(dev); + struct gpio_bank *bank = platform_get_drvdata(pdev); + void __iomem *base = bank->base; + void __iomem *wake_status; + unsigned long flags; - list_for_each_entry(bank, &omap_gpio_list, node) { - void __iomem *base = bank->base; - void __iomem *wake_status; - unsigned long flags; + if (!bank->regs->wkup_status || !bank->suspend_wakeup) + return 0; - if (!bank->regs->wkup_status) - return 0; + wake_status = bank->base + bank->regs->wkup_status; - wake_status = bank->base + bank->regs->wkup_status; + pm_runtime_get_sync(dev); - spin_lock_irqsave(&bank->lock, flags); - bank->saved_wakeup = __raw_readl(wake_status); - _gpio_rmw(base, bank->regs->wkup_status, - bank->suspend_wakeup, 1); - spin_unlock_irqrestore(&bank->lock, flags); - } + spin_lock_irqsave(&bank->lock, flags); + bank->saved_wakeup = __raw_readl(wake_status); + _gpio_rmw(base, bank->regs->wkup_status, bank->suspend_wakeup, 1); + spin_unlock_irqrestore(&bank->lock, flags); pm_runtime_put_sync(dev); @@ -1121,21 +1120,19 @@ static int omap_gpio_suspend(struct device *dev) static int omap_gpio_resume(struct device *dev) { - struct gpio_bank *bank; + struct platform_device *pdev = to_platform_device(dev); + struct gpio_bank *bank = platform_get_drvdata(pdev); + void __iomem *base = bank->base; + unsigned long flags; - pm_runtime_get_sync(dev); + if (!bank->regs->wkup_status || !bank->saved_wakeup) + return 0; - list_for_each_entry(bank, &omap_gpio_list, node) { - void __iomem *base = bank->base; - unsigned long flags; - - if (!bank->regs->wkup_status) - return 0; + pm_runtime_get_sync(dev); - spin_lock_irqsave(&bank->lock, flags); - _gpio_rmw(base, bank->regs->wkup_status, bank->saved_wakeup, 1); - spin_unlock_irqrestore(&bank->lock, flags); - } + spin_lock_irqsave(&bank->lock, flags); + _gpio_rmw(base, bank->regs->wkup_status, bank->saved_wakeup, 1); + spin_unlock_irqrestore(&bank->lock, flags); pm_runtime_put_sync(dev); -- 1.6.0.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: tarun.kanti@ti.com (Tarun Kanti DebBarma) Date: Sat, 16 Jul 2011 13:45:51 +0530 Subject: [PATCH v4 REPOST 19/20] gpio/omap: optimize suspend and resume functions In-Reply-To: <1310804152-9243-1-git-send-email-tarun.kanti@ti.com> References: <1310804152-9243-1-git-send-email-tarun.kanti@ti.com> Message-ID: <1310804152-9243-20-git-send-email-tarun.kanti@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org There is no need to operate on all the banks every time the function is called. Just operate on the current bank passed by the framework. Signed-off-by: Tarun Kanti DebBarma --- drivers/gpio/gpio-omap.c | 53 +++++++++++++++++++++------------------------ 1 files changed, 25 insertions(+), 28 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 6f52395..02a6c04 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1061,6 +1061,8 @@ static int __devinit omap_gpio_probe(struct platform_device *pdev) goto err_free; } + platform_set_drvdata(pdev, bank); + pm_runtime_enable(bank->dev); pm_runtime_irq_safe(bank->dev); if (IS_ERR_VALUE(pm_runtime_get_sync(bank->dev) < 0)) { @@ -1093,26 +1095,23 @@ err_exit: static int omap_gpio_suspend(struct device *dev) { - struct gpio_bank *bank; - - pm_runtime_get_sync(dev); + struct platform_device *pdev = to_platform_device(dev); + struct gpio_bank *bank = platform_get_drvdata(pdev); + void __iomem *base = bank->base; + void __iomem *wake_status; + unsigned long flags; - list_for_each_entry(bank, &omap_gpio_list, node) { - void __iomem *base = bank->base; - void __iomem *wake_status; - unsigned long flags; + if (!bank->regs->wkup_status || !bank->suspend_wakeup) + return 0; - if (!bank->regs->wkup_status) - return 0; + wake_status = bank->base + bank->regs->wkup_status; - wake_status = bank->base + bank->regs->wkup_status; + pm_runtime_get_sync(dev); - spin_lock_irqsave(&bank->lock, flags); - bank->saved_wakeup = __raw_readl(wake_status); - _gpio_rmw(base, bank->regs->wkup_status, - bank->suspend_wakeup, 1); - spin_unlock_irqrestore(&bank->lock, flags); - } + spin_lock_irqsave(&bank->lock, flags); + bank->saved_wakeup = __raw_readl(wake_status); + _gpio_rmw(base, bank->regs->wkup_status, bank->suspend_wakeup, 1); + spin_unlock_irqrestore(&bank->lock, flags); pm_runtime_put_sync(dev); @@ -1121,21 +1120,19 @@ static int omap_gpio_suspend(struct device *dev) static int omap_gpio_resume(struct device *dev) { - struct gpio_bank *bank; + struct platform_device *pdev = to_platform_device(dev); + struct gpio_bank *bank = platform_get_drvdata(pdev); + void __iomem *base = bank->base; + unsigned long flags; - pm_runtime_get_sync(dev); + if (!bank->regs->wkup_status || !bank->saved_wakeup) + return 0; - list_for_each_entry(bank, &omap_gpio_list, node) { - void __iomem *base = bank->base; - unsigned long flags; - - if (!bank->regs->wkup_status) - return 0; + pm_runtime_get_sync(dev); - spin_lock_irqsave(&bank->lock, flags); - _gpio_rmw(base, bank->regs->wkup_status, bank->saved_wakeup, 1); - spin_unlock_irqrestore(&bank->lock, flags); - } + spin_lock_irqsave(&bank->lock, flags); + _gpio_rmw(base, bank->regs->wkup_status, bank->saved_wakeup, 1); + spin_unlock_irqrestore(&bank->lock, flags); pm_runtime_put_sync(dev); -- 1.6.0.4