All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei LIU <liuw@liuw.name>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xensource.com, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 1 of 6 V2] libxl: Give the HVM domain type the name "HVM"
Date: Mon, 18 Jul 2011 22:56:51 +0800	[thread overview]
Message-ID: <1311001011.17071.13.camel@iceland> (raw)
In-Reply-To: <90e2ae994ebbc37ba627.1310997430@localhost.localdomain>

On Mon, 2011-07-18 at 14:57 +0100, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1310997149 -3600
> # Node ID 90e2ae994ebbc37ba6279b9071ab2e76c2ebeec2
> # Parent  b18728227bf9e45058a4cc22425d1d35317e2c8d
> libxl: Give the HVM domain type the name "HVM"
> 
> This is generally used in the Xen universe, rather than "FV" which is
> not used elsewhere.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> diff -r b18728227bf9 -r 90e2ae994ebb tools/libxl/libxl.idl
> --- a/tools/libxl/libxl.idl	Mon Jul 18 14:52:29 2011 +0100
> +++ b/tools/libxl/libxl.idl	Mon Jul 18 14:52:29 2011 +0100
> @@ -21,7 +21,7 @@ libxl_hwcap = Builtin("hwcap")
>  #
>  
>  libxl_domain_type = Enumeration("domain_type", [
> -    (1, "FV"),
> +    (1, "HVM"),
>      (2, "PV"),
>      ])
>  
> diff -r b18728227bf9 -r 90e2ae994ebb tools/libxl/libxl_dm.c
> --- a/tools/libxl/libxl_dm.c	Mon Jul 18 14:52:29 2011 +0100
> +++ b/tools/libxl/libxl_dm.c	Mon Jul 18 14:52:29 2011 +0100
> @@ -144,7 +144,7 @@ static char ** libxl__build_device_model
>      if (info->serial) {
>          flexarray_vappend(dm_args, "-serial", info->serial, NULL);
>      }
> -    if (info->type == LIBXL_DOMAIN_TYPE_FV) {
> +    if (info->type == LIBXL_DOMAIN_TYPE_HVM) {
>          int ioemu_vifs = 0;
>  
>          if (info->videoram) {
> @@ -211,7 +211,7 @@ static char ** libxl__build_device_model
>      case LIBXL_DOMAIN_TYPE_PV:
>          flexarray_append(dm_args, "xenpv");
>          break;
> -    case LIBXL_DOMAIN_TYPE_FV:
> +    case LIBXL_DOMAIN_TYPE_HVM:
>          flexarray_append(dm_args, "xenfv");
>          break;
>      }
> @@ -336,7 +336,7 @@ static char ** libxl__build_device_model
>      if (info->serial) {
>          flexarray_vappend(dm_args, "-serial", info->serial, NULL);
>      }
> -    if (info->type == LIBXL_DOMAIN_TYPE_FV) {
> +    if (info->type == LIBXL_DOMAIN_TYPE_HVM) {
>          int ioemu_vifs = 0;
>  
>          if (info->stdvga) {
> @@ -408,7 +408,7 @@ static char ** libxl__build_device_model
>      case LIBXL_DOMAIN_TYPE_PV:
>          flexarray_append(dm_args, "xenpv");
>          break;
> -    case LIBXL_DOMAIN_TYPE_FV:
> +    case LIBXL_DOMAIN_TYPE_HVM:
>          flexarray_append(dm_args, "xenfv");

QEMU uses the term "xenfv", this is a terminology mismatch between QEMU
and Xen...

Wei.

>          break;
>      }
> @@ -417,7 +417,7 @@ static char ** libxl__build_device_model
>      flexarray_append(dm_args, "-m");
>      flexarray_append(dm_args, libxl__sprintf(gc, "%d", info->target_ram));
>  
> -    if (info->type == LIBXL_DOMAIN_TYPE_FV) {
> +    if (info->type == LIBXL_DOMAIN_TYPE_HVM) {
>          for (i = 0; i < num_disks; i++) {
>              int disk, part;
>              int dev_number =
> diff -r b18728227bf9 -r 90e2ae994ebb tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c	Mon Jul 18 14:52:29 2011 +0100
> +++ b/tools/libxl/xl_cmdimpl.c	Mon Jul 18 14:52:29 2011 +0100
> @@ -1083,7 +1083,7 @@ skip_vfb:
>      }
>  
>      dm_info->type = c_info->hvm ?
> -        LIBXL_DOMAIN_TYPE_FV :
> +        LIBXL_DOMAIN_TYPE_HVM :
>          LIBXL_DOMAIN_TYPE_PV;
>  
>      xlu_cfg_destroy(config);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

  reply	other threads:[~2011-07-18 14:56 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 18:37 [RFC 0/3] libxl event handling Ian Jackson
2011-07-12 18:37 ` [PATCH 1/3] RFC: libxl: API changes re domain type (and keyed union semantics) Ian Jackson
2011-07-12 18:37   ` [PATCH 2/3] RFC: libxl: API changes re event handling Ian Jackson
2011-07-12 18:37     ` [PATCH 3/3] RFC: libxl: internal API for " Ian Jackson
2011-07-13 10:22       ` Ian Campbell
2011-07-13 10:21     ` [PATCH 2/3] RFC: libxl: API changes re " Ian Campbell
2011-07-13 14:03       ` Ian Jackson
2011-07-13 16:08         ` Ian Campbell
2011-07-13 16:17           ` Ian Jackson
2011-07-13 16:33             ` Ian Campbell
2011-07-13 17:04               ` Ian Jackson
2011-07-13  9:19   ` [PATCH 1/3] RFC: libxl: API changes re domain type (and keyed union semantics) Ian Campbell
2011-07-15 12:45   ` Ian Campbell
2011-07-15 13:13     ` Ian Jackson
2011-07-18  9:06       ` [PATCH 0 of 6] libxl: IDL improvements Ian Campbell
2011-07-18  9:06         ` [PATCH 1 of 6] libxl: Give the HVM domain type the name "HVM" Ian Campbell
2011-07-18  9:06         ` [PATCH 2 of 6] libxl: replace libxl__domain_is_hvm with libxl__domain_type Ian Campbell
2011-07-18  9:06         ` [PATCH 3 of 6] libxl: specify HVM vs PV in build_info using libxl_domain_type enum Ian Campbell
2011-07-18  9:06         ` [PATCH 4 of 6] libxl: specify HVM vs PV in create_info " Ian Campbell
2011-07-18  9:06         ` [PATCH 5 of 6] libxl: use libxl_domain_type enum with libxl__domain_suspend_common Ian Campbell
2011-07-18  9:06         ` [PATCH 6 of 6] libxl: Keyed unions key off an enum instead of an arbitrary expression Ian Campbell
2011-07-18 13:57       ` [PATCH 0 of 6 V2] libxl: IDL improvements Ian Campbell
2011-07-18 13:57         ` [PATCH 1 of 6 V2] libxl: Give the HVM domain type the name "HVM" Ian Campbell
2011-07-18 14:56           ` Wei LIU [this message]
2011-07-18 15:20             ` Ian Jackson
2011-07-18 13:57         ` [PATCH 2 of 6 V2] libxl: replace libxl__domain_is_hvm with libxl__domain_type Ian Campbell
2011-07-18 13:57         ` [PATCH 3 of 6 V2] libxl: specify HVM vs PV in build_info using libxl_domain_type enum Ian Campbell
2011-07-18 13:57         ` [PATCH 4 of 6 V2] libxl: specify HVM vs PV in create_info " Ian Campbell
2011-07-18 13:57         ` [PATCH 5 of 6 V2] libxl: use libxl_domain_type enum with libxl__domain_suspend_common Ian Campbell
2011-07-18 13:57         ` [PATCH 6 of 6 V2] libxl: Keyed unions key off an enum instead of an arbitrary expression Ian Campbell
2011-07-18 16:11         ` [PATCH 0 of 6 V2] libxl: IDL improvements Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311001011.17071.13.camel@iceland \
    --to=liuw@liuw.name \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.