All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex,Shi" <alex.shi@intel.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Fu, Michael" <michael.fu@intel.com>,
	"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>
Subject: Re: nohz: remove nohz_cpu_mask
Date: Tue, 19 Jul 2011 08:53:20 +0800	[thread overview]
Message-ID: <1311036800.27358.26.camel@debian> (raw)
In-Reply-To: <1310691105.28599.277.camel@debian>

Thomas: 

Maybe you omit this thread, So I ping you again. :) 
What's your opinion of this patch? I will be glad to hear from you for
any messages. 

Regards!
Alex 
On Fri, 2011-07-15 at 08:51 +0800, Alex,Shi wrote:
> On Tue, 2011-07-12 at 01:30 +0800, Paul E. McKenney wrote:
> > On Mon, Jul 11, 2011 at 08:47:05AM +0800, Alex,Shi wrote:
> > > RCU didn't use this global variable now. Currently no user on it.
> > 
> > Indeed.  RCU's use of it turned out to be quite buggy.  :-(
> > 
> > > Since the ts->do_timer_last is not the real last periodic tick cpu in
> > > most of time. I once want to compare the cpu_online_mask and
> > > nohz_cpu_mask to get a real one, and than only let that cpu sleep
> > > shorter, other cpu will try to sleep KTIME_MAX, that need a extra lock
> > > for nohz_cpu_mask. But I checked my all platforms, from NHM-EX server to
> > > laptops, all of them are waked up a few times per second. So, the
> > > advantage is only in theory. 
> > > 
> > > Since no clear usage of this variable, why not remove it? That can save
> > > a cache-line in all cpus and reduce atomic sync contention.
> > 
> > Works for me!
> > 
> > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > 
> 
> Thomas, would you like to give some comments of this? 
> 
> Best regards!
> Alex



      reply	other threads:[~2011-07-19  0:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  0:47 nohz: remove nohz_cpu_mask Alex,Shi
2011-07-11 17:30 ` Paul E. McKenney
2011-07-15  0:51   ` Alex,Shi
2011-07-19  0:53     ` Alex,Shi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311036800.27358.26.camel@debian \
    --to=alex.shi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.fu@intel.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.