From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] Introduce QEMU_NEW()
Date: Mon, 25 Jul 2011 12:37:14 +0300
Message-ID: <1311586634.3446.35.camel@lappy>
References: <1311583872-362-1-git-send-email-avi@redhat.com>
	 <F5157821-87B0-4A2B-9E12-3C3EA98EBF5D@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:61335 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751100Ab1GYJhr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Jul 2011 05:37:47 -0400
Received: by wyg8 with SMTP id 8so2611299wyg.19
        for <kvm@vger.kernel.org>; Mon, 25 Jul 2011 02:37:46 -0700 (PDT)
In-Reply-To: <F5157821-87B0-4A2B-9E12-3C3EA98EBF5D@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2011-07-25 at 11:32 +0200, Alexander Graf wrote:
> On 25.07.2011, at 10:51, Avi Kivity wrote:
> 
> > qemu_malloc() is type-unsafe as it returns a void pointer.  Introduce
> > QEMU_NEW() (and QEMU_NEWZ()), which return the correct type.
> 
> What does this buy you over
> 
> type *x = qemu_malloc(sizeof(type));
> 
> ? I find the non-C++ version easier to read even.

It'll warn when you do silly things such as:

struct some_struct *k;

k = qemu_malloc(sizeof(k));

-- 

Sasha.


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47603)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1QlHbg-0002st-T0
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 05:37:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1QlHbf-0002O2-Pj
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 05:37:48 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:35659)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1QlHbf-0002Ny-LP
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 05:37:47 -0400
Received: by wwf26 with SMTP id 26so3473582wwf.10
	for <qemu-devel@nongnu.org>; Mon, 25 Jul 2011 02:37:46 -0700 (PDT)
From: Sasha Levin <levinsasha928@gmail.com>
In-Reply-To: <F5157821-87B0-4A2B-9E12-3C3EA98EBF5D@suse.de>
References: <1311583872-362-1-git-send-email-avi@redhat.com>
	<F5157821-87B0-4A2B-9E12-3C3EA98EBF5D@suse.de>
Content-Type: text/plain; charset="us-ascii"
Date: Mon, 25 Jul 2011 12:37:14 +0300
Message-ID: <1311586634.3446.35.camel@lappy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Mon, 2011-07-25 at 11:32 +0200, Alexander Graf wrote:
> On 25.07.2011, at 10:51, Avi Kivity wrote:
> 
> > qemu_malloc() is type-unsafe as it returns a void pointer.  Introduce
> > QEMU_NEW() (and QEMU_NEWZ()), which return the correct type.
> 
> What does this buy you over
> 
> type *x = qemu_malloc(sizeof(type));
> 
> ? I find the non-C++ version easier to read even.

It'll warn when you do silly things such as:

struct some_struct *k;

k = qemu_malloc(sizeof(k));

-- 

Sasha.