* [PATCH] OMAP: omap_device: make latency autoadjust messages debug
@ 2011-07-25 13:18 ` Grazvydas Ignotas
0 siblings, 0 replies; 4+ messages in thread
From: Grazvydas Ignotas @ 2011-07-25 13:18 UTC (permalink / raw)
To: linux-omap
Cc: Kevin Hilman, Grazvydas Ignotas, linux-arm-kernel, Steve Sakoman
During normal system operation warning messages similar to this
are appearing quite often:
omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035
This doesn't seem to be reporting a problem, nor is it very useful for
non-developers, so reduce it to debug level.
Cc: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
---
Applies on top of git://git.pwsan.com/linux-2.6 prcm-devel-3.1
+ Kevin's "OMAP: omap_device: replace pr_* prints with dev_*".
arch/arm/plat-omap/omap_device.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
index 1914d7e..f363cbf 100644
--- a/arch/arm/plat-omap/omap_device.c
+++ b/arch/arm/plat-omap/omap_device.c
@@ -146,10 +146,10 @@ static int _omap_device_activate(struct omap_device *od, u8 ignore_lat)
odpl->activate_lat_worst = act_lat;
if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
odpl->activate_lat = act_lat;
- dev_warn(&od->pdev.dev,
- "new worst case activate latency "
- "%d: %llu\n",
- od->pm_lat_level, act_lat);
+ dev_dbg(&od->pdev.dev,
+ "new worst case activate latency "
+ "%d: %llu\n",
+ od->pm_lat_level, act_lat);
} else
dev_warn(&od->pdev.dev,
"activate latency %d "
@@ -213,10 +213,10 @@ static int _omap_device_deactivate(struct omap_device *od, u8 ignore_lat)
odpl->deactivate_lat_worst = deact_lat;
if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
odpl->deactivate_lat = deact_lat;
- dev_warn(&od->pdev.dev,
- "new worst case deactivate latency "
- "%d: %llu\n",
- od->pm_lat_level, deact_lat);
+ dev_dbg(&od->pdev.dev,
+ "new worst case deactivate latency "
+ "%d: %llu\n",
+ od->pm_lat_level, deact_lat);
} else
dev_warn(&od->pdev.dev,
"deactivate latency %d "
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] OMAP: omap_device: make latency autoadjust messages debug
@ 2011-07-25 13:18 ` Grazvydas Ignotas
0 siblings, 0 replies; 4+ messages in thread
From: Grazvydas Ignotas @ 2011-07-25 13:18 UTC (permalink / raw)
To: linux-arm-kernel
During normal system operation warning messages similar to this
are appearing quite often:
omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035
This doesn't seem to be reporting a problem, nor is it very useful for
non-developers, so reduce it to debug level.
Cc: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
---
Applies on top of git://git.pwsan.com/linux-2.6 prcm-devel-3.1
+ Kevin's "OMAP: omap_device: replace pr_* prints with dev_*".
arch/arm/plat-omap/omap_device.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
index 1914d7e..f363cbf 100644
--- a/arch/arm/plat-omap/omap_device.c
+++ b/arch/arm/plat-omap/omap_device.c
@@ -146,10 +146,10 @@ static int _omap_device_activate(struct omap_device *od, u8 ignore_lat)
odpl->activate_lat_worst = act_lat;
if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
odpl->activate_lat = act_lat;
- dev_warn(&od->pdev.dev,
- "new worst case activate latency "
- "%d: %llu\n",
- od->pm_lat_level, act_lat);
+ dev_dbg(&od->pdev.dev,
+ "new worst case activate latency "
+ "%d: %llu\n",
+ od->pm_lat_level, act_lat);
} else
dev_warn(&od->pdev.dev,
"activate latency %d "
@@ -213,10 +213,10 @@ static int _omap_device_deactivate(struct omap_device *od, u8 ignore_lat)
odpl->deactivate_lat_worst = deact_lat;
if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
odpl->deactivate_lat = deact_lat;
- dev_warn(&od->pdev.dev,
- "new worst case deactivate latency "
- "%d: %llu\n",
- od->pm_lat_level, deact_lat);
+ dev_dbg(&od->pdev.dev,
+ "new worst case deactivate latency "
+ "%d: %llu\n",
+ od->pm_lat_level, deact_lat);
} else
dev_warn(&od->pdev.dev,
"deactivate latency %d "
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] OMAP: omap_device: make latency autoadjust messages debug
2011-07-25 13:18 ` Grazvydas Ignotas
@ 2011-08-05 14:52 ` Kevin Hilman
-1 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2011-08-05 14:52 UTC (permalink / raw)
To: Grazvydas Ignotas; +Cc: linux-omap, linux-arm-kernel, Steve Sakoman
Grazvydas Ignotas <notasas@gmail.com> writes:
> During normal system operation warning messages similar to this
> are appearing quite often:
> omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035
>
> This doesn't seem to be reporting a problem, nor is it very useful for
> non-developers, so reduce it to debug level.
Yeah, this is really only useful for PM developers, so making it debug
is fine.
> Cc: Steve Sakoman <steve@sakoman.com>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> Applies on top of git://git.pwsan.com/linux-2.6 prcm-devel-3.1
> + Kevin's "OMAP: omap_device: replace pr_* prints with dev_*".
Adding it to my omap_device queue for v3.2:
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.2/omap_device
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] OMAP: omap_device: make latency autoadjust messages debug
@ 2011-08-05 14:52 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2011-08-05 14:52 UTC (permalink / raw)
To: linux-arm-kernel
Grazvydas Ignotas <notasas@gmail.com> writes:
> During normal system operation warning messages similar to this
> are appearing quite often:
> omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035
>
> This doesn't seem to be reporting a problem, nor is it very useful for
> non-developers, so reduce it to debug level.
Yeah, this is really only useful for PM developers, so making it debug
is fine.
> Cc: Steve Sakoman <steve@sakoman.com>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> Applies on top of git://git.pwsan.com/linux-2.6 prcm-devel-3.1
> + Kevin's "OMAP: omap_device: replace pr_* prints with dev_*".
Adding it to my omap_device queue for v3.2:
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.2/omap_device
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-05 14:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-25 13:18 [PATCH] OMAP: omap_device: make latency autoadjust messages debug Grazvydas Ignotas
2011-07-25 13:18 ` Grazvydas Ignotas
2011-08-05 14:52 ` Kevin Hilman
2011-08-05 14:52 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.