From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756186Ab1G0WKo (ORCPT ); Wed, 27 Jul 2011 18:10:44 -0400 Received: from mail.perches.com ([173.55.12.10]:4337 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755494Ab1G0WKk (ORCPT ); Wed, 27 Jul 2011 18:10:40 -0400 Subject: Re: [U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages From: Joe Perches To: Wolfgang Denk Cc: Andy Whitcroft , Andrew Morton , Graeme Russ , U-Boot Users , linux-kernel@vger.kernel.org In-Reply-To: <20110727211707.139ED15794C3@gemini.denx.de> References: <1303713156.1745.38.camel@Joe-Laptop> <20110727211707.139ED15794C3@gemini.denx.de> Content-Type: text/plain; charset="UTF-8" Date: Wed, 27 Jul 2011 15:10:39 -0700 Message-ID: <1311804639.21169.22.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-07-27 at 23:17 +0200, Wolfgang Denk wrote: > Dear Joe, > In message you wrote: > > Some users would like the ability to not emit some of the > > messages that checkpatch produces. > > Add command line option to "--ignore" various message types. > > Add .checkpatch.conf file to store a default set of "ignore" flags > > Categorize all ERROR, WARN and CHK types with flags. > > Signed-off-by: Joe Perches > > --- > > scripts/checkpatch.pl | 456 +++++++++++++++++++++++++++++++++++-------------- > > 1 files changed, 327 insertions(+), 129 deletions(-) > Did you receive any feedback for your proposal, especially from Andrew > Morton? > This feature would be really useful for us, but I'd rather see this in > mainline than starting a fork. A better version is in Linus' current 3.0+ as of a couple of days ago. It's not in 3.0. commit 000d1cc1829f938c87402fc2fd4bb5e8daed6b52 Author: Joe Perches Date: Mon Jul 25 17:13:25 2011 -0700 checkpatch.pl: add ability to ignore various messages Some users would like the ability to not emit some of the messages that checkpatch produces. This can make it easier to use checkpatch in other projects and integrate into scm hook scripts. Add command line option to "--ignore" various message types. Add option --show-types to emit the "type" of each message. Categorize all ERROR, WARN and CHK messages with types. Add optional .checkpatch.conf file to store default options. 3 paths are searched for .checkpatch.conf . customized per-tree configurations $HOME user global configuration when per-tree configs don't exis ./scripts lk defaults to override script The .conf file can contain any valid command-line argument and the contents are prepended to any additional command line arguments. Multiple lines may be used, blank lines are ignored, # is a comment. Update "false positive" output for readability. Update version to 0.32 Signed-off-by: Joe Perches Acked-by: Mike Frysinger Cc: Andy Whitcroft Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Wed, 27 Jul 2011 15:10:39 -0700 Subject: [U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages In-Reply-To: <20110727211707.139ED15794C3@gemini.denx.de> References: <1303713156.1745.38.camel@Joe-Laptop> <20110727211707.139ED15794C3@gemini.denx.de> Message-ID: <1311804639.21169.22.camel@Joe-Laptop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2011-07-27 at 23:17 +0200, Wolfgang Denk wrote: > Dear Joe, > In message you wrote: > > Some users would like the ability to not emit some of the > > messages that checkpatch produces. > > Add command line option to "--ignore" various message types. > > Add .checkpatch.conf file to store a default set of "ignore" flags > > Categorize all ERROR, WARN and CHK types with flags. > > Signed-off-by: Joe Perches > > --- > > scripts/checkpatch.pl | 456 +++++++++++++++++++++++++++++++++++-------------- > > 1 files changed, 327 insertions(+), 129 deletions(-) > Did you receive any feedback for your proposal, especially from Andrew > Morton? > This feature would be really useful for us, but I'd rather see this in > mainline than starting a fork. A better version is in Linus' current 3.0+ as of a couple of days ago. It's not in 3.0. commit 000d1cc1829f938c87402fc2fd4bb5e8daed6b52 Author: Joe Perches Date: Mon Jul 25 17:13:25 2011 -0700 checkpatch.pl: add ability to ignore various messages Some users would like the ability to not emit some of the messages that checkpatch produces. This can make it easier to use checkpatch in other projects and integrate into scm hook scripts. Add command line option to "--ignore" various message types. Add option --show-types to emit the "type" of each message. Categorize all ERROR, WARN and CHK messages with types. Add optional .checkpatch.conf file to store default options. 3 paths are searched for .checkpatch.conf . customized per-tree configurations $HOME user global configuration when per-tree configs don't exis ./scripts lk defaults to override script The .conf file can contain any valid command-line argument and the contents are prepended to any additional command line arguments. Multiple lines may be used, blank lines are ignored, # is a comment. Update "false positive" output for readability. Update version to 0.32 Signed-off-by: Joe Perches Acked-by: Mike Frysinger Cc: Andy Whitcroft Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds