From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Francis Moreau <francis.moro@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Don Zickus <dzickus@redhat.com>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@elte.hu>, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: v3.0: Weird kernel log message when resuming avout NMI received
Date: Mon, 01 Aug 2011 14:12:34 +0200 [thread overview]
Message-ID: <1312200754.2617.454.camel@laptop> (raw)
In-Reply-To: <20110801112102.GQ2209@sun>
On Mon, 2011-08-01 at 15:21 +0400, Cyrill Gorcunov wrote:
> > mutex_lock(&swhash->hlist_mutex);
> > - if (swhash->hlist_refcount > 0) {
> > + if (swhash->hlist_refcount > 0 && !swhash->swevent_hlist) {
>
> Should not there be rcu_dereference(swhash->swevent_hlist)?
swhash->hlist_mutex is the modifier lock for that rcu use and should
thus serialize things sufficiently.
next prev parent reply other threads:[~2011-08-01 12:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 6:56 v3.0: Weird kernel log message when resuming avout NMI received Francis Moreau
2011-07-31 11:06 ` Cyrill Gorcunov
2011-07-31 11:19 ` Jiri Slaby
2011-07-31 11:26 ` Cyrill Gorcunov
2011-08-02 19:48 ` Don Zickus
2011-08-02 21:00 ` Jiri Slaby
2011-08-03 0:52 ` Donald Zickus II
2011-07-31 15:20 ` Francis Moreau
2011-07-31 15:32 ` Cyrill Gorcunov
2011-08-01 11:05 ` Peter Zijlstra
2011-08-01 11:21 ` Cyrill Gorcunov
2011-08-01 12:12 ` Peter Zijlstra [this message]
2011-08-15 8:37 ` Francis Moreau
2011-08-16 15:07 ` Francis Moreau
2011-08-02 19:52 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312200754.2617.454.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=francis.moro@gmail.com \
--cc=gorcunov@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.