On Mon, 2011-08-01 at 07:49 -0700, Nicolas Ferre wrote: > On 07/31/2011 04:27 AM, Jeff Kirsher wrote: > > Move the Atmel driver into drivers/net/ethernet/cadence/ and > > make the necessary Kconfig and Makefile changes. > > > > CC: Nicolas Ferre > > You can add my: > Acked-by: Nicolas Ferre > > > CC: Jamie Iles > > Signed-off-by: Jeff Kirsher Nicolas/Jamie- I have a v3 series of patches coming out here imminently, and I have tweaked the Kconfig just a bit based on feedback from others. Since the "tweak" made sense for all the Kconfig, I applied it across the board. Here is the new Kconfig: +# +# Atmel device configuration +# + +config HAVE_NET_MACB + bool + +config NET_ATMEL + bool "Atmel devices" + depends on HAVE_NET_MACB || (ARM && ARCH_AT91RM9200) + ---help--- + If you have a network (Ethernet) card belonging to this class, say Y. + Make sure you know the name of your card. Read the Ethernet-HOWTO, + available from . + + If unsure, say Y. + + Note that the answer to this question doesn't directly affect the + kernel: saying N will just cause the configurator to skip all + the remaining Atmel network card questions. If you say Y, you will be + asked for your specific card in the following questions. + +if NET_ATMEL + +config ARM_AT91_ETHER + tristate "AT91RM9200 Ethernet support" + depends on ARM && ARCH_AT91RM9200 + select MII + ---help--- + If you wish to compile a kernel for the AT91RM9200 and enable + ethernet support, then you should always answer Y to this. + +config MACB + tristate "Atmel MACB support" + depends on HAVE_NET_MACB + select PHYLIB + ---help--- + The Atmel MACB ethernet interface is found on many AT32 and AT91 + parts. Say Y to include support for the MACB chip. + + To compile this driver as a module, choose M here: the module + will be called macb. + +endif # NET_ATMEL If these changes are fine, I can add your ACK's.