From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905Ab1HHJDu (ORCPT ); Mon, 8 Aug 2011 05:03:50 -0400 Received: from casper.infradead.org ([85.118.1.10]:43788 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821Ab1HHJDs convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2011 05:03:48 -0400 Subject: Re: [PATCH v2 6/6] perf tool: Parse general/raw events from sysfs From: Peter Zijlstra To: Lin Ming Cc: Stephane Eranian , Ingo Molnar , Andi Kleen , Arnaldo Carvalho de Melo , linux-kernel Date: Mon, 08 Aug 2011 11:03:27 +0200 In-Reply-To: <1312793866.4115.5.camel@minggr.sh.intel.com> References: <1310740503-15608-1-git-send-email-ming.m.lin@intel.com> <1310740503-15608-7-git-send-email-ming.m.lin@intel.com> <1312673888.2664.18.camel@hp6530s> <1312765681.3938.1668.camel@minggr.sh.intel.com> <1312793298.10488.2.camel@twins> <1312793866.4115.5.camel@minggr.sh.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.0.2- Message-ID: <1312794207.10488.6.camel@twins> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-08-08 at 16:57 +0800, Lin Ming wrote: > On Mon, 2011-08-08 at 16:48 +0800, Peter Zijlstra wrote: > > On Mon, 2011-08-08 at 09:08 +0800, Lin Ming wrote: > > > > > > We only need to register one pmu with two same graphics cards. > > > Then we can overload pid argument of sys_perf_event_open() to > > > differentiate each instance of graphic card. > > > > > > Just like perf cgroup does. > > > > I don't like that much at all.. For one it will make it impossible to > > put the pmu device in the right sysfs topology. > > So do you prefer adding a number to gpu name, as Stephane mentioned? Not quite having read back that far (reading my email in date-reverse manner this morning), yeah. That allows links from /sys/bus/pci/... back to the pmu device.