All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com
Subject: [Qemu-devel] [PATCH 09/11] serial: Convert serial_isa_initfn to MemoryRegion.
Date: Wed, 10 Aug 2011 15:28:18 -0700	[thread overview]
Message-ID: <1313015300-23920-10-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1313015300-23920-1-git-send-email-rth@twiddle.net>

The serial_mm_init path is as yet unconverted.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 hw/serial.c |   15 ++++++++++++---
 1 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/hw/serial.c b/hw/serial.c
index 0ee61dd..466de21 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -157,6 +157,7 @@ struct SerialState {
 
 typedef struct ISASerialState {
     ISADevice dev;
+    MemoryRegion io;
     uint32_t index;
     uint32_t iobase;
     uint32_t isairq;
@@ -755,6 +756,15 @@ void serial_set_frequency(SerialState *s, uint32_t frequency)
 static const int isa_serial_io[MAX_SERIAL_PORTS] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
 static const int isa_serial_irq[MAX_SERIAL_PORTS] = { 4, 3, 4, 3 };
 
+static const MemoryRegionPortio serial_portio[] = {
+    { 0, 8, 1, .read = serial_ioport_read, .write = serial_ioport_write },
+    PORTIO_END_OF_LIST()
+};
+
+static const MemoryRegionOps serial_io_ops = {
+    .old_portio = serial_portio
+};
+
 static int serial_isa_initfn(ISADevice *dev)
 {
     static int index;
@@ -776,9 +786,8 @@ static int serial_isa_initfn(ISADevice *dev)
     serial_init_core(s);
     qdev_set_legacy_instance_id(&dev->qdev, isa->iobase, 3);
 
-    register_ioport_write(isa->iobase, 8, 1, serial_ioport_write, s);
-    register_ioport_read(isa->iobase, 8, 1, serial_ioport_read, s);
-    isa_init_ioport_range(dev, isa->iobase, 8);
+    memory_region_init_io(&isa->io, &serial_io_ops, s, "serial", 8);
+    isa_register_ioport(dev, &isa->io, isa->iobase);
     return 0;
 }
 
-- 
1.7.6

  parent reply	other threads:[~2011-08-10 22:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 22:28 [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 01/11] pci: add pci_address_space_io() Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 02/11] isa: Pass i/o address space to isa_bus_new Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 03/11] isa: add isa_register_ioport() Richard Henderson
2011-08-11  6:18   ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 04/11] pc: Re-order pc_init1 to initialize the ISA bus before ISA devices Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion Richard Henderson
2011-08-11  6:22   ` Avi Kivity
2011-08-11  6:27     ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 06/11] i8254: " Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 07/11] i8259: " Richard Henderson
2011-08-28 15:25   ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 08/11] pckbd: " Richard Henderson
2011-08-10 22:28 ` Richard Henderson [this message]
2011-08-10 22:28 ` [Qemu-devel] [PATCH 10/11] memory: Fix old_portio vs non-zero offset Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 11/11] fdc: Convert isabus_fdc_init1 to MemoryRegion Richard Henderson
2011-08-11  7:48 ` [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA Avi Kivity
2011-08-11  8:05   ` Edgar E. Iglesias
2011-08-11  8:20     ` Avi Kivity
2011-08-11 10:24       ` Edgar E. Iglesias
2011-08-11 11:19         ` Avi Kivity
2011-08-11 14:58   ` Richard Henderson
2011-08-11 15:16     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313015300-23920-10-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.