* [PATCH] libcxgbi: Fix some build warnings missed during cleanup of a previous patch
@ 2011-08-11 10:47 Neil Horman
2011-08-11 14:04 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Neil Horman @ 2011-08-11 10:47 UTC (permalink / raw)
To: linux-scsi
Cc: Neil Horman, Divy Le Ray, Steve Wise, Karen Xie, Mike Christie,
James E.J. Bottomley
I recently submitted this:
http://marc.info/?l=linux-scsi&m=131228153521094&w=2
Patch to fix an oops in the cxgb3i iscsi driver. I did what I thought was some
minor cleanup after testing and prior to submission. Of course that bit me, and
and a result I introduced some build warnings that really don't need to be
there. This patch corrects them. Apologies for the noise
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Divy Le Ray <divy@chelsio.com>
CC: Steve Wise <swise@chelsio.com>
CC: Karen Xie <kxie@chelsio.com>
CC: Mike Christie <michaelc@cs.wisc.edu>
CC: "James E.J. Bottomley" <JBottomley@parallels.com>
---
drivers/scsi/cxgbi/libcxgbi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index eb5625d..0890728 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -475,7 +475,7 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
struct sockaddr_in *daddr = (struct sockaddr_in *)dst_addr;
struct dst_entry *dst;
struct net_device *ndev;
- struct cxgbi_device *cdev;
+ struct cxgbi_device *cdev = NULL;
struct rtable *rt = NULL;
struct flowi4 fl4;
struct cxgbi_sock *csk = NULL;
@@ -2499,7 +2499,7 @@ struct iscsi_endpoint *cxgbi_ep_connect(struct Scsi_Host *shost,
return ep;
release_conn:
- cdev_put(&csk->cdev);
+ cdev_put(csk->cdev);
cxgbi_sock_put(csk);
cxgbi_sock_closed(csk);
err_out:
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libcxgbi: Fix some build warnings missed during cleanup of a previous patch
2011-08-11 10:47 [PATCH] libcxgbi: Fix some build warnings missed during cleanup of a previous patch Neil Horman
@ 2011-08-11 14:04 ` James Bottomley
2011-08-11 14:45 ` Neil Horman
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2011-08-11 14:04 UTC (permalink / raw)
To: Neil Horman; +Cc: linux-scsi, Divy Le Ray, Steve Wise, Karen Xie, Mike Christie
On Thu, 2011-08-11 at 06:47 -0400, Neil Horman wrote:
> I recently submitted this:
> http://marc.info/?l=linux-scsi&m=131228153521094&w=2
>
> Patch to fix an oops in the cxgb3i iscsi driver. I did what I thought was some
> minor cleanup after testing and prior to submission. Of course that bit me, and
> and a result I introduced some build warnings that really don't need to be
> there. This patch corrects them. Apologies for the noise
OK, so since the previous patch was a bug fix, can you resend the
complete, clean bug fix with a stable tag.
Thanks,
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libcxgbi: Fix some build warnings missed during cleanup of a previous patch
2011-08-11 14:04 ` James Bottomley
@ 2011-08-11 14:45 ` Neil Horman
0 siblings, 0 replies; 3+ messages in thread
From: Neil Horman @ 2011-08-11 14:45 UTC (permalink / raw)
To: James Bottomley
Cc: linux-scsi, Divy Le Ray, Steve Wise, Karen Xie, Mike Christie
On Thu, Aug 11, 2011 at 02:04:56PM +0000, James Bottomley wrote:
> On Thu, 2011-08-11 at 06:47 -0400, Neil Horman wrote:
> > I recently submitted this:
> > http://marc.info/?l=linux-scsi&m=131228153521094&w=2
> >
> > Patch to fix an oops in the cxgb3i iscsi driver. I did what I thought was some
> > minor cleanup after testing and prior to submission. Of course that bit me, and
> > and a result I introduced some build warnings that really don't need to be
> > there. This patch corrects them. Apologies for the noise
>
> OK, so since the previous patch was a bug fix, can you resend the
> complete, clean bug fix with a stable tag.
>
> Thanks,
>
> James
>
Absolutely, sorry for the noise
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-11 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-11 10:47 [PATCH] libcxgbi: Fix some build warnings missed during cleanup of a previous patch Neil Horman
2011-08-11 14:04 ` James Bottomley
2011-08-11 14:45 ` Neil Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.