All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH 1/1] gcc-cross-intermediate: revise the 64bithack.patch for multilib case
Date: Mon, 15 Aug 2011 14:16:25 +0100	[thread overview]
Message-ID: <1313414185.14274.576.camel@rex> (raw)
In-Reply-To: <4E491589.3030000@linux.intel.com>

On Mon, 2011-08-15 at 20:48 +0800, Yu Ke wrote:
> On 2011/8/15 1:31, Koen Kooi wrote:
> >
> > Op 14 aug. 2011, om 15:32 heeft Yu Ke het volgende geschreven:
> >
> >> current gcc-cross-intermediate has build failure in qemux86-64 lib64
> >> multilib case. the reason is that it still use lib instead of lib64
> >> while do_install use the libdir i.e. lib64
> >>
> >> so this patch fix this issue by making gcc honour the libdir.
> >>
> >> CC: Kumar Gala<galak@kernel.crashing.org>
> >> CC: Richard Purdie<richard.purdie@linuxfoundation.org>
> >>
> >> Signed-off-by: Yu Ke<ke.yu@intel.com>
> >> ---
> >> meta/recipes-devtools/gcc/gcc-4.6.inc             |    2 +-
> >> meta/recipes-devtools/gcc/gcc-4.6/64bithack.patch |   16 +++++++++-------
> >
> > wouldn't gcc 4.5 need a similar change?
> 
> yes, gcc 4.5 should also has this change. I will sent out another patch 
> for this.

Please take a look at:

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/ml4&id=4de8e0e9c286ff64f1b7fd2e695fe2d62fdadfbd

I've updated the patch header and ensured that whichever compiler
options are used, the compiler works as expected and also applied this
to mips and pcc.

Could you also please open a bug about target gcc multilib as mentioned
in the patch header (targeted at post 1.1).

> just curious question, what is gcc 4.5 for, since gcc 4.6 is already there?

Some people are still using gcc 4.5 for various reasons. It is getting
to the point we should probably move that to meta-oe though?

Cheers,

Richard




  reply	other threads:[~2011-08-15 13:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-14 13:32 [PATCH 0/1] Bug fix for 1362 Yu Ke
2011-08-14 13:32 ` [PATCH 1/1] gcc-cross-intermediate: revise the 64bithack.patch for multilib case Yu Ke
2011-08-14 15:18   ` Khem Raj
2011-08-15 12:41     ` Yu Ke
2011-08-15 15:49       ` Khem Raj
2011-08-14 17:31   ` Koen Kooi
2011-08-15 12:48     ` Yu Ke
2011-08-15 13:16       ` Richard Purdie [this message]
2011-08-15 14:24         ` Yu Ke
2011-08-15 16:21           ` Richard Purdie
2011-08-16 22:50         ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313414185.14274.576.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.