All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
	Stephane Eranian <eranian@google.com>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 3/6] perf tools: Fix error handling of unknown events
Date: Tue, 16 Aug 2011 11:41:32 -0300	[thread overview]
Message-ID: <1313505695-20724-4-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1313505695-20724-1-git-send-email-acme@infradead.org>

From: Stephane Eranian <eranian@google.com>

There was a problem with the parse_events() code not printing the
correct event name when an event was unknown and starting with an 'r'.
The source of the problem was the way raw notation was parsed.

Without the patch:
	$ perf stat -e retired_foo
	invalid event modifier: 'tired_foo'

With the patch:
	$ perf stat -e retired_foo
	invalid or unsupported event: 'retired_foo'

This also covers the case where the name of the event was not printed at
all when perf was linked with libpfm4.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20110723021043.GA20178@quad
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/parse-events.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index d93f3ce..928918b 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -697,7 +697,11 @@ parse_raw_event(const char **strp, struct perf_event_attr *attr)
 		return EVT_FAILED;
 	n = hex2u64(str + 1, &config);
 	if (n > 0) {
-		*strp = str + n + 1;
+		const char *end = str + n + 1;
+		if (*end != '\0' && *end != ',' && *end != ':')
+			return EVT_FAILED;
+
+		*strp = end;
 		attr->type = PERF_TYPE_RAW;
 		attr->config = config;
 		return EVT_HANDLED;
-- 
1.6.2.5


  parent reply	other threads:[~2011-08-16 14:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16 14:41 [GIT PULL 0/6] perf/core fixes and improvements Arnaldo Carvalho de Melo
2011-08-16 14:41 ` [PATCH 1/6] perf list: Fix exit value Arnaldo Carvalho de Melo
2011-08-16 14:41 ` [PATCH 2/6] perf evlist: Fix missing event name init for default event (v2) Arnaldo Carvalho de Melo
2011-08-16 14:41 ` Arnaldo Carvalho de Melo [this message]
2011-08-16 14:41 ` [PATCH 4/6] perf annotate: Make output more readable Arnaldo Carvalho de Melo
2011-08-16 14:41 ` [PATCH 5/6] perf annotate: Add --symfs option Arnaldo Carvalho de Melo
2011-08-16 14:41 ` [PATCH 6/6] perf stat: Add -o and --append options Arnaldo Carvalho de Melo
2011-08-17 21:36 ` [GIT PULL 0/6] perf/core fixes and improvements Ingo Molnar
2011-08-18 12:43   ` Arnaldo Carvalho de Melo
2011-08-18 16:49 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
2011-08-18 16:50 ` [PATCH 3/6] perf tools: Fix error handling of unknown events Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313505695-20724-4-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.