All of lore.kernel.org
 help / color / mirror / Atom feed
From: tixy@yxit.co.uk (Tixy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Add safe diagnostic to indicate when __cpu_architecture isn't set up
Date: Tue, 16 Aug 2011 15:45:21 +0100	[thread overview]
Message-ID: <1313505921.2235.6.camel@computer2> (raw)
In-Reply-To: <1313504340-28004-1-git-send-email-dave.martin@linaro.org>

On Tue, 2011-08-16 at 15:19 +0100, Dave Martin wrote:
[...]
> This patch is useful for debugging, but I'm not convinced it should
> be merged.
[...] 
>  static inline int __pure cpu_architecture(void)
>  {
> -	BUG_ON(__cpu_architecture == CPU_ARCH_UNKNOWN);
> -	return __cpu_architecture;
> +	if (unlikely(__cpu_architecture == CPU_ARCH_UNKNOWN)) {
> +		extern int __pure __get_cpu_architecture(void);
> +
> +		WARN_ONCE(1, "__cpu_architecture not set yet!\n");
> +		return __get_cpu_architecture();
> +	} else
> +		return __cpu_architecture;
>  }

Seems to me that if we go down this route, cpu_architecture() may as
well remain a non-inline function which just calculates the arch if it's
not already set...

	if (unlikely(__cpu_architecture == CPU_ARCH_UNKNOWN))
		__cpu_architecture = __get_cpu_architecture();
	return __cpu_architecture;

There seems to be too many ways to skin this cat :-)

-- 
Tixy

  reply	other threads:[~2011-08-16 14:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16 14:19 [PATCH] ARM: Add safe diagnostic to indicate when __cpu_architecture isn't set up Dave Martin
2011-08-16 14:45 ` Tixy [this message]
2011-08-16 14:59   ` Nicolas Pitre
2011-08-16 16:15     ` Dave Martin
2011-08-16 16:22       ` Nicolas Pitre
2011-08-17 10:53         ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313505921.2235.6.camel@computer2 \
    --to=tixy@yxit.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.