All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitriy Paliy <dmitriy.paliy@nokia.com>
To: linux-bluetooth@vger.kernel.org
Cc: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Subject: [PATCH BlueZ v2] Fix remove temporary link key for No Bonding
Date: Mon, 22 Aug 2011 12:55:34 +0300	[thread overview]
Message-ID: <1314006934-4953-2-git-send-email-dmitriy.paliy@nokia.com> (raw)
In-Reply-To: <1314006934-4953-1-git-send-email-dmitriy.paliy@nokia.com>

This fixes regression caused by 33cdfcb0fabcfb5260953a13ae277b5abe9a322d.
Temporary link key should be removed after device is disconnected if
bonding information is not stored in file system.

Currently, the key is deleted only when paired device is removed, or
adapter is powered off. In case of No Bonding authentication, device is
not paired after disconnection, which results in link key left in memory.

On the other hand, device is not necessarily removed after disconnection
that also leaves unneeded temporary link key in memory.
---
 src/device.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/device.c b/src/device.c
index 9dd657c..f323bf8 100644
--- a/src/device.c
+++ b/src/device.c
@@ -855,8 +855,10 @@ void device_remove_connection(struct btd_device *device, DBusConnection *conn)
 		device->disconnects = g_slist_remove(device->disconnects, msg);
 	}
 
-	if (device_is_paired(device) && !device_is_bonded(device))
+	if (device_is_paired(device) && !device_is_bonded(device)) {
+		btd_adapter_remove_bonding(device->adapter, &device->bdaddr);
 		device_set_paired(device, FALSE);
+	}
 
 	emit_property_changed(conn, device->path,
 					DEVICE_INTERFACE, "Connected",
-- 
1.7.4.1


  reply	other threads:[~2011-08-22  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22  9:55 [PATCH BlueZ v2 0/1] Fix remove temporary link key for No Bonding Dmitriy Paliy
2011-08-22  9:55 ` Dmitriy Paliy [this message]
2011-08-22 12:04   ` [PATCH BlueZ v2] " Luiz Augusto von Dentz
2011-08-22 12:44     ` Dmitriy Paliy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314006934-4953-2-git-send-email-dmitriy.paliy@nokia.com \
    --to=dmitriy.paliy@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.