From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helmut Raiger Date: Mon, 22 Aug 2011 15:41:37 +0200 Subject: [U-Boot] [PATCH 2/2] mx3fb: move to CONFIG_VIDEO to support videomodes In-Reply-To: <1314020497-30897-1-git-send-email-helmut.raiger@hale.at> References: <1314020497-30897-1-git-send-email-helmut.raiger@hale.at> Message-ID: <1314020497-30897-3-git-send-email-helmut.raiger@hale.at> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de mx3fb.c was based on CONFIG_LCD and is moved by this patch to CONFIG_VIDEO, which has greater freedom in selecting videomodes even at runtime. This renders the accumulating list of display defines (CONFIG_DISPLAY_VBEST..., CONFIG_DISPLAY_C057...) obsolete as these may be setup through env variables: setenv mydisplay "video=ctfb:x:240,y:320,depth:16,mode:0,pclk:185925, le:9,ri:17,up:7,lo:10,hs:1,vs:1,sync:100663296,vmode:0" setenv videomode mydisplay Signed-off-by: Helmut Raiger --- drivers/video/Makefile | 2 +- drivers/video/cfb_console.c | 7 + drivers/video/mx3fb.c | 353 +++++++++++++++++++++++++------------------ 3 files changed, 213 insertions(+), 149 deletions(-) diff --git a/drivers/video/Makefile b/drivers/video/Makefile index 086dc05..2c0e500 100644 --- a/drivers/video/Makefile +++ b/drivers/video/Makefile @@ -34,7 +34,7 @@ COBJS-$(CONFIG_VIDEO_AMBA) += amba.o COBJS-$(CONFIG_VIDEO_CT69000) += ct69000.o videomodes.o COBJS-$(CONFIG_VIDEO_MB862xx) += mb862xx.o videomodes.o COBJS-$(CONFIG_VIDEO_MB86R0xGDC) += mb86r0xgdc.o videomodes.o -COBJS-$(CONFIG_VIDEO_MX3) += mx3fb.o +COBJS-$(CONFIG_VIDEO_MX3) += mx3fb.o videomodes.o COBJS-$(CONFIG_VIDEO_MX5) += mxc_ipuv3_fb.o ipu_common.o ipu_disp.o COBJS-$(CONFIG_VIDEO_SED13806) += sed13806.o COBJS-$(CONFIG_SED156X) += sed156x.o diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c index 3a93b64..4e653b8 100644 --- a/drivers/video/cfb_console.c +++ b/drivers/video/cfb_console.c @@ -161,6 +161,13 @@ #endif /* + * Defines for the i.MX31 driver (mx3fb.c) + */ +#ifdef CONFIG_VIDEO_MX3 +#define VIDEO_FB_16BPP_WORD_SWAP +#endif + +/* * Include video_fb.h after definitions of VIDEO_HW_RECTFILL etc. */ #include diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c index 0c925a0..1808ec3 100644 --- a/drivers/video/mx3fb.c +++ b/drivers/video/mx3fb.c @@ -1,6 +1,8 @@ /* * Copyright (C) 2009 * Guennadi Liakhovetski, DENX Software Engineering, + * Copyright (C) 2011 + * HALE electronic GmbH, * * See file CREDITS for list of people who contributed to this * project. @@ -21,100 +23,19 @@ * MA 02111-1307 USA */ #include -#include -#include +#include +#include + #include +#include #include -DECLARE_GLOBAL_DATA_PTR; - -void *lcd_base; /* Start of framebuffer memory */ -void *lcd_console_address; /* Start of console buffer */ - -int lcd_line_length; -int lcd_color_fg; -int lcd_color_bg; - -short console_col; -short console_row; - -void lcd_initcolregs(void) -{ -} - -void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue) -{ -} - -void lcd_disable(void) -{ -} - -void lcd_panel_disable(void) -{ -} +#include "videomodes.h" -#define msleep(a) udelay(a * 1000) - -#if defined(CONFIG_DISPLAY_VBEST_VGG322403) -#define XRES 320 -#define YRES 240 -#define PANEL_TYPE IPU_PANEL_TFT -#define PIXEL_CLK 156000 -#define PIXEL_FMT IPU_PIX_FMT_RGB666 -#define H_START_WIDTH 20 /* left_margin */ -#define H_SYNC_WIDTH 30 /* hsync_len */ -#define H_END_WIDTH (38 + 30) /* right_margin + hsync_len */ -#define V_START_WIDTH 7 /* upper_margin */ -#define V_SYNC_WIDTH 3 /* vsync_len */ -#define V_END_WIDTH (26 + 3) /* lower_margin + vsync_len */ -#define SIG_POL (DI_D3_DRDY_SHARP_POL | DI_D3_CLK_POL) -#define IF_CONF 0 -#define IF_CLK_DIV 0x175 -#elif defined(CONFIG_DISPLAY_COM57H5M10XRC) -#define XRES 640 -#define YRES 480 -#define PANEL_TYPE IPU_PANEL_TFT -#define PIXEL_CLK 40000 -#define PIXEL_FMT IPU_PIX_FMT_RGB666 -#define H_START_WIDTH 120 /* left_margin */ -#define H_SYNC_WIDTH 30 /* hsync_len */ -#define H_END_WIDTH (10 + 30) /* right_margin + hsync_len */ -#define V_START_WIDTH 35 /* upper_margin */ -#define V_SYNC_WIDTH 3 /* vsync_len */ -#define V_END_WIDTH (7 + 3) /* lower_margin + vsync_len */ -#define SIG_POL (DI_D3_DRDY_SHARP_POL | DI_D3_CLK_POL) -#define IF_CONF 0 -#define IF_CLK_DIV 0x55 -#else -#define XRES 240 -#define YRES 320 -#define PANEL_TYPE IPU_PANEL_TFT -#define PIXEL_CLK 185925 -#define PIXEL_FMT IPU_PIX_FMT_RGB666 -#define H_START_WIDTH 9 /* left_margin */ -#define H_SYNC_WIDTH 1 /* hsync_len */ -#define H_END_WIDTH (16 + 1) /* right_margin + hsync_len */ -#define V_START_WIDTH 7 /* upper_margin */ -#define V_SYNC_WIDTH 1 /* vsync_len */ -#define V_END_WIDTH (9 + 1) /* lower_margin + vsync_len */ -#define SIG_POL (DI_D3_DRDY_SHARP_POL | DI_D3_CLK_POL) +/* this might need panel specific set-up as-well */ #define IF_CONF 0 -#define IF_CLK_DIV 0x175 -#endif -#define LCD_COLOR_IPU LCD_COLOR16 - -static ushort colormap[256]; - -vidinfo_t panel_info = { - .vl_col = XRES, - .vl_row = YRES, - .vl_bpix = LCD_COLOR_IPU, - .cmap = colormap, -}; - -#define BIT_PER_PIXEL NBITS(LCD_COLOR_IPU) +/* -------------- controller specific stuff -------------- */ /* IPU DMA Controller channel definitions. */ enum ipu_channel { @@ -438,6 +359,14 @@ union chan_param_mem { struct chan_param_mem_interleaved ip; }; +DECLARE_GLOBAL_DATA_PTR; + +/* graphics setup */ +static GraphicDevice panel; +static struct ctfb_res_modes *mode; +static struct ctfb_res_modes var_mode; + + static inline u32 reg_read(unsigned long reg) { return __REG(reg); @@ -452,28 +381,39 @@ static inline void reg_write(u32 value, unsigned long reg) * sdc_init_panel() - initialize a synchronous LCD panel. * @width: width of panel in pixels. * @height: height of panel in pixels. - * @pixel_fmt: pixel format of buffer as FOURCC ASCII code. * @return: 0 on success or negative error code on failure. */ -static int sdc_init_panel(u16 width, u16 height, enum pixel_fmt pixel_fmt) +static int sdc_init_panel(u16 width, u16 height, + enum pixel_fmt di_setup, enum ipu_panel di_panel) { - u32 reg; + u32 reg, div; uint32_t old_conf; + debug("%s(width=%d, height=%d)\n", __func__, width, height); + /* Init panel size and blanking periods */ - reg = ((H_SYNC_WIDTH - 1) << 26) | - ((u32)(width + H_START_WIDTH + H_END_WIDTH - 1) << 16); + reg = width + mode->left_margin + mode->right_margin - 1; + if (reg > 1023) { + debug("display width too large, coerced to 1023!"); + reg = 1023; + } + reg = ((mode->hsync_len - 1) << 26) | (reg << 16); reg_write(reg, SDC_HOR_CONF); - reg = ((V_SYNC_WIDTH - 1) << 26) | SDC_V_SYNC_WIDTH_L | - ((u32)(height + V_START_WIDTH + V_END_WIDTH - 1) << 16); + reg = height + mode->upper_margin + mode->lower_margin - 1; + if (reg > 1023) { + debug("display height too large, coerced to 1023!"); + reg = 1023; + } + reg = ((mode->vsync_len - 1) << 26) | SDC_V_SYNC_WIDTH_L | (reg << 16); reg_write(reg, SDC_VER_CONF); - switch (PANEL_TYPE) { + switch (di_panel) { case IPU_PANEL_SHARP_TFT: reg_write(0x00FD0102L, SDC_SHARP_CONF_1); reg_write(0x00F500F4L, SDC_SHARP_CONF_2); reg_write(SDC_COM_SHARP | SDC_COM_TFT_COLOR, SDC_COM_CONF); + /* TODO: probably IF_CONF must be adapted (see below)! */ break; case IPU_PANEL_TFT: reg_write(SDC_COM_TFT_COLOR, SDC_COM_CONF); @@ -484,43 +424,62 @@ static int sdc_init_panel(u16 width, u16 height, enum pixel_fmt pixel_fmt) /* Init clocking */ - /* - * Calculate divider: fractional part is 4 bits so simply multiple by - * 2^4 to get fractional part, as long as we stay under ~250MHz and on - * i.MX31 it (HSP_CLK) is <= 178MHz. Currently 128.267MHz + /* Calculate divider: the IPU receives its clock from the hsp divder */ + /* fractional part is 4 bits so simply multiple by 2^4 to get it + * but make sure we avoid overflows, pixclock is given in pico seconds + * 16*1024*128*476837 = 0.9999996682e12 */ + div = ((mxc_get_clock(MXC_IPU_CLK)/1024)*(mode->pixclock/128))/476837; + debug("hsp_clk is %d, div=%d\n", mxc_get_clock(MXC_IPU_CLK), div); + /* coerce to not less than 4.0, not more than 255.9375 */ + if (div < 0x40) + div = 0x40; + else if (div > 0xFFF) + div = 0xFFF; + /* DISP3_IF_CLK_DOWN_WR is half the divider value and 2 less + * fraction bits. Subtract 1 extra from DISP3_IF_CLK_DOWN_WR + * based on timing debug DISP3_IF_CLK_UP_WR is 0 + */ + reg_write((((div / 8) - 1) << 22) | div, DI_DISP3_TIME_CONF); - reg_write((((IF_CLK_DIV / 8) - 1) << 22) | - IF_CLK_DIV, DI_DISP3_TIME_CONF); - - /* DI settings */ + /* DI settings for display 3: clock idle (bit 26) during vsync */ old_conf = reg_read(DI_DISP_IF_CONF) & 0x78FFFFFF; reg_write(old_conf | IF_CONF, DI_DISP_IF_CONF); + /* only set display 3 polarity bits */ old_conf = reg_read(DI_DISP_SIG_POL) & 0xE0FFFFFF; - reg_write(old_conf | SIG_POL, DI_DISP_SIG_POL); + reg_write(old_conf | mode->sync, DI_DISP_SIG_POL); - reg_write(fmt_cfg[pixel_fmt].b0, DI_DISP3_B0_MAP); - reg_write(fmt_cfg[pixel_fmt].b1, DI_DISP3_B1_MAP); - reg_write(fmt_cfg[pixel_fmt].b2, DI_DISP3_B2_MAP); + reg_write(fmt_cfg[di_setup].b0, DI_DISP3_B0_MAP); + reg_write(fmt_cfg[di_setup].b1, DI_DISP3_B1_MAP); + reg_write(fmt_cfg[di_setup].b2, DI_DISP3_B2_MAP); reg_write(reg_read(DI_DISP_ACC_CC) | - ((fmt_cfg[pixel_fmt].acc - 1) << 12), DI_DISP_ACC_CC); + ((fmt_cfg[di_setup].acc - 1) << 12), DI_DISP_ACC_CC); + + debug("DI_DISP_IF_CONF = 0x%08X\n", reg_read(DI_DISP_IF_CONF)); + debug("DI_DISP_SIG_POL = 0x%08X\n", reg_read(DI_DISP_SIG_POL)); + debug("DI_DISP3_TIME_CONF = 0x%08X\n", reg_read(DI_DISP3_TIME_CONF)); + debug("SDC_HOR_CONF = 0x%08X\n", reg_read(SDC_HOR_CONF)); + debug("SDC_VER_CONF = 0x%08X\n", reg_read(SDC_VER_CONF)); return 0; } static void ipu_ch_param_set_size(union chan_param_mem *params, - uint32_t pixel_fmt, uint16_t width, + uint pixelfmt, uint16_t width, uint16_t height, uint16_t stride) { + debug("%s(pixelfmt=%d, width=%d, height=%d, stride=%d)\n", + __func__, pixelfmt, width, height, stride); + params->pp.fw = width - 1; params->pp.fh_l = height - 1; params->pp.fh_h = (height - 1) >> 8; params->pp.sl = stride - 1; /* See above, for further formats see the Linux driver */ - switch (pixel_fmt) { - case IPU_PIX_FMT_RGB565: + switch (pixelfmt) { + case GDF_16BIT_565RGB: params->ip.bpp = 2; params->ip.pfs = 4; params->ip.npb = 7; @@ -533,7 +492,7 @@ static void ipu_ch_param_set_size(union chan_param_mem *params, params->ip.wid1 = 5; /* Green bit width - 1 */ params->ip.wid2 = 4; /* Blue bit width - 1 */ break; - case IPU_PIX_FMT_RGB24: + case GDF_32BIT_X888RGB: params->ip.bpp = 1; /* 24 BPP & RGB PFS */ params->ip.pfs = 4; params->ip.npb = 7; @@ -547,6 +506,7 @@ static void ipu_ch_param_set_size(union chan_param_mem *params, params->ip.wid2 = 7; /* Blue bit width - 1 */ break; default: + printf("pixel format not supported!\n"); break; } @@ -574,16 +534,6 @@ static void ipu_write_param_mem(uint32_t addr, uint32_t *data, } } -static uint32_t bpp_to_pixfmt(int bpp) -{ - switch (bpp) { - case 16: - return IPU_PIX_FMT_RGB565; - default: - return 0; - } -} - static uint32_t dma_param_addr(enum ipu_channel channel) { /* Channel Parameter Memory */ @@ -596,11 +546,13 @@ static void ipu_init_channel_buffer(enum ipu_channel channel, void *fbmem) uint32_t reg; uint32_t stride_bytes; - stride_bytes = (XRES * ((BIT_PER_PIXEL + 7) / 8) + 3) & ~3; + stride_bytes = (panel.plnSizeX * panel.gdfBytesPP + 3) & ~3; + + debug("%s(channel=%d, fbmem=0x%x)\n", __func__, channel, fbmem); /* Build parameter memory data for DMA channel */ - ipu_ch_param_set_size(¶ms, bpp_to_pixfmt(BIT_PER_PIXEL), - XRES, YRES, stride_bytes); + ipu_ch_param_set_size(¶ms, panel.gdfIndex, + panel.plnSizeX, panel.plnSizeY, stride_bytes); ipu_ch_param_set_buffer(¶ms, fbmem, NULL); params.pp.bam = 0; /* Some channels (rotation) have restriction on burst length */ @@ -715,31 +667,33 @@ static void sdc_enable_channel(void *fbmem) * interrupts. Next sdc_set_brightness() is going to be called * from mx3fb_blank(). */ - msleep(2); + udelay(2000); } /* * mx3fb_set_par() - set framebuffer parameters and change the operating mode. * @return: 0 on success or negative error code on failure. + * TODO: currently only 666 and TFT as DI setup supported */ static int mx3fb_set_par(void) { int ret; - ret = sdc_init_panel(XRES, YRES, PIXEL_FMT); + ret = sdc_init_panel(panel.plnSizeX, panel.plnSizeY, + IPU_PIX_FMT_RGB666, IPU_PANEL_TFT); if (ret < 0) return ret; - reg_write((H_START_WIDTH << 16) | V_START_WIDTH, SDC_BG_POS); + reg_write((mode->left_margin << 16) | mode->upper_margin, SDC_BG_POS); return 0; } -/* References in this function refer to respective Linux kernel sources */ -void lcd_enable(void) +static void ll_disp3_enable(void *base) { u32 reg; + debug("%s(base=0x%x)\n", __func__, (u32) base); /* pcm037.c::mxc_board_init() */ /* Display Interface #3 */ @@ -823,35 +777,138 @@ void lcd_enable(void) mx3fb_set_par(); - sdc_enable_channel(lcd_base); + sdc_enable_channel(base); /* * Linux driver calls sdc_set_brightness() here again, * once is enough for us */ + debug("%s() done\n", __func__); } -void lcd_ctrl_init(void *lcdbase) +/* ------------------------ public part ------------------- */ +ulong calc_fbsize(void) { - u32 mem_len = XRES * YRES * BIT_PER_PIXEL / 8; - /* - * We rely on lcdbase being a physical address, i.e., either MMU off, - * or 1-to-1 mapping. Might want to add some virt2phys here. - */ - if (!lcdbase) - return; - - memset(lcdbase, 0, mem_len); + return panel.plnSizeX * panel.plnSizeY * panel.gdfBytesPP; } -ulong calc_fbsize(void) +/* + * The current implementation is only tested for GDF_16BIT_565RGB! + * It was switched from the original CONFIG_LCD setup to CONFIG_VIDEO, + * because the lcd code seemed loaded with color table stuff, that + * does not relate to most modern TFTs. cfb_console.c looks more + * straight forward. + * This is the environment setting for the original setup + "unknown=video=ctfb:x:240,y:320,depth:16,mode:0,pclk:185925,le:9,ri:17, + up:7,lo:10,hs:1,vs:1,sync:100663296,vmode:0" + "videomode=unknown" +*/ +void *video_hw_init(void) { - return ((panel_info.vl_col * panel_info.vl_row * - NBITS(panel_info.vl_bpix)) / 8) + PAGE_SIZE; + char *penv; + u32 memsize; + unsigned long t1, hsynch, vsynch; + int bits_per_pixel, i, tmp, vesa_idx = 0, videomode; + + tmp = 0; + + videomode = CONFIG_SYS_DEFAULT_VIDEO_MODE; + /* get video mode via environment */ + penv = getenv("videomode"); + if (penv) { + /* decide if it is a string */ + if (penv[0] <= '9') { + videomode = (int) simple_strtoul(penv, NULL, 16); + tmp = 1; + } + } else { + tmp = 1; + } + if (tmp) { + /* parameter are vesa modes */ + /* search params */ + for (i = 0; i < VESA_MODES_COUNT; i++) { + if (vesa_modes[i].vesanr == videomode) + break; + } + if (i == VESA_MODES_COUNT) { + printf("no VESA Mode found, switching to mode 0x%x ", + CONFIG_SYS_DEFAULT_VIDEO_MODE); + i = 0; + } + mode = (struct ctfb_res_modes *) + &res_mode_init[vesa_modes[i].resindex]; + bits_per_pixel = vesa_modes[i].bits_per_pixel; + vesa_idx = vesa_modes[i].resindex; + } else { + mode = (struct ctfb_res_modes *) &var_mode; + bits_per_pixel = video_get_params(mode, penv); + } + + /* calculate hsynch and vsynch freq (info only) */ + t1 = (mode->left_margin + mode->xres + + mode->right_margin + mode->hsync_len) / 8; + t1 *= 8; + t1 *= mode->pixclock; + t1 /= 1000; + hsynch = 1000000000L / t1; + t1 *= (mode->upper_margin + mode->yres + + mode->lower_margin + mode->vsync_len); + t1 /= 1000; + vsynch = 1000000000L / t1; + + /* fill in Graphic device struct */ + sprintf(panel.modeIdent, "%dx%dx%d %ldkHz %ldHz", + mode->xres, mode->yres, + bits_per_pixel, (hsynch / 1000), (vsynch / 1000)); + printf("%s\n", panel.modeIdent); + panel.winSizeX = mode->xres; + panel.winSizeY = mode->yres; + panel.plnSizeX = mode->xres; + panel.plnSizeY = mode->yres; + + switch (bits_per_pixel) { + case 24: + panel.gdfBytesPP = 4; + panel.gdfIndex = GDF_32BIT_X888RGB; + break; + case 16: + panel.gdfBytesPP = 2; + panel.gdfIndex = GDF_16BIT_565RGB; + break; + default: + panel.gdfBytesPP = 1; + panel.gdfIndex = GDF__8BIT_INDEX; + break; + } + + /* set up Hardware */ + memsize = calc_fbsize(); + + debug("%s() allocating %d bytes\n", __func__, memsize); + + /* fill in missing Graphic device struct */ + panel.frameAdrs = (u32) malloc(memsize); + if (panel.frameAdrs == 0) { + printf("%s() malloc(%d) failed\n", __func__, memsize); + return 0; + } + panel.memSize = memsize; + + ll_disp3_enable((void *) panel.frameAdrs); + memset((void *) panel.frameAdrs, 0, memsize); + + debug("%s() done, framebuffer at 0x%x, size=%d cleared\n", + __func__, panel.frameAdrs, memsize); + + return (void *) &panel; } -int overwrite_console(void) +void video_set_lut(unsigned int index, /* color number */ + unsigned char r, /* red */ + unsigned char g, /* green */ + unsigned char b /* blue */ + ) { - /* Keep stdout / stderr on serial, our LCD is for splashscreen only */ - return 1; + return; } -- 1.7.4.4 -- Scanned by MailScanner.