From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756268Ab1HXBfh (ORCPT ); Tue, 23 Aug 2011 21:35:37 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:57462 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753515Ab1HXBfI (ORCPT ); Tue, 23 Aug 2011 21:35:08 -0400 From: Nitin Gupta To: Greg KH Cc: Jerome Marchand , Pekka Enberg , Robert Jennings , Linux Driver Project , linux-kernel Subject: [PATCH 4/4] Set initial disksize to some default value Date: Wed, 24 Aug 2011 08:34:50 +0700 Message-Id: <1314149690-3177-5-git-send-email-ngupta@vflare.org> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1314149690-3177-1-git-send-email-ngupta@vflare.org> References: <1314149690-3177-1-git-send-email-ngupta@vflare.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, we set initial disksize as 0, which forces user to write some value to corresponding zram device's sysfs node, before the device can be used. Now, we avoid this step by providing some default size initially. To change the disksize, user must: - Reset disk. Ex: echo 1 > /sys/block/zram0/reset (NOTE: disksize is set to the default value after reset) - Set new disksize. Ex: echo $((256*1024*1024)) > /sys/block/zram0/disksize Signed-off-by: Nitin Gupta --- drivers/staging/zram/zram_drv.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index d7fb207..2489f07 100644 --- a/drivers/staging/zram/zram_drv.c +++ b/drivers/staging/zram/zram_drv.c @@ -599,7 +599,7 @@ void zram_reset_device(struct zram *zram) /* Reset stats */ memset(&zram->stats, 0, sizeof(zram->stats)); - zram->disksize = 0; + zram_set_disksize(zram, zram_default_disksize_bytes()); mutex_unlock(&zram->init_lock); } @@ -716,8 +716,12 @@ static int create_device(struct zram *zram, int device_id) zram->disk->private_data = zram; snprintf(zram->disk->disk_name, 16, "zram%d", device_id); - /* Actual capacity set using syfs (/sys/block/zram/disksize */ - zram_set_disksize(zram, 0); + /* + * Set some default disksize. To set another disksize, user + * must reset the device and then write a new disksize to + * corresponding device's sysfs node. + */ + zram_set_disksize(zram, zram_default_disksize_bytes()); /* * To ensure that we always get PAGE_SIZE aligned -- 1.7.6