All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: greg@kroah.com
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>
Subject: [PATCH 3/9] staging:iio:trigger:sysfs trigger: Add a release function to avoid warning on module removal.
Date: Wed, 24 Aug 2011 17:28:35 +0100	[thread overview]
Message-ID: <1314203321-21926-4-git-send-email-jic23@cam.ac.uk> (raw)
In-Reply-To: <1314203321-21926-1-git-send-email-jic23@cam.ac.uk>

The device is static and should never actually be deleted. The release
is just to avoid a warning from the kernel.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
---
 drivers/staging/iio/trigger/iio-trig-sysfs.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/iio/trigger/iio-trig-sysfs.c b/drivers/staging/iio/trigger/iio-trig-sysfs.c
index 346b30c..174dc65 100644
--- a/drivers/staging/iio/trigger/iio-trig-sysfs.c
+++ b/drivers/staging/iio/trigger/iio-trig-sysfs.c
@@ -77,9 +77,16 @@ static const struct attribute_group *iio_sysfs_trig_groups[] = {
 	NULL
 };
 
+
+/* Nothing to actually do upon release */
+static void iio_trigger_sysfs_release(struct device *dev)
+{
+}
+
 static struct device iio_sysfs_trig_dev = {
 	.bus = &iio_bus_type,
 	.groups = iio_sysfs_trig_groups,
+	.release = &iio_trigger_sysfs_release,
 };
 
 static ssize_t iio_sysfs_trigger_poll(struct device *dev,
-- 
1.7.3.4


  parent reply	other threads:[~2011-08-24 16:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 16:28 [PATCH 0/9] Trigger locking rework and splitting up trigger.h Jonathan Cameron
2011-08-24 16:28 ` [PATCH 1/9] staging:iio:triggers. Add a reference get to the core for triggers Jonathan Cameron
2011-08-24 16:28 ` [PATCH 2/9] staging:iio:triggers reorder module put and device put to ensure that the ops are still there if put results in device deletion Jonathan Cameron
2011-08-24 16:28 ` Jonathan Cameron [this message]
2011-08-24 16:28 ` [PATCH 4/9] staging:iio:pollfunc: Make explicit that private data is always pointer to a struct iio_dev Jonathan Cameron
2011-08-24 16:28 ` [PATCH 5/9] staging:iio: prevent removal of module connected to trigger Jonathan Cameron
2011-08-24 16:28 ` [PATCH 6/9] staging:iio:rename trigger_consumer.h to indicate it is core only Jonathan Cameron
2011-08-24 16:28 ` [PATCH 7/9] staging:iio: spit trigger.h into provider and consumer parts Jonathan Cameron
2011-08-24 16:28 ` [PATCH 8/9] staging:iio:trigger core. Trivial code cleanups Jonathan Cameron
2011-08-24 16:28 ` [PATCH 9/9] staging:iio:trigger push functions that don't need to be generaly available down into the core Jonathan Cameron
2011-08-24 21:24 ` [PATCH 0/9] Trigger locking rework and splitting up trigger.h Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314203321-21926-4-git-send-email-jic23@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=greg@kroah.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.