From: Philippe Gerum <rpm@xenomai.org>
To: realmz6 <realmz6@domain.hid>
Cc: xenomai@xenomai.org, adeos-main@gna.org, uclinux-dist-devel@domain.hid
Subject: Re: [Xenomai-help] [Adeos-main] gpio irq always set to level sensitive with Xenomai on Blackfin
Date: Tue, 30 Aug 2011 12:07:21 +0200 [thread overview]
Message-ID: <1314698841.22036.2.camel@domain.hid> (raw)
In-Reply-To: <CAMk6uB=6aJmndwmU14zu3S9QBH=tFy0xrub7kznUyZBqsTTdiQ@mail.gmail.com>
On Tue, 2011-08-30 at 16:40 +0800, realmz6 wrote:
> Hi Guys,
>
> in adeos patch bfin_set_irq_handler(), this will set irq handle to
> handle_level_irq even it is a edge gpio irq, is it true?
>
> #ifdef CONFIG_IPIPE
> - _set_irq_handler(irq, handle_level_irq);
> -#else
> - struct irq_desc *desc = irq_desc + irq;
> + handle = __fixup_irq_handler(desc, handle_level_irq, 0);
> +#endif
>
> should it like the follows, it just fixup original handle and will not
> always set it to handle_level_irq.
No, this code is correct Adeos-wise. See there for an explanation, and a
pending fix for a related issue:
https://mail.gna.org/public/xenomai-help/2011-08/msg00081.html
>
> #ifdef CONFIG_IPIPE
> - _set_irq_handler(irq, handle_level_irq);
> -#else
> - struct irq_desc *desc = irq_desc + irq;
> + handle = __fixup_irq_handler(desc, handle, 0);
> +#endif
>
> -steven
>
> _______________________________________________
> Adeos-main mailing list
> Adeos-main@domain.hid
> https://mail.gna.org/listinfo/adeos-main
--
Philippe.
next prev parent reply other threads:[~2011-08-30 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 8:40 [Xenomai-help] gpio irq always set to level sensitive with Xenomai on Blackfin realmz6
2011-08-30 10:07 ` Philippe Gerum [this message]
2011-08-30 10:59 ` [Xenomai-help] [Adeos-main] " realmz6
2011-09-01 1:38 ` realmz6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314698841.22036.2.camel@domain.hid \
--to=rpm@xenomai.org \
--cc=adeos-main@gna.org \
--cc=realmz6@domain.hid \
--cc=uclinux-dist-devel@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.