All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Correct call to eth_write_hwaddr()
Date: Tue, 30 Aug 2011 08:51:00 -0700	[thread overview]
Message-ID: <1314719460-27858-1-git-send-email-sjg@chromium.org> (raw)

This fixes "Warning: failed to set MAC address" on platforms which rely on
an 'ethaddr' environment variable to set the MAC address.

This bug was introduced by this commit:

7616e785 Add Ethernet hardware MAC address framework to usbnet

Signed-off-by: Simon Glass <sjg@chromium.org>
---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/eth.c b/net/eth.c
index a34fe59..2caaf60 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
 			if (strchr(dev->name, ' '))
 				puts("\nWarning: eth device name has a space!\n");
 
-			if (eth_write_hwaddr(dev, NULL, eth_number))
+			if (eth_write_hwaddr(dev, "eth", eth_number))
 				puts("Warning: failed to set MAC address\n");
 
 			eth_number++;
-- 
1.7.3.1

             reply	other threads:[~2011-08-30 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 15:51 Simon Glass [this message]
2011-08-30 16:12 ` [U-Boot] [PATCH] Correct call to eth_write_hwaddr() Kumar Gala
2011-08-31 10:45   ` Michal Simek
2011-09-02  7:03 ` Heiko Schocher
2011-09-05 14:06 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314719460-27858-1-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.