From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755700Ab1H3QNm (ORCPT ); Tue, 30 Aug 2011 12:13:42 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:41616 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755641Ab1H3QNk (ORCPT ); Tue, 30 Aug 2011 12:13:40 -0400 Subject: Re: [PATCH 06/24] netfilter: Remove unnecessary OOM logging messages From: Joe Perches To: Patrick McHardy Cc: Bart De Schuymer , Wensong Zhang , Simon Horman , Julian Anastasov , Stephen Hemminger , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org In-Reply-To: <4E5CDBAA.6040001@trash.net> References: <13c1c12486cae409dfa5254b1435e660f2b17e05.1314650069.git.joe@perches.com> <4E5CDBAA.6040001@trash.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 30 Aug 2011 09:13:38 -0700 Message-ID: <1314720818.14422.1.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-08-30 at 14:46 +0200, Patrick McHardy wrote: > On 29.08.2011 23:17, Joe Perches wrote: > > Removing unnecessary messages saves code and text. > > Site specific OOM messages are duplications of a generic MM > > out of memory message and aren't really useful, so just > > delete them. > Looks good to me. Do you want me to apply this patch or are you > intending to have the entire series go through Dave? It doesn't matter to me one way or another. If you pick this one up, when I redo these to separate vmalloc from the the other alloc cases, I'll won't send netfilter again. cheers, Joe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches In-Reply-To: <4E5CDBAA.6040001@trash.net> References: <13c1c12486cae409dfa5254b1435e660f2b17e05.1314650069.git.joe@perches.com> <4E5CDBAA.6040001@trash.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 30 Aug 2011 09:13:38 -0700 Message-ID: <1314720818.14422.1.camel@Joe-Laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH 06/24] netfilter: Remove unnecessary OOM logging messages List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Patrick McHardy Cc: Wensong Zhang , netfilter@vger.kernel.org, coreteam@netfilter.org, Simon Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, James Morris , linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org, Julian Anastasov , Bart De Schuymer , netfilter-devel@vger.kernel.org, Alexey Kuznetsov , "David S. Miller" On Tue, 2011-08-30 at 14:46 +0200, Patrick McHardy wrote: > On 29.08.2011 23:17, Joe Perches wrote: > > Removing unnecessary messages saves code and text. > > Site specific OOM messages are duplications of a generic MM > > out of memory message and aren't really useful, so just > > delete them. > Looks good to me. Do you want me to apply this patch or are you > intending to have the entire series go through Dave? It doesn't matter to me one way or another. If you pick this one up, when I redo these to separate vmalloc from the the other alloc cases, I'll won't send netfilter again. cheers, Joe