From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: mythripk@ti.com
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 02/10] OMAP4: DSS: HDMI: Move pll and video configuration
Date: Thu, 01 Sep 2011 11:27:45 +0300 [thread overview]
Message-ID: <1314865665.2169.7.camel@lappyti> (raw)
In-Reply-To: <1314598500-24005-3-git-send-email-mythripk@ti.com>
On Mon, 2011-08-29 at 11:44 +0530, mythripk@ti.com wrote:
> From: Mythri P K <mythripk@ti.com>
>
> As the pll and the video configuration info are part of the ip_data those
> structures are moved to the ip_data strtucure.Also the functions are modified
> accordingly to take care of this movement.
structure typoed, and use a space after period.
> Signed-off-by: Mythri P K <mythripk@ti.com>
> ---
> drivers/video/omap2/dss/hdmi.c | 34 +++++++++++++++-------------------
> drivers/video/omap2/dss/hdmi.h | 18 ++++++++++--------
> 2 files changed, 25 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
> index 544f93e..084a47e 100644
> --- a/drivers/video/omap2/dss/hdmi.c
> +++ b/drivers/video/omap2/dss/hdmi.c
> @@ -59,7 +59,6 @@ static struct {
> u8 edid[HDMI_EDID_MAX_LENGTH];
> u8 edid_set;
> bool custom_set;
> - struct hdmi_config cfg;
>
> struct clk *sys_clk;
> } hdmi;
> @@ -230,11 +229,11 @@ int hdmi_init_display(struct omap_dss_device *dssdev)
> }
>
> static int hdmi_pll_init(struct hdmi_ip_data *ip_data,
> - enum hdmi_clk_refsel refsel, int dcofreq,
> - struct hdmi_pll_info *fmt, u16 sd)
> + enum hdmi_clk_refsel refsel)
> {
> u32 r;
> void __iomem *pll_base = hdmi_pll_base(ip_data);
> + struct hdmi_pll_info *fmt = &ip_data->pll_data;
>
> /* PLL start always use manual mode */
> REG_FLD_MOD(pll_base, PLLCTRL_PLL_CONTROL, 0x0, 0, 0);
> @@ -251,9 +250,9 @@ static int hdmi_pll_init(struct hdmi_ip_data *ip_data,
> r = FLD_MOD(r, 0x1, 13, 13); /* PLL_REFEN */
> r = FLD_MOD(r, 0x0, 14, 14); /* PHY_CLKINEN de-assert during locking */
>
> - if (dcofreq) {
> + if (fmt->dcofreq) {
> /* divider programming for frequency beyond 1000Mhz */
> - REG_FLD_MOD(pll_base, PLLCTRL_CFG3, sd, 17, 10);
> + REG_FLD_MOD(pll_base, PLLCTRL_CFG3, fmt->regsd, 17, 10);
> r = FLD_MOD(r, 0x4, 3, 1); /* 1000MHz and 2000MHz */
> } else {
> r = FLD_MOD(r, 0x2, 3, 1); /* 500MHz and 1000MHz */
> @@ -379,8 +378,7 @@ static int hdmi_phy_init(struct hdmi_ip_data *ip_data)
> return 0;
> }
>
> -static int hdmi_pll_program(struct hdmi_ip_data *ip_data,
> - struct hdmi_pll_info *fmt)
> +static int hdmi_pll_program(struct hdmi_ip_data *ip_data)
> {
> u16 r = 0;
> enum hdmi_clk_refsel refsel;
> @@ -399,7 +397,7 @@ static int hdmi_pll_program(struct hdmi_ip_data *ip_data,
>
> refsel = HDMI_REFSEL_SYSCLK;
>
> - r = hdmi_pll_init(ip_data, refsel, fmt->dcofreq, fmt, fmt->regsd);
> + r = hdmi_pll_init(ip_data, refsel);
I don't think I quite understood why refsel is not part of the pll info.
And if it has to be hardcoded, you could as well do that in
hdmi_pll_init().
Tomi
next prev parent reply other threads:[~2011-09-01 8:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 6:14 [PATCH v2 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent mythripk
2011-08-29 6:14 ` [PATCH v2 01/10] OMAP4: DSS: HDMI: HDMI clean up to pass base_address mythripk
2011-08-29 6:14 ` [PATCH v2 02/10] OMAP4: DSS: HDMI: Move pll and video configuration mythripk
2011-08-29 6:14 ` [PATCH v2 03/10] OMAP4: DSS: HDMI: Use specific HDMI timings structure mythripk
2011-08-29 6:14 ` [PATCH v2 04/10] OMAP4: DSS: HDMI: Move the common header file mythripk
2011-08-29 6:14 ` [PATCH v2 05/10] OMAP4 : DSS : HDMI : Move the EDID portion from HDMI mythripk
2011-08-29 6:14 ` [PATCH v2 06/10] OMAP4: DSS2: HDMI: Split the HDMI driver to DSS and IP mythripk
2011-08-29 6:14 ` [PATCH v2 07/10] OMAP4: DSS2: HDMI: Provide a wrapper API to configure mythripk
2011-08-29 6:14 ` [PATCH v2 08/10] OMAP4: DSS2: HDMI: Function pointer approach to call mythripk
2011-08-29 6:14 ` [PATCH v2 09/10] MAP4: DSS: HDMI: Rename the functions in HDMI IP mythripk
2011-08-29 6:15 ` [PATCH v2 10/10] OMAP4: DSS: Rename hdmi_omap4_panel.c to hdmi_panel.c mythripk
2011-09-01 8:55 ` [PATCH v2 08/10] OMAP4: DSS2: HDMI: Function pointer approach to call Tomi Valkeinen
2011-09-01 8:38 ` [PATCH v2 07/10] OMAP4: DSS2: HDMI: Provide a wrapper API to configure Tomi Valkeinen
2011-09-01 9:00 ` [PATCH v2 04/10] OMAP4: DSS: HDMI: Move the common header file Tomi Valkeinen
2011-09-02 5:15 ` K, Mythri P
2011-09-02 5:24 ` Tomi Valkeinen
2011-09-02 5:27 ` K, Mythri P
2011-09-01 8:14 ` [PATCH v2 03/10] OMAP4: DSS: HDMI: Use specific HDMI timings structure Tomi Valkeinen
2011-09-02 5:09 ` K, Mythri P
2011-09-01 8:27 ` Tomi Valkeinen [this message]
2011-09-02 5:11 ` [PATCH v2 02/10] OMAP4: DSS: HDMI: Move pll and video configuration K, Mythri P
2011-09-02 5:13 ` Tomi Valkeinen
2011-09-02 5:22 ` K, Mythri P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314865665.2169.7.camel@lappyti \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.