Re: [PATCH v2] linux-omap_2.6.39: remove patch that prevented board from resuming from suspend.

[Paul Menzel <paulepanter@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 2341 bytes --]

Dear Tasslehoff,


Am Mittwoch, den 31.08.2011, 19:41 +0200 schrieb Tasslehoff Kjappfot:
> From: Tasslehoff Kjappfot tasskjapp@gmail.com>
> 
> Running on a board similar to Beagleboard C3 (but without NAND) I could not resume from suspend with the patch.
> The console output when suspending was as expected, but neither console input nor a timer would wake the board.
> Without the patch, everything works as it should.
> 
> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>

Tasslehoff thank you for sending this iteration (no full stop at the end
of the summary please next time) and thank you Koen for pushing this
[1].

> ---

Next time, please add below the »---« what you changed in v2 or other
iterations.

>  recipes/linux/linux-omap_2.6.39.bb |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/linux/linux-omap_2.6.39.bb b/recipes/linux/linux-omap_2.6.39.bb
> index 8370e58..3880aa1 100644
> --- a/recipes/linux/linux-omap_2.6.39.bb
> +++ b/recipes/linux/linux-omap_2.6.39.bb
> @@ -27,7 +27,6 @@ SRC_URI_append = " \
>             file://sakoman/0010-Revert-omap2_mcspi-Flush-posted-writes.patch \
>             file://sakoman/0011-Revert-omap_hsmmc-improve-interrupt-synchronisation.patch \
>             file://sakoman/0012-Don-t-turn-SDIO-cards-off-to-save-power.-Doing-so-wi.patch \
> -           file://sakoman/0013-Enable-the-use-of-SDIO-card-interrupts.patch \
>             file://sakoman/0014-soc-codecs-Enable-audio-capture-by-default-for-twl40.patch \
>             file://sakoman/0015-soc-codecs-twl4030-Turn-on-mic-bias-by-default.patch \
>             file://sakoman/0016-RTC-add-support-for-backup-battery-recharge.patch \

Koen, do you know why that patch breaks resume? I guess when applying
those you had tested suspend and resume and it worked for you. Maybe we
should contact the patch author [2]?

Additionally should the patch file be removed from the tree too as no
other recipe is using it?


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=8deb9697d85388af845e1dda193d9149f55b07f5
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/linux/linux-omap-2.6.39/sakoman/0013-Enable-the-use-of-SDIO-card-interrupts.patch?id=8deb9697d85388af845e1dda193d9149f55b07f5

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]