From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: Kernel bug from 3.0 (was phy disks and vifs timing
	out in DomU)
Date: Thu, 1 Sep 2011 16:43:05 +0100
Message-ID: <1314891785.28989.133.camel@zakaz.uk.xensource.com>
References: <4E4E3957.1040007@overnetdata.com>
	<20110819125615.GA26558@dumpdata.com>
	<4E56B132.9050708@overnetdata.com>
	<20110826142606.GA25511@dumpdata.com>
	<20110826144438.GA24836@dumpdata.com>
	<4E5E6843.7050206@citrix.com> <20110831170711.GB13642@dumpdata.com>
	<1314862972.28989.74.camel@zakaz.uk.xensource.com>
	<20110901142356.GD23971@dumpdata.com> <4E5FA0C4.7000806@citrix.com>
	<20110901153704.GB7506@dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20110901153704.GB7506@dumpdata.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Fitzhardinge <jeremy@goop.org>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Anthony Wright <anthony@overnetdata.com>, "Jeremy@acsinet12.oracle.com" <Jeremy@acsinet12.oracle.com>, David Vrabel <david.vrabel@citrix.com>, Todd Deshane <todd.deshane@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2011-09-01 at 16:37 +0100, Konrad Rzeszutek Wilk wrote:
> > >>     vmalloc: remove vmalloc_sync_all() from alloc_vm_area()
> > >>     
> > >>     There's no need for it: it will get faulted into the current pagetable
> > >>     as needed.
> > >>     
> > >>     Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> > >>
> > >> The flaw in the reasoning here is that you cannot take a kernel fault
> > >> while processing a hypercall, so hypercall arguments must have been
> > >> faulted in beforehand and that is what the sync_all was for.
> > >>
> > >> It's probably fair to say that the Xen specific caller should take care
> > >> of that Xen-specific requirement rather than pushing it into common
> > >> code. On the other hand Xen is the only user and creating a Xen specific
> > >> helper/wrapper seems a bit pointless.
> > > 
> > > Perhaps then doing the vmalloc_sync_all() (or are more precise one:
> > > vmalloc_sync_one) should be employed in the netback code then?
> > > 
> > > And obviously guarded by the CONFIG_HIGHMEM case?
> > 
> > Perhaps. But I think the correct thing to do initially is revert the
> > change and then look at possible improvements.  Particularly as the fix
> > needs to be a backported to stable.
> 
> I disagree. Ian pointed out properly that this a Xen requirment - and there
> is no reason for us to slow down non-Xen runs with vmalloc_sync_all plucked in
> a generic path.

There is literally no other caller of alloc_vm_area than xen so you
won't be slowing anyone else down.

Maybe we should add alloc_vm_area_sync and use that everywhere?

Ian.