From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Kernel bug from 3.0 (was phy disks and vifs timing out in DomU) Date: Thu, 1 Sep 2011 20:19:37 +0100 Message-ID: <1314904777.19389.25.camel@dagon.hellion.org.uk> References: <4E4E3957.1040007@overnetdata.com> <20110819125615.GA26558@dumpdata.com> <4E56B132.9050708@overnetdata.com> <20110826142606.GA25511@dumpdata.com> <20110826144438.GA24836@dumpdata.com> <4E5E6843.7050206@citrix.com> <20110831170711.GB13642@dumpdata.com> <1314862972.28989.74.camel@zakaz.uk.xensource.com> <20110901142356.GD23971@dumpdata.com> <1314889953.28989.130.camel@zakaz.uk.xensource.com> <20110901153823.GC7506@dumpdata.com> <1314891894.28989.135.camel@zakaz.uk.xensource.com> <4E5FC20A.2080009@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4E5FC20A.2080009@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: "xen-devel@lists.xensource.com" , Anthony Wright , Konrad Rzeszutek Wilk , David Vrabel , Todd, Deshane List-Id: xen-devel@lists.xenproject.org On Thu, 2011-09-01 at 18:34 +0100, Jeremy Fitzhardinge wrote: > On 09/01/2011 08:44 AM, Ian Campbell wrote: > > > > blkback, xenbus_client and the grant table stuff all use it as well and > > AFAICT have the same requirement for syncing. > > > > $ git grep alloc_vm_area > > arch/x86/include/asm/xen/grant_table.h:#define xen_alloc_vm_area(size) alloc_vm_area(size) > > > > -- this macro is unused... > > > > arch/x86/xen/grant-table.c: xen_alloc_vm_area(PAGE_SIZE * max_nr_gframes); > > drivers/block/xen-blkback/xenbus.c: blkif->blk_ring_area = alloc_vm_area(PAGE_SIZE); > > drivers/net/xen-netback/netback.c: vif->tx_comms_area = alloc_vm_area(PAGE_SIZE); > > drivers/net/xen-netback/netback.c: vif->rx_comms_area = alloc_vm_area(PAGE_SIZE); > > drivers/xen/xenbus/xenbus_client.c: area = xen_alloc_vm_area(PAGE_SIZE); > > Well, 3/5ths unused. Hmm, yes, no sure how I missed that.