All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Carolyn Wyborny <carolyn.wyborny@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [RFC, 1/2] ethtool:  Implement private flags interface for ethtool application.
Date: Fri, 02 Sep 2011 22:27:11 +0100	[thread overview]
Message-ID: <1314998831.3419.12.camel@bwh-desktop> (raw)
In-Reply-To: <1314996631-4773-1-git-send-email-carolyn.wyborny@intel.com>

On Fri, 2011-09-02 at 13:50 -0700, Carolyn Wyborny wrote:
> This patch completes the user space implementation of the private
> flags inteface in ethtool. Using -b/-B options.
[...]

Private flags are supposed to be named (string set ETH_SS_PRIV_FLAGS).
ethtool should only support getting and setting flags by name, not
number.  That way people can actually remember what the flags do and
their scripts won't break when the driver changes flag numbers.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  parent reply	other threads:[~2011-09-02 21:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-02 20:50 [RFC, 1/2] ethtool: Implement private flags interface for ethtool application Carolyn Wyborny
2011-09-02 20:50 ` [RFC, 2/2] igb: Implementation of ethtool priv_flags for igb driver Carolyn Wyborny
2011-09-02 21:31   ` Ben Hutchings
2011-09-02 20:55 ` [RFC, 1/2] ethtool: Implement private flags interface for ethtool application David Miller
2011-09-02 21:11   ` Wyborny, Carolyn
2011-09-02 21:17     ` Michał Mirosław
2011-09-02 21:22       ` Michał Mirosław
2011-09-02 21:29         ` Wyborny, Carolyn
2011-09-02 21:34         ` Ben Hutchings
2011-09-02 21:35           ` Wyborny, Carolyn
2011-09-03  1:39           ` Michał Mirosław
2011-09-02 21:23   ` Ben Hutchings
2011-09-02 21:27 ` Ben Hutchings [this message]
2011-09-02 21:33   ` Wyborny, Carolyn
2011-09-02 21:36     ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314998831.3419.12.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=carolyn.wyborny@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.