From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932136Ab1IHDNI (ORCPT ); Wed, 7 Sep 2011 23:13:08 -0400 Received: from nm5-vm0.bullet.mail.ird.yahoo.com ([77.238.189.207]:25968 "HELO nm5-vm0.bullet.mail.ird.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757952Ab1IHDNG convert rfc822-to-8bit (ORCPT ); Wed, 7 Sep 2011 23:13:06 -0400 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 727445.27741.bm@omp1016.mail.ird.yahoo.com X-YMail-OSG: StMR6_gVM1mXHs2zbtUjOWhBjECGK31awAYFArR8eCjTU8V jOHf8OuM6n7rjWT5iKgLjArrjRJnj35Gb5Fn6Aj68FV1GeP1mVj64D5u9h7q JbyZ1QkcthNJ7ubQwultmBM4rhBdO2gC.qNkdbJTbd319tqpoOq10FSZb2CN QSM.1PXF56x1p1N9rI6.q1aojerjZmpqMLRRvAAkeLdCZWEjxm3Bf97yRSBU 74NTqbwceH8wY7O7rP.64qKLVo_lKbHeRGsGsQZJLLSuLJHVlKpPlkK_5hSz TkGCRYR6MmTAdZ5DT1xwS8mW5FxmTZaGQHlnDdieuK0uH7q_jpBF3hcHStZm SVSEIAfCvnpNga6IwBRr6aNNOpULkurrrpI5kjjfPWF32kVhtMjO10L_6cNL 9DBr0kaQH_0bxi_gO2MIN X-RocketYMMF: hintak_leung X-Mailer: YahooMailClassic/14.0.5 YahooMailWebService/0.8.113.315625 Message-ID: <1315451581.92826.YahooMailClassic@web29509.mail.ird.yahoo.com> Date: Thu, 8 Sep 2011 04:13:01 +0100 (BST) From: Hin-Tak Leung Reply-To: htl10@users.sourceforge.net Subject: Re: Kernel 3.1.0-rc4 oops when connecting iPod To: Pavel Ivanov , Seth Forshee Cc: linux-fsdevel@vger.kernel.org, linux-kernel , Christoph Hellwig In-Reply-To: <20110907175952.GC23829@thinkpad-t410> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --- On Wed, 7/9/11, Seth Forshee wrote: > Yes, that was definitely just an oversight. Has anyone > provided a patch > yet? If not I've pasted a patch below. Seems like a fix > should be > applied ASAP. > > > From d27825b880028e9a45ba640d86c9e8101db0606b Mon Sep 17 > 00:00:00 2001 > From: Seth Forshee > Date: Wed, 7 Sep 2011 10:38:35 -0700 > Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in > hfsplus_fill_super() error path > > Commit 6596528 (hfsplus: ensure bio requests are not > smaller than > the hardware sectors) changed the pointers used for volume > header > allocations but failed to change the pointer freed in the > error > path of hfsplus_fill_super(). This patch fixes the > problem. > > Reported-by: Pavel Ivanov > Signed-off-by: Seth Forshee > Cc: Acked-by: Hin-Tak Leung Please go ahead and submit the patch. > --- > fs/hfsplus/super.c |    4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c > index c106ca2..cadbb8c 100644 > --- a/fs/hfsplus/super.c > +++ b/fs/hfsplus/super.c > @@ -525,8 +525,8 @@ out_close_cat_tree: > out_close_ext_tree: >     hfs_btree_close(sbi->ext_tree); > out_free_vhdr: > -    kfree(sbi->s_vhdr); > -    kfree(sbi->s_backup_vhdr); > +    kfree(sbi->s_vhdr_buf); > +    kfree(sbi->s_backup_vhdr_buf); > out_unload_nls: >     unload_nls(sbi->nls); >     unload_nls(nls); > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hin-Tak Leung Subject: Re: Kernel 3.1.0-rc4 oops when connecting iPod Date: Thu, 8 Sep 2011 04:13:01 +0100 (BST) Message-ID: <1315451581.92826.YahooMailClassic@web29509.mail.ird.yahoo.com> References: <20110907175952.GC23829@thinkpad-t410> Reply-To: htl10@users.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel , Christoph Hellwig To: Pavel Ivanov , Seth Forshee Return-path: Received: from nm2-vm0.bullet.mail.ird.yahoo.com ([77.238.189.199]:33968 "HELO nm2-vm0.bullet.mail.ird.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757898Ab1IHDNF convert rfc822-to-8bit (ORCPT ); Wed, 7 Sep 2011 23:13:05 -0400 In-Reply-To: <20110907175952.GC23829@thinkpad-t410> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --- On Wed, 7/9/11, Seth Forshee wrote: > Yes, that was definitely just an oversight. Has anyone > provided a patch > yet? If not I've pasted a patch below. Seems like a fix > should be > applied ASAP. >=20 >=20 > From d27825b880028e9a45ba640d86c9e8101db0606b Mon Sep 17 > 00:00:00 2001 > From: Seth Forshee > Date: Wed, 7 Sep 2011 10:38:35 -0700 > Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in > hfsplus_fill_super() error path >=20 > Commit 6596528 (hfsplus: ensure bio requests are not > smaller than > the hardware sectors) changed the pointers used for volume > header > allocations but failed to change the pointer freed in the > error > path of hfsplus_fill_super(). This patch fixes the > problem. >=20 > Reported-by: Pavel Ivanov > Signed-off-by: Seth Forshee > Cc: Acked-by: Hin-Tak Leung Please go ahead and submit the patch. > --- > fs/hfsplus/super.c |=A0 =A0 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c > index c106ca2..cadbb8c 100644 > --- a/fs/hfsplus/super.c > +++ b/fs/hfsplus/super.c > @@ -525,8 +525,8 @@ out_close_cat_tree: > out_close_ext_tree: > =A0=A0=A0 hfs_btree_close(sbi->ext_tree); > out_free_vhdr: > -=A0=A0=A0 kfree(sbi->s_vhdr); > -=A0=A0=A0 kfree(sbi->s_backup_vhdr); > +=A0=A0=A0 kfree(sbi->s_vhdr_buf); > +=A0=A0=A0 kfree(sbi->s_backup_vhdr_buf); > out_unload_nls: > =A0=A0=A0 unload_nls(sbi->nls); > =A0=A0=A0 unload_nls(nls); > --=20 > 1.7.4.1 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe > linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at=A0 http://vger.kernel.org/majordomo-info.html >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html