Re: [PATCH] acer-wmi: support Acer Aspire/eMachines 4739z

[joeyli <jlee@suse.com>]

於 四，2011-09-08 於 14:38 +0800，AceLan Kao 提到：
> Hi,
> 
> 2011/9/8 joeyli <jlee@suse.com>:
> > 於 四，2011-09-08 於 10:30 +0800，AceLan Kao 提到：
> >> Hi,
> >>
> >> 2011/9/7 joeyli <jlee@suse.com>:
> >> > 於 三，2011-09-07 於 15:32 +0800，AceLan Kao 提到：
> >> >> There are 2 kind of 4739Z, the one that vendor name is ACER sents out
> >> >> the correct brightness key events, so we use the
> >> >
> >> > Current brightness key events means the Fn key direct send out key code
> >> > but not from wmi notify event?
> >> Currently, most of the machines send out the correctly brightness key
> >> code from EC,
> >> so we don't have to handle them. The video ACPI will capture the
> >> events and adjust
> >> the brightness.
> >> Acer Aspire 4739Z sends out the correct brightness key code as other
> >> machines do.
> >> Acer eMachines 4739Z doesn't sends out correct key codes, it sends out
> >> meaningless
> >> key codes, so we have to capture the brightness event from WMI and remapping to
> >
> > What's the number of meaningless key codes? Maybe we should remap it in
> > udev but not in acer-wmi driver.
> brightness up is -
> brightness down is -
> 
> The reason why we shouldn't remap the keys in udev is that when it
> comes to follow the
> Acer WMI spec., the BIOS engineer won't care about which key code will
> be submitted
> while the brightness key be pressed. So, the key codes might change if
> there is a BIOS
> upgrade.
> 

That's bad and not make sense they emit the same key code and wmi event
code on two brightness control keys.

> >
> >> the correct key code and raise the correct key events to ACPI.
> >>
> >
> > Transfer wmi notify event to key event is fine, but keep and maintain
> > the current brightness level in acer-wmi is not a good idea, because
> > BIOS also maintain a BRTL flag in DSDT.
> > If there have other userland application touch brightness level through
> > _BCM, then will have risk causes the value out of sync.
> Yes, that's a problem.
> I don't have any idea to overcome it right now.
> 

Could you please check with BIOS team for What's the implementation on
Windows 7?
Which component on Windows take care the brightness control job?

> >> We can choose any value we like other than, 0x62, 0x63, since we don't care what
> >> key codes are reported, I just need a mapping entry here, so that
> >
> > But, why you enable 0x61? It not related to brightness control, which
> > machine use it?
> It's for video toggle, both Aspire and eMachines 4739Z need that key event.
> 

OK!

> >
> > Like I said, keep current brightness acer-wmi is not good idea and have
> > risk to conflict with acpi video driver if there have other userland
> > application change brightness level through _BCM.
> You are right, it's better to reconsider the implementation.
> 
> >
> >> >
> >> >>  static int mailled = -1;
> >> >>  static int brightness = -1;
> >> >> @@ -310,6 +324,10 @@ static struct quirk_entry quirk_lenovo_ideapad_s205 = {
> >> >>       .wireless = 3,
> >> >>  };
> >> >>
> >> >> +static struct quirk_entry quirk_acer_aspire_4739z= {
> >> >> +     .brightness = 2,
> >> >> +};
> >> >> +
> >> >>  /* The Aspire One has a dummy ACPI-WMI interface - disable it */
> >> >>  static struct dmi_system_id __devinitdata acer_blacklist[] = {
> >> >>       {
> >> >> @@ -368,6 +386,24 @@ static struct dmi_system_id acer_quirks[] = {
> >> >>       },
> >> >>       {
> >> >>               .callback = dmi_matched,
> >> >> +             .ident = "Acer Aspire 4739Z",
> >> >> +             .matches = {
> >> >> +                     DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> >> >> +                     DMI_MATCH(DMI_PRODUCT_NAME, "AS4739Z"),
> >> >> +             },
> >> >> +             .driver_data = &quirk_acer_travelmate_2490,
> >> >> +     },
> >> >
> >> > Why "Acer Aspire 4739Z" set to quirk the same with travelmate 2490?
> >> > There only have a mailled capability flag in this quirk, why you used
> >> > it?
> >> > Does that because Aspire 4739Z also have mail hotkey button?
> >> >
> >> > If the answer is NO, then don't need add a new quirk.
> >> Sorry, I missunderstanding it, there is no mailled on it, I'll remove it.
> >>
> >
> > I read your new patch, please direct remove whole Acer Aspire 4739Z
> > quirk block. Do you have any good reason to add the quirk block?
> Acer Aspire 4739Z needs the video toggling function and the key event
> is {KE_KEY, 0x61, {KEY_SWITCHVIDEOMODE} },
> that's why we need it's quirk here.
> 

The keymap was setup when driver deteced wmi event guid, the quirk block
doesn't have anything related to wmi event keymap setup. Please remove
the quirk block then test again.

> >> >>
> >> >>       switch (return_value.function) {
> >> >>       case WMID_HOTKEY_EVENT:
> >> >> +     case WMID_HOTKEY_BREAK_EVENT:
> >
> > Why add BREAK EVENT here? for which key?
> > Does it possible causes other machine run the same function key twice?
> For video toggling,
> {KE_KEY, 0x61, {KEY_SWITCHVIDEOMODE} },
> 
> And yes, you are right, that might lead to the problem that switch the
> output twice.
> I'll add one more check for this key.
> 
> >
> >> >>               device_state = return_value.device_state;
> >> >>               pr_debug("device state: 0x%x\n", device_state);
> >> >>
> >> >> @@ -1558,6 +1596,29 @@ static void acer_wmi_notify(u32 value, void *context)
> >> >>                                                  1, true);
> >> >>               }
> >> >>               break;
> >> >> +     case WMID_BRIGHTNESS_CHANGE_EVENT:
> >> >> +             // to avoid the brightness event be handled twice
> >> >> +             if( quirks->brightness != 2)
> >> >> +                     break;
> >> >> +             brightness_return_value = *((struct brightness_event_return_value *)&return_value);
> >> >> +             /* brightness is decreasing */
> >> >> +             if( cur_brightness > brightness_return_value.brightness_level1)
> >> >> +                     key = sparse_keymap_entry_from_scancode(acer_wmi_input_dev, 0x63);
> >> >> +             /* brightness is increasing */
> >> >> +             else if( cur_brightness < brightness_return_value.brightness_level1)
> >> >> +                     key = sparse_keymap_entry_from_scancode(acer_wmi_input_dev, 0x62);
> >> >> +             /* brightness is already at the bottom */
> >> >> +             else if( cur_brightness == 0)
> >> >> +                     key = sparse_keymap_entry_from_scancode(acer_wmi_input_dev, 0x63);
> >> >> +             /* brightness is already at the top */
> >> >> +             else if( cur_brightness == 9)
> >> >> +                     key = sparse_keymap_entry_from_scancode(acer_wmi_input_dev, 0x62);
> >> >> +
> >> >> +             sparse_keymap_report_entry(acer_wmi_input_dev, key, 1, true);
> >> >> +             cur_brightness= return_value.key_num;
> >> >> +             break;
> >> >
> >> > The same,
> >> > why should you control the brightness level number in acer-wmi driver?
> >> > Does it not control by acpi video driver and _BCL/_BCM in DSDT?
> >> >
> >> > And, why choice 0x62, 0x63? The above 2 number is not from your wmi
> >> > notify result, why use them?
> >> The problem is that the BIOS/EC doesn't send out the correct brightness
> >> key events, the BIOS engineer just choose non-used values for those keys
> >> that are defined in Acer WMI spec. Because they think those key events
> >> should be captured from WMI, not from BIOS/EC.
> >> So that, we have to read the brightness change event from WMI key events.
> >> And then use the ACPI way to adjust the brightness.
> >>
> >
> > After reviewed your DSDT, I thought _Q8E and _Q8F are mapping to your
> > brightness up/down Fn key, please enable acpi debug message to confirm
> > it.
> >
> > And, in _Q8E/Q8F:
> >
> >    Method (_Q8E, 0, NotSerialized)             /* Brightness up ? */
> >    {
> >        If (CondRefOf (HBRT))
> >        {
> >            HBRT (0x03)
> >        }
> >
> >        If (IGDS)
> >        {
> >            If (And (0x04, DSEN))               /* when DSEn is 0x04 is 100 */
> >            {
> >                BRTN (0x86)                     /* ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86  */
> >            }
> >
> > The machine emit standard ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS event to
> > video device when IDGS is true and DSEN is 0x04.
> >
> > Please kindly check with BIOS team for what's the definition with IGDS
> > and DSEN, and why the DSEN should set to 100 (looks likes it need
> > disable automatically control the brightness level in BIOS).
> >
> > This is a good chance to ask BIOS team to know more useful information
> > to us.
> I'm sorry that the BIOS team won't change anything for us.
> Acer Aspire 4739Z is already an shipping product, and
> Acer eMachines 4739Z only change the BIOS bootup logo and vendor name
> (and maybe mixed up some key codes), so they won't change anything
> from BIOS to avoid inducing problems to the product.
> 

Please please check with BIOS team for:

What's the definition with IGDS and DSEN, and why the DSEN should set to
100 (looks likes it need disable automatically control the brightness
level in BIOS).

This is the only moment for ODM's BIOS team can response us, please help
to check with them for how the implementation on Windows platform. I
didn't say need BIOS team modify anything, but we need dig more things
for how can they implement 2 keys used 1 event on Windows platform.

> And the ACPI log I gave you a month ago is Acer Aspire 4739Z, so
> the key codes are correct.
> The eMachine I have now is broken, I'm trying to reinstall it and dump
> the eMachines' ACPI log to you later.
> 

Thank's!

> >
> > I don't want maintain brightness level in acer-wmi, we can transfer the
> > wmi event to key event, but maintain current brightness level is not
> > good and dirty.
> Agree, I need more time to work out other solution.
> Talk to you later.
> 

Please help to check with BIOS team and ODM for how did they implement
it on Windows platform, per current information from DSDT and BIOS team,
it's dirty and not make sense to maintain the current brightness value
outside ACPI space.


Thank's for your help! 
Joey Lee