From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: b35362@freescale.com, linux-mtd@lists.infradead.org,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH 00/10] nandwrite: cleanup, support ioctl(MEMWRITE)
Date: Sun, 11 Sep 2011 16:06:56 +0300 [thread overview]
Message-ID: <1315746420.18731.50.camel@sauron> (raw)
In-Reply-To: <1314820839-7107-1-git-send-email-computersforpeace@gmail.com>
On Wed, 2011-08-31 at 13:00 -0700, Brian Norris wrote:
> This patch series cleans up old features in nandwrite and supports new
> features with ioctl(MEMWRITE).
>
> Byproducts of this include:
> (1) kill --raw
> (2) re-implement --autoplace
> (3) support OOB writes for MLC NAND (only write once per page)
I do not have time to thoroughly review the patches, but they look good,
and you make a great job splitting making then easy to follow by
splitting nicely.
I am not very comfortable with "no warning" --raw removal, but we can
try it this way, I guess, it is unlikely someone will be hurt, but there
is some probability.
And last but not least, I think we should not push your changes to the
master branch of mtd-utils _befor_ the corresponding kernel-space
changes have reached Linuses tree (e.g., dwmw2 might dislike something).
So I pushed 2 patches which look independent to the master branch, and
the rest are in the 'brian' branch so far.
Thanks!
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-09-11 13:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 20:00 [PATCH 00/10] nandwrite: cleanup, support ioctl(MEMWRITE) Brian Norris
2011-08-31 20:00 ` [PATCH 01/10] nandwrite: trivial variable move Brian Norris
2011-09-11 13:00 ` Artem Bityutskiy
2011-08-31 20:00 ` [PATCH 02/10] mtd-utils: update mtd-abi.h Brian Norris
2011-09-09 17:11 ` [PATCH v2 " Brian Norris
2011-08-31 20:00 ` [PATCH 03/10] nandwrite: consolidate buffer usage Brian Norris
2011-09-11 13:07 ` Artem Bityutskiy
2011-09-14 5:15 ` Mike Frysinger
2011-09-14 18:22 ` Brian Norris
2011-09-18 2:53 ` Mike Frysinger
2011-09-19 18:50 ` Brian Norris
2011-08-31 20:00 ` [PATCH 04/10] libmtd: modify `mtd_write' to cover OOB writes Brian Norris
2011-08-31 20:00 ` [PATCH 05/10] libmtd: support MEMWRITE ioctl Brian Norris
2011-08-31 20:00 ` [PATCH 06/10] nandwrite: merge `mtd_write_oob' and `mtd_write' calls Brian Norris
2011-08-31 20:00 ` [PATCH 07/10] mtdutils: move OOB auto-layout into libmtd's mtd_write Brian Norris
2011-08-31 20:00 ` [PATCH 08/10] nandwrite: kill `--raw' option Brian Norris
2011-08-31 20:00 ` [PATCH 09/10] nandwrite: re-implement `--autoplace' option Brian Norris
2011-08-31 20:00 ` [PATCH 10/10] nandwrite: use common.h "errmsg" functions Brian Norris
2011-09-11 13:06 ` Artem Bityutskiy [this message]
2011-09-14 5:17 ` [PATCH 00/10] nandwrite: cleanup, support ioctl(MEMWRITE) Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315746420.18731.50.camel@sauron \
--to=dedekind1@gmail.com \
--cc=b35362@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.