From: Igor Mammedov <imammedo@redhat.com>
To: xen-devel@lists.xensource.com
Cc: keir.fraser@citrix.com, JBeulich@suse.com
Subject: [PATCH 1/2] xen: Clear IRQ_GUEST bit from irq_desc status if its action is NULL
Date: Tue, 13 Sep 2011 15:44:18 +0200 [thread overview]
Message-ID: <1315921459-17059-2-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1315921459-17059-1-git-send-email-imammedo@redhat.com>
On a system with Intel C600 series Patsburg SAS controller
if following commands are executed:
rmmod isci
modprobe isci
the host will crash in pirq_guest_bind in attempt to dereference
NULL 'action' pointer.
This is caused by isci driver which does not cleanup irq properly,
removing device first and then os tries to unbind its irqs afterwards.
c/s 20093 and 20844 fixed host crashes when removing isci module.
However in dynamic_irq_cleanup 'action' field of irq_desc is set to
NULL but IRQ_GUEST flag in 'status' field is not cleared. So on next
attempt to bind pirq (modprobe isci) in pirq_guest_bind with IRQ_GUEST
flag set, the branch
if ( !(desc->status & IRQ_GUEST) )
is skipped and host ends up with dereferencing NULL pointer 'action'.
__pirq_guest_unbind is the only place where IRQ_GUEST flag is cleared,
lets keep it this way. Besides it is not safe to clear IRQ_GUEST flag
in dynamic_irq_cleanup, because we can later hit
BUG_ON(!(desc->status & IRQ_GUEST));
in pirq_guest_unbind -> __pirq_guest_unbind
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Jan Beulich <JBeulich@suse.com>
diff -r 0312575dc35e -r 2049f7ca3177 xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c Thu Sep 08 15:13:06 2011 +0100
+++ b/xen/arch/x86/irq.c Tue Sep 13 14:44:59 2011 +0200
@@ -1472,6 +1472,7 @@ static irq_guest_action_t *__pirq_guest_
if ( unlikely(action == NULL) )
{
+ desc->status &= ~IRQ_GUEST;
dprintk(XENLOG_G_WARNING, "dom%d: pirq %d: desc->action is NULL!\n",
d->domain_id, pirq->pirq);
return NULL;
@@ -1599,6 +1600,7 @@ static int pirq_guest_force_unbind(struc
action = (irq_guest_action_t *)desc->action;
if ( unlikely(action == NULL) )
{
+ desc->status &= ~IRQ_GUEST;
dprintk(XENLOG_G_WARNING, "dom%d: pirq %d: desc->action is NULL!\n",
d->domain_id, pirq->pirq);
goto out;
next prev parent reply other threads:[~2011-09-13 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 13:44 [PATCH 0/2] Prevent host crash after executing in dom0 'rmmod isci; modprobe isci' Igor Mammedov
2011-09-13 13:44 ` Igor Mammedov [this message]
2011-09-13 13:44 ` [PATCH 1/2] xen: Clear IRQ_GUEST bit from irq_desc status if its action is NULL Igor Mammedov
2011-09-13 13:56 ` Igor Mammedov
2011-09-13 13:54 ` [PATCH 2/2] xen: remove duplicate code and keep IRQ_GUEST flag reset at one place Igor Mammedov
2011-09-16 9:13 ` [PATCH 0/2] Prevent host crash after executing in dom0 'rmmod isci; modprobe isci' Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315921459-17059-2-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=JBeulich@suse.com \
--cc=keir.fraser@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.