All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, dlaor@redhat.com,
	fujita.tomonori@lab.ntt.co.jp, owasserm@redhat.com,
	pbonzini@redhat.com, hch@lst.de
Subject: [Qemu-devel] [PATCH] Add iSCSI support for QEMU
Date: Wed, 21 Sep 2011 19:37:54 +1000	[thread overview]
Message-ID: <1316597875-30463-1-git-send-email-ronniesahlberg@gmail.com> (raw)



List,

Please find a patch that adds built-in iSCSI support to QEMU when built and linked against the multiplatform iscsi initiator library at  git://github.com/sahlberg/libiscsi.git


I have implemented all suggested changed from Stefans review, except
* Fail the build if qemu blocksize is not multiple of 512.
Maybe QEMU will never use such, but if it does I dont think a blockdriver that can not support such should fail the build. Hence it just refuses to use the driver at runtime instead.

* I did not implement a synchronous bdrv_flush since I understand that Stefans patch will be merged shortly since it is required for other backend drivers anyway.


In some situations, using a built-in iscsi inititator has benefits against mounting the LUNs on the host.

* Privacy: The iSCSI LUNs are private to the guest and are not visible either to the host, nor to any processes running on the host.
* Ease of managment : If you have very many guests and very many, thousands of, iSCSI LUNs. It is inconvenient to have to expose all LUNs to the underlying host.
* No root requirement. Since the iSCSI LUNs are not mounted as devices on the host, ordinary users can set up and use iSCSI resources without the need for root privilege on the host to map the devices to local scsi devices.
* Since the network I/O for the iSCSI LUN is now done by the QEMU process instead of the kernel, each VM's iSCSI I/O traffic can be insolated & controlled via the cgroups network contorller / tc network classifier.
* Portable across OS. Each OS has different tools for setting up iSCSI usage. A native driver lets QEMU users setup iSCSI in the same way regardless of the level of OS support for iSCSI.

Please merge this patch to master or explain how I should change the patch so that it becomes acceptable for inclusion into QEMU.


regards
ronnie sahlberg

             reply	other threads:[~2011-09-21  9:39 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21  9:37 Ronnie Sahlberg [this message]
2011-09-21  9:37 ` [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI Ronnie Sahlberg
2011-09-21  9:45   ` Paolo Bonzini
2011-09-21  9:52     ` ronnie sahlberg
2011-09-27 20:08       ` ronnie sahlberg
2011-09-28  5:54         ` Paolo Bonzini
2011-09-29  6:54   ` Stefan Hajnoczi
2011-10-09 20:46     ` ronnie sahlberg
2011-10-13  9:46       ` ronnie sahlberg
2011-10-13  9:48         ` Paolo Bonzini
2011-10-13  9:54         ` Stefan Hajnoczi
2011-10-13 10:01         ` Daniel P. Berrange
2011-10-13 10:55           ` Daniel P. Berrange
2011-10-13 10:52         ` Kevin Wolf
2011-10-24 13:33   ` Kevin Wolf
2011-10-25  8:04     ` ronnie sahlberg
2011-10-25  8:17       ` Kevin Wolf
2011-10-25  8:23         ` ronnie sahlberg
2011-10-25  8:46           ` Kevin Wolf
2011-10-28 10:46   ` Zhi Yong Wu
  -- strict thread matches above, loose matches on Subject: below --
2011-09-10  4:23 [Qemu-devel] [PATCH] Add iSCSI support for QEMU Ronnie Sahlberg
2011-09-12  8:56 ` Kevin Wolf
2011-09-14 12:24   ` Orit Wasserman
2011-09-14 14:33     ` Christoph Hellwig
2011-09-14 14:37     ` Christoph Hellwig
2011-09-14 15:35       ` Stefan Hajnoczi
2011-09-14 15:40         ` Christoph Hellwig
2011-09-14 15:51           ` Stefan Hajnoczi
2011-09-14 16:36             ` Orit Wasserman
2011-09-15  6:06               ` Paolo Bonzini
2011-09-15  9:52                 ` Orit Wasserman
2011-09-15  9:55                   ` Paolo Bonzini
2011-09-15 10:10                     ` Kevin Wolf
2011-09-17 19:08                 ` Laurent Vivier
2011-09-18  7:43                   ` Paolo Bonzini
2011-09-14 16:37             ` Paolo Bonzini
2011-09-14 22:46     ` ronnie sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316597875-30463-1-git-send-email-ronniesahlberg@gmail.com \
    --to=ronniesahlberg@gmail.com \
    --cc=dlaor@redhat.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.