From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv7 00/47] NXP DPAA2 PMD Date: Fri, 17 Feb 2017 14:40:44 +0100 Message-ID: <13170922.QrZ7cG92tU@xps13> References: <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com> <20170217121358.GA135568@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , Neil Horman , Hemant Agrawal , dev@dpdk.org, shreyansh.jain@nxp.com, john.mcnamara@intel.com, jerin.jacob@caviumnetworks.com To: Bruce Richardson Return-path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 0B1C8201 for ; Fri, 17 Feb 2017 14:40:47 +0100 (CET) Received: by mail-wr0-f173.google.com with SMTP id i10so30122216wrb.0 for ; Fri, 17 Feb 2017 05:40:47 -0800 (PST) In-Reply-To: <20170217121358.GA135568@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-02-17 12:13, Bruce Richardson: > On Fri, Feb 17, 2017 at 11:34:43AM +0000, Ferruh Yigit wrote: > > On 2/16/2017 1:27 PM, Bruce Richardson wrote: > > > On Thu, Feb 16, 2017 at 08:22:49AM -0500, Neil Horman wrote: > > >> On Thu, Feb 16, 2017 at 06:08:59AM +0530, Hemant Agrawal wrote: > > >>> Prerequisites: > > >>> - For running the PMD, NXP's SoC (board) and SDK (software/BSP) is required. > > >>> Information about obtaining relevant software is available in the docs > > >>> as part of the patch. > > >> > > >> NAK. The SDK requires registration to obtain, and appears to be non-open > > >> source. This driver is unmaintainable given that. > > >> > > > Hi Hemant, > > > > > > can you perhaps clarify things here. What is the requirement to: > > > * build the driver/DPDK for the platform > > > * run applications using DPDK on the platform > > > > > > Also what is the license/availability for those requirements. > > > > Hi Bruce, Hemant, Neil, Thomas, > > > > I did able to compile the driver without the SDK. It looks like that SDK > > is a runtime dependency. > > > > What is the DPDK requirement here? > > If it is not breaking the build, this PMD provides it. > > > If it builds without an SDK dependency I'd be happy enough to see this > merged into DPDK. Since I can't run it without the correct hardware, I > don't see needing the correct runtime software being a difficulty too. > So long as we can compile this, we can check for breakages in it due to > refactoring in other parts of DPDK, like we do for other drivers. As > with those other drivers, it's up to the maintainers/vendors to do the > functional checking for additional issues. Nobody is likely to have the > hardware to functionality test all drivers in DPDK anyway. +1, I agree with Bruce