All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: linux-bluetooth@vger.kernel.org
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Subject: [PATCH 2/2] AVRCP: fix case when only one setting is provided
Date: Wed, 28 Sep 2011 19:35:57 -0300	[thread overview]
Message-ID: <1317249357-1362-2-git-send-email-lucas.demarchi@profusion.mobi> (raw)
In-Reply-To: <1317249357-1362-1-git-send-email-lucas.demarchi@profusion.mobi>

If CT tries to change an Application Setting providing only one
setting, the size of the PDU will be 3 bytes. Therefore we should check
if the PDU is shorter than or equal 3, not only shorter.
---
 audio/avrcp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/avrcp.c b/audio/avrcp.c
index e7b0d1b..ac9a107 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -1021,7 +1021,7 @@ static uint8_t avrcp_handle_set_player_value(struct media_player *mp,
 	uint16_t len = ntohs(pdu->params_len);
 	unsigned int i;
 
-	if (len < 3)
+	if (len <= 3)
 		goto err;
 
 	len = 0;
-- 
1.7.6.4


  reply	other threads:[~2011-09-28 22:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 22:35 [PATCH 1/2] AVRCP: return empty string instead of rejecting Lucas De Marchi
2011-09-28 22:35 ` Lucas De Marchi [this message]
2011-09-30 14:55   ` [PATCH 2/2] AVRCP: fix case when only one setting is provided Luiz Augusto von Dentz
2011-09-30 14:54 ` [PATCH 1/2] AVRCP: return empty string instead of rejecting Luiz Augusto von Dentz
2011-10-03  8:54 ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317249357-1362-2-git-send-email-lucas.demarchi@profusion.mobi \
    --to=lucas.demarchi@profusion.mobi \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.