All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Franky Lin" <frankyl@broadcom.com>
To: gregkh@suse.de
Cc: devel@linuxdriverproject.org, linux-wireless@vger.kernel.org
Subject: [PATCH v3 22/25] staging: brcm80211: move rssi computation to place we need it
Date: Thu, 29 Sep 2011 15:34:33 -0700	[thread overview]
Message-ID: <1317335676-3424-23-git-send-email-frankyl@broadcom.com> (raw)
In-Reply-To: <1317335676-3424-1-git-send-email-frankyl@broadcom.com>

From: Arend van Spriel <arend@broadcom.com>

The rssi computation was done upon getting the frame from the
queue, but the value is needed when filling in the receive status
data for mac80211. The call to wlc_phy_rssi_compute() has been
deferred.

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
---
 drivers/staging/brcm80211/brcmsmac/main.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmsmac/main.c b/drivers/staging/brcm80211/brcmsmac/main.c
index 3e39407..bdc0611 100644
--- a/drivers/staging/brcm80211/brcmsmac/main.c
+++ b/drivers/staging/brcm80211/brcmsmac/main.c
@@ -828,11 +828,6 @@ brcms_b_recv(struct brcms_hardware *wlc_hw, uint fifo, bool bound)
 		rxh->RxTSFTime = le16_to_cpu(rxh_le->RxTSFTime);
 		rxh->RxChan = le16_to_cpu(rxh_le->RxChan);
 
-		/*
-		 * compute the RSSI from d11rxhdr and record it in wlc_rxd11hr
-		 */
-		wlc_rxhdr->rssi = (s8)wlc_phy_rssi_compute(wlc_hw->band->pi,
-							   rxh);
 		brcms_c_recv(wlc_hw->wlc, p);
 	}
 
@@ -8172,7 +8167,7 @@ prep_mac80211_status(struct brcms_c_info *wlc, struct d11rxhdr *rxh,
 		rx_status->freq = ieee80211_dsss_chan_to_freq(channel);
 	}
 
-	rx_status->signal = wlc_rxh->rssi;
+	rx_status->signal = wlc_phy_rssi_compute(wlc->hw->band->pi, rxh);
 
 	/* noise */
 	/* qual */
-- 
1.7.1



  parent reply	other threads:[~2011-09-29 22:34 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 17:45 [PATCH v2 00/26] staging: brcm80211: 8th reaction for mainline patch #2 Franky Lin
2011-09-27 17:45 ` [PATCH v2 01/26] staging: brcm80211: remove uncoditional code blocks from brcmsmac Franky Lin
2011-09-27 17:45 ` [PATCH v2 02/26] staging: brcm80211: removed unused argument from softmac functions Franky Lin
2011-09-27 17:45 ` [PATCH v2 03/26] staging: brcm80211: deleted unused array of bss configurations in softmac Franky Lin
2011-09-27 17:45 ` [PATCH v2 04/26] staging: brcm80211: removed redundant wlc->cfg struct member Franky Lin
2011-09-27 17:45 ` [PATCH v2 05/26] staging: brcm80211: removed global var from aiutils.c Franky Lin
2011-09-27 17:45 ` [PATCH v2 06/26] staging: brcm80211: removed global vars in softmac ucode handling Franky Lin
2011-09-27 17:45 ` [PATCH v2 07/26] staging: brcm80211: removed unused softmac workaround Franky Lin
2011-09-27 17:45 ` [PATCH v2 08/26] staging: brcm80211: remove ht_cap field from brcms_c_info structure Franky Lin
2011-09-27 17:45 ` [PATCH v2 09/26] staging: brcm80211: use fragment number provided in transmit frame Franky Lin
2011-09-27 17:45 ` [PATCH v2 10/26] staging: brcm80211: remove unused function si_pmu_ilp_clock() Franky Lin
2011-09-27 17:45 ` [PATCH v2 11/26] staging: brcm80211: make device initializer table for wme constant Franky Lin
2011-09-27 17:45 ` [PATCH v2 12/26] staging: brcm80211: remove dongle firmware related debug code Franky Lin
2011-09-27 17:45 ` [PATCH v2 13/26] staging: brcm80211: remove unnecessary mac80211 callbacks Franky Lin
2011-09-27 17:45 ` [PATCH v2 14/26] staging: brcm80211: removed band related global vars from softmac Franky Lin
2011-09-27 17:45 ` [PATCH v2 15/26] staging: brcm80211: removed global var global_scb " Franky Lin
2011-09-27 17:45 ` [PATCH v2 16/26] staging: brcm80211: various global var related changes in softmac Franky Lin
2011-09-27 17:45 ` [PATCH v2 17/26] staging: brcm80211: removed global variable in softmac otp Franky Lin
2011-09-27 17:45 ` [PATCH v2 18/26] staging: brcm80211: changing interface to n-phy rssi compute function Franky Lin
2011-09-27 17:45 ` [PATCH v2 19/26] staging: brcm80211: change interface for common " Franky Lin
2011-09-27 17:45 ` [PATCH v2 20/26] staging: brcm80211: convert endianess before handling the frame Franky Lin
2011-09-27 17:45 ` [PATCH v2 21/26] staging: brcm80211: use endian annotated structures in brcmsmac Franky Lin
2011-09-27 17:45 ` [PATCH v2 22/26] staging: brcm80211: move rssi computation to place we need it Franky Lin
2011-09-27 17:45 ` [PATCH v2 23/26] staging: brcm80211: use d11rxhdr structure in brcms_c_recover_tsf64() Franky Lin
2011-09-27 17:45 ` [PATCH v2 24/26] staging: brcm80211: declared global vars in softmac phy as const Franky Lin
2011-09-27 18:35   ` Larry Finger
2011-09-27 21:10     ` Arend van Spriel
2011-09-28  5:12       ` Larry Finger
2011-09-27 17:45 ` [PATCH v2 25/26] staging: brcm80211: simple changes to softmac phy variables Franky Lin
2011-09-27 17:45 ` [PATCH v2 26/26] staging: brcm80211: declared global vars in softmac phy as const Franky Lin
2011-09-29 22:34 ` [PATCH v3 00/25] staging: brcm80211: 8th reaction for mainline patch #2 Franky Lin
2011-09-29 22:34   ` [PATCH v3 01/25] staging: brcm80211: remove uncoditional code blocks from brcmsmac Franky Lin
2011-09-29 22:34   ` [PATCH v3 02/25] staging: brcm80211: removed unused argument from softmac functions Franky Lin
2011-09-29 22:34   ` [PATCH v3 03/25] staging: brcm80211: deleted unused array of bss configurations in softmac Franky Lin
2011-09-29 22:34   ` [PATCH v3 04/25] staging: brcm80211: removed redundant wlc->cfg struct member Franky Lin
2011-09-29 22:34   ` [PATCH v3 05/25] staging: brcm80211: removed global var from aiutils.c Franky Lin
2011-09-29 22:34   ` [PATCH v3 06/25] staging: brcm80211: removed global vars in softmac ucode handling Franky Lin
2011-09-29 22:34   ` [PATCH v3 07/25] staging: brcm80211: removed unused softmac workaround Franky Lin
2011-09-29 22:34   ` [PATCH v3 08/25] staging: brcm80211: remove ht_cap field from brcms_c_info structure Franky Lin
2011-09-29 22:34   ` [PATCH v3 09/25] staging: brcm80211: use fragment number provided in transmit frame Franky Lin
2011-09-29 22:34   ` [PATCH v3 10/25] staging: brcm80211: remove unused function si_pmu_ilp_clock() Franky Lin
2011-09-29 22:34   ` [PATCH v3 11/25] staging: brcm80211: make device initializer table for wme constant Franky Lin
2011-09-29 22:34   ` [PATCH v3 12/25] staging: brcm80211: remove dongle firmware related debug code Franky Lin
2011-09-29 22:34   ` [PATCH v3 13/25] staging: brcm80211: remove unnecessary mac80211 callbacks Franky Lin
2011-09-29 22:34   ` [PATCH v3 14/25] staging: brcm80211: removed band related global vars from softmac Franky Lin
2011-09-29 22:34   ` [PATCH v3 15/25] staging: brcm80211: removed global var global_scb " Franky Lin
2011-09-29 22:34   ` [PATCH v3 16/25] staging: brcm80211: various global var related changes in softmac Franky Lin
2011-09-29 22:34   ` [PATCH v3 17/25] staging: brcm80211: removed global variable in softmac otp Franky Lin
2011-09-29 22:34   ` [PATCH v3 18/25] staging: brcm80211: changing interface to n-phy rssi compute function Franky Lin
2011-09-29 22:34   ` [PATCH v3 19/25] staging: brcm80211: change interface for common " Franky Lin
2011-09-29 22:34   ` [PATCH v3 20/25] staging: brcm80211: convert endianess before handling the frame Franky Lin
2011-09-29 22:34   ` [PATCH v3 21/25] staging: brcm80211: use endian annotated structures in brcmsmac Franky Lin
2011-10-10 14:35     ` Rafał Miłecki
2011-09-29 22:34   ` Franky Lin [this message]
2011-09-29 22:34   ` [PATCH v3 23/25] staging: brcm80211: use d11rxhdr structure in brcms_c_recover_tsf64() Franky Lin
2011-09-29 22:34   ` [PATCH v3 24/25] staging: brcm80211: simple changes to softmac phy variables Franky Lin
2011-09-29 22:34   ` [PATCH v3 25/25] staging: brcm80211: declared global vars in softmac phy as const Franky Lin
2011-10-03 23:23   ` [PATCH v3 00/25] staging: brcm80211: 8th reaction for mainline patch #2 Greg KH
2011-10-03 23:33     ` Franky Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317335676-3424-23-git-send-email-frankyl@broadcom.com \
    --to=frankyl@broadcom.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.