All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MMC: PL180: Fix infinite loop with VExpress extended fifo implementation
Date: Wed, 05 Oct 2011 10:58:58 +0100	[thread overview]
Message-ID: <1317808738.3158.348.camel@hornet.cambridge.arm.com> (raw)
In-Reply-To: <1317808125.2207.9.camel@linaro1>

> That's useful to know. The PL180 code is also used for U8500, I don't
> know if that implements the peripheral ID register; though I guess any
> probing could be limited to vexpress anyway.

STE have the same "problems" with FIFO size, see drivers/mmc/host/mmci.c
in kernel sources:

static struct variant_data variant_arm = {
        .fifosize               = 16 * 4,
        .fifohalfsize           = 8 * 4,
        .datalength_bits        = 16, 
};      

static struct variant_data variant_arm_extended_fifo = {
        .fifosize               = 128 * 4,
        .fifohalfsize           = 64 * 4,
        .datalength_bits        = 16,
};      

static struct variant_data variant_u300 = {
        .fifosize               = 16 * 4, 
        .fifohalfsize           = 8 * 4,
        .clkreg_enable          = MCI_ST_U300_HWFCEN,
        .datalength_bits        = 16,
        .sdio                   = true,
};      

static struct variant_data variant_ux500 = {
        .fifosize               = 30 * 4,
        .fifohalfsize           = 8 * 4,
        .clkreg                 = MCI_CLK_ENABLE,
        .clkreg_enable          = MCI_ST_UX500_HWFCEN,
        .datalength_bits        = 24,
        .sdio                   = true,
        .st_clkdiv              = true,
};      

static struct variant_data variant_ux500v2 = {
        .fifosize               = 30 * 4,
        .fifohalfsize           = 8 * 4,
        .clkreg                 = MCI_CLK_ENABLE,
        .clkreg_enable          = MCI_ST_UX500_HWFCEN,
        .datalength_bits        = 24,
        .sdio                   = true,
        .st_clkdiv              = true,
        .blksz_datactrl16       = true,
};      

Cheers!

Pawe?

  reply	other threads:[~2011-10-05  9:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 17:32 [U-Boot] [PATCH] MMC: PL180: Fix infinite loop with VExpress extended fifo implementation Jon Medhurst
2011-10-05  9:30 ` Pawel Moll
2011-10-05  9:48   ` Jon Medhurst
2011-10-05  9:58     ` Pawel Moll [this message]
2011-10-05 10:14       ` Jon Medhurst
2011-10-06 16:43 ` Matt Waddel
2011-11-03  1:39 ` Andy Fleming
2011-11-04 13:06   ` [U-Boot] [PATCH v2] " Jon Medhurst
2011-11-08 20:46     ` Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317808738.3158.348.camel@hornet.cambridge.arm.com \
    --to=pawel.moll@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.