From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934447Ab1JELWP (ORCPT ); Wed, 5 Oct 2011 07:22:15 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:42353 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934411Ab1JELWL (ORCPT ); Wed, 5 Oct 2011 07:22:11 -0400 Subject: Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail From: Andreas Gruenbacher To: Greg KH Cc: quilt-dev@nongnu.org, Peter Zijlstra , LKML , "H. Peter Anvin" , John Kacur , Andrew Morton Date: Wed, 05 Oct 2011 13:21:07 +0200 References: <1317750395.18063.11.camel@gandalf.stny.rr.com> <20111004180237.GA15087@suse.de> <1317752148.18063.16.camel@gandalf.stny.rr.com> <20111004182615.GA16224@suse.de> <1317753468.18063.19.camel@gandalf.stny.rr.com> <1317779312.1662.37.camel@schurl.linbit> <20111005065309.GA6676@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3 (3.0.3-1.fc15) Content-Transfer-Encoding: 7bit Message-ID: <1317813674.1623.10.camel@schurl.linbit> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-10-05 at 10:23 +0200, Andreas Gruenbacher wrote: > On Tue, 2011-10-04 at 23:53 -0700, Greg KH wrote: > > Yes, quoting is the correct thing to do, but that does not usually > > happen in "Signed-off-by:" lines in kernel patches. > > > > Actually, I think this is even a problem when the name is quoted > > properly, I've had to fix that up in patches by hand. > > Yes, proper quoting currently isn't enough. > > > And yes, this is a problem, I run into at least 1-2 patches per stable > > kernel release with this issue. I looked into fixing it and somehow the > > email parsing logic was wierd and I couldn't figure out how to resolve > > it. > > Okay, I'll have another look ... I've tried to address this as follows now: commit f3e7822028616014f933b99d05f42fc028f8d12c Author: Andreas Gruenbacher Date: Wed Oct 5 12:57:48 2011 +0200 quilt mail: Allow commas in Signed-off-by and Acked-by lines The standard quilt_mail_patch_filter() in quilt mail tries to extract email addresses from Signed-off-by and Acked-by lines. It adds Cc headers with those addresses. Signed-off-by and Acked-by lines sometimes contain commas as part of the address. When put in recipient headers (To, Cc, Bcc), the commas are interpreted as separators, which breaks things. Try to recognize this case and add the appropriate quotes. For example, the email address in ``Signed-off-by: Gruenbacher, Andreas '' is now extracted as ``"Gruenbacher, Andreas" ''. Note that quilt_mail_patch_filter() can be overridden in .quiltrc; you may need to update your .quiltrc. commit c6750845136ff21eb13bc99ec7a6e1689100a13a Author: Andreas Gruenbacher Date: Wed Oct 5 12:08:05 2011 +0200 quilt mail: Support double quoted special characters in email adresses Addresses like "Gruenbacher, Andreas" will work now. Please give it a shot. Thanks, Andreas