All of lore.kernel.org
 help / color / mirror / Atom feed
* [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
@ 2021-01-20  5:03 Chen Qi
  2021-01-31 11:41 ` Richard Purdie
       [not found] ` <165F4E547FA339C3.13584@lists.openembedded.org>
  0 siblings, 2 replies; 8+ messages in thread
From: Chen Qi @ 2021-01-20  5:03 UTC (permalink / raw)
  To: openembedded-core

Build error occurs as below:

  ERROR: igt-gpu-tools-1.25+gitAUTOINC+d16ad07e7f-r0 do_package_qa:
         QA Issue: /usr/lib/libigt.so.0 contained in package igt-gpu-tools
	 requires libprocps.so.8(LIBPROCPS_0)(64bit), but no providers
	 found in RDEPENDS_igt-gpu-tools? [file-rdeps]

Add procps-lib to RDEPENDS to solve this issue.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
index 89480d79d2..b012dbf58e 100644
--- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
+++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
@@ -15,7 +15,7 @@ SRC_URI = "git://gitlab.freedesktop.org/drm/igt-gpu-tools.git;protocol=https"
 S = "${WORKDIR}/git"
 
 DEPENDS += "libdrm libpciaccess cairo udev glib-2.0 procps libunwind kmod openssl elfutils alsa-lib json-c bison-native"
-RDEPENDS_${PN} += "bash"
+RDEPENDS_${PN} += "bash procps-lib"
 RDEPENDS_${PN}-tests += "bash"
 
 PACKAGE_BEFORE_PN = "${PN}-benchmarks ${PN}-tests"
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
  2021-01-20  5:03 [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS Chen Qi
@ 2021-01-31 11:41 ` Richard Purdie
       [not found] ` <165F4E547FA339C3.13584@lists.openembedded.org>
  1 sibling, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2021-01-31 11:41 UTC (permalink / raw)
  To: Chen Qi, openembedded-core; +Cc: Mittal, Anuj

On Wed, 2021-01-20 at 13:03 +0800, Chen Qi wrote:
> Build error occurs as below:
> 
>   ERROR: igt-gpu-tools-1.25+gitAUTOINC+d16ad07e7f-r0 do_package_qa:
>          QA Issue: /usr/lib/libigt.so.0 contained in package igt-gpu-tools
> 	 requires libprocps.so.8(LIBPROCPS_0)(64bit), but no providers
> 	 found in RDEPENDS_igt-gpu-tools? [file-rdeps]
> 
> Add procps-lib to RDEPENDS to solve this issue.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> index 89480d79d2..b012dbf58e 100644
> --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> @@ -15,7 +15,7 @@ SRC_URI = "git://gitlab.freedesktop.org/drm/igt-gpu-tools.git;protocol=https"
>  S = "${WORKDIR}/git"
>  
> 
> 
> 
>  DEPENDS += "libdrm libpciaccess cairo udev glib-2.0 procps libunwind kmod openssl elfutils alsa-lib json-c bison-native"
> -RDEPENDS_${PN} += "bash"
> +RDEPENDS_${PN} += "bash procps-lib"
>  RDEPENDS_${PN}-tests += "bash"
> 


You are correct about this and I see the same issue if I build it
locally. What worries me is why we don't see this on the autobuilder in
world builds?

Cc'ing Anuj as the maintainer.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
       [not found] ` <165F4E547FA339C3.13584@lists.openembedded.org>
@ 2021-01-31 11:56   ` Richard Purdie
       [not found]   ` <165F4F23A9F2744A.13584@lists.openembedded.org>
  1 sibling, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2021-01-31 11:56 UTC (permalink / raw)
  To: Chen Qi, openembedded-core; +Cc: Mittal, Anuj, Joshua Watt

On Sun, 2021-01-31 at 11:41 +0000, Richard Purdie via
lists.openembedded.org wrote:
> On Wed, 2021-01-20 at 13:03 +0800, Chen Qi wrote:
> > Build error occurs as below:
> > 
> >   ERROR: igt-gpu-tools-1.25+gitAUTOINC+d16ad07e7f-r0 do_package_qa:
> >          QA Issue: /usr/lib/libigt.so.0 contained in package igt-gpu-tools
> > 	 requires libprocps.so.8(LIBPROCPS_0)(64bit), but no providers
> > 	 found in RDEPENDS_igt-gpu-tools? [file-rdeps]
> > 
> > Add procps-lib to RDEPENDS to solve this issue.
> > 
> > Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> > ---
> >  meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > index 89480d79d2..b012dbf58e 100644
> > --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > @@ -15,7 +15,7 @@ SRC_URI = "git://gitlab.freedesktop.org/drm/igt-gpu-tools.git;protocol=https"
> >  S = "${WORKDIR}/git"
> >  
> > 
> > 
> > 
> >  DEPENDS += "libdrm libpciaccess cairo udev glib-2.0 procps libunwind kmod openssl elfutils alsa-lib json-c bison-native"
> > -RDEPENDS_${PN} += "bash"
> > +RDEPENDS_${PN} += "bash procps-lib"
> >  RDEPENDS_${PN}-tests += "bash"
> > 
> 
> 
> You are correct about this and I see the same issue if I build it
> locally. What worries me is why we don't see this on the autobuilder in
> world builds?
> 
> Cc'ing Anuj as the maintainer.

Looking at the autobuilder logs, I think I can guess the problem, I
think its a hash equivalence issue.

Errors raised by do_package_qa aren't reflected in the output so it
would error once and then never again as the output wouldn't seen
changed next time :(

We'll have to fix this, its nasty.

Cc: Joshua

Cheers,

Richard





^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
       [not found]   ` <165F4F23A9F2744A.13584@lists.openembedded.org>
@ 2021-02-01 11:34     ` Richard Purdie
  2021-02-02  2:57       ` Anuj Mittal
       [not found]       ` <165FCEE5FAACF69D.16314@lists.openembedded.org>
  0 siblings, 2 replies; 8+ messages in thread
From: Richard Purdie @ 2021-02-01 11:34 UTC (permalink / raw)
  To: Chen Qi, openembedded-core; +Cc: Mittal, Anuj, Joshua Watt

On Sun, 2021-01-31 at 11:56 +0000, Richard Purdie via
lists.openembedded.org wrote:
> On Sun, 2021-01-31 at 11:41 +0000, Richard Purdie via
> lists.openembedded.org wrote:
> > On Wed, 2021-01-20 at 13:03 +0800, Chen Qi wrote:
> > > Build error occurs as below:
> > > 
> > >   ERROR: igt-gpu-tools-1.25+gitAUTOINC+d16ad07e7f-r0 do_package_qa:
> > >          QA Issue: /usr/lib/libigt.so.0 contained in package igt-gpu-tools
> > > 	 requires libprocps.so.8(LIBPROCPS_0)(64bit), but no providers
> > > 	 found in RDEPENDS_igt-gpu-tools? [file-rdeps]
> > > 
> > > Add procps-lib to RDEPENDS to solve this issue.
> > > 
> > > Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> > > ---
> > >  meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > index 89480d79d2..b012dbf58e 100644
> > > --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > @@ -15,7 +15,7 @@ SRC_URI = "git://gitlab.freedesktop.org/drm/igt-gpu-tools.git;protocol=https"
> > >  S = "${WORKDIR}/git"
> > >  
> > >  DEPENDS += "libdrm libpciaccess cairo udev glib-2.0 procps libunwind kmod openssl elfutils alsa-lib json-c bison-native"
> > > -RDEPENDS_${PN} += "bash"
> > > +RDEPENDS_${PN} += "bash procps-lib"
> > >  RDEPENDS_${PN}-tests += "bash"
> > > 
> > 
> > 
> > You are correct about this and I see the same issue if I build it
> > locally. What worries me is why we don't see this on the autobuilder in
> > world builds?
> > 
> > Cc'ing Anuj as the maintainer.
> 
> Looking at the autobuilder logs, I think I can guess the problem, I
> think its a hash equivalence issue.
> 
> Errors raised by do_package_qa aren't reflected in the output so it
> would error once and then never again as the output wouldn't seen
> changed next time :(
> 
> We'll have to fix this, its nasty.
> 
> Cc: Joshua

Its not a hashequiv issue directly although the QA warnings not being
cached is am unrelated problem.

It seems if you build igt-gpu-tools with /usr/lib64/ it works (as on
the autobuilder where multilib is enabled), if you build with /usr/lib/
it gives the QA warning despite actually having the right RDEPENDS
anyway.

We need to debug why its showing this error incorrectly as there is
something bad looking going on underneath here...

Cheers,

Richard


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
  2021-02-01 11:34     ` Richard Purdie
@ 2021-02-02  2:57       ` Anuj Mittal
  2021-02-03  0:18         ` Richard Purdie
       [not found]         ` <166014C846A3C62E.24362@lists.openembedded.org>
       [not found]       ` <165FCEE5FAACF69D.16314@lists.openembedded.org>
  1 sibling, 2 replies; 8+ messages in thread
From: Anuj Mittal @ 2021-02-02  2:57 UTC (permalink / raw)
  To: Qi.Chen, richard.purdie, openembedded-core; +Cc: JPEW.hacker

On Mon, 2021-02-01 at 11:34 +0000, Richard Purdie wrote:
> On Sun, 2021-01-31 at 11:56 +0000, Richard Purdie via
> lists.openembedded.org wrote:
> > On Sun, 2021-01-31 at 11:41 +0000, Richard Purdie via
> > lists.openembedded.org wrote:
> > > On Wed, 2021-01-20 at 13:03 +0800, Chen Qi wrote:
> > > > Build error occurs as below:
> > > > 
> > > >   ERROR: igt-gpu-tools-1.25+gitAUTOINC+d16ad07e7f-r0
> > > > do_package_qa:
> > > >          QA Issue: /usr/lib/libigt.so.0 contained in package
> > > > igt-gpu-tools
> > > >          requires libprocps.so.8(LIBPROCPS_0)(64bit), but no
> > > > providers
> > > >          found in RDEPENDS_igt-gpu-tools? [file-rdeps]
> > > > 
> > > > Add procps-lib to RDEPENDS to solve this issue.
> > > > 
> > > > Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> > > > ---
> > > >  meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 2
> > > > +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-
> > > > tools_git.bb b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-
> > > > tools_git.bb
> > > > index 89480d79d2..b012dbf58e 100644
> > > > --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > > +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > > @@ -15,7 +15,7 @@ SRC_URI =
> > > > "git://gitlab.freedesktop.org/drm/igt-gpu-
> > > > tools.git;protocol=https"
> > > >  S = "${WORKDIR}/git"
> > > >  
> > > >  DEPENDS += "libdrm libpciaccess cairo udev glib-2.0 procps
> > > > libunwind kmod openssl elfutils alsa-lib json-c bison-native"
> > > > -RDEPENDS_${PN} += "bash"
> > > > +RDEPENDS_${PN} += "bash procps-lib"
> > > >  RDEPENDS_${PN}-tests += "bash"
> > > > 
> > > 
> > > 
> > > You are correct about this and I see the same issue if I build it
> > > locally. What worries me is why we don't see this on the
> > > autobuilder in
> > > world builds?
> > > 
> > > Cc'ing Anuj as the maintainer.
> > 
> > Looking at the autobuilder logs, I think I can guess the problem, I
> > think its a hash equivalence issue.
> > 
> > Errors raised by do_package_qa aren't reflected in the output so it
> > would error once and then never again as the output wouldn't seen
> > changed next time :(
> > 
> > We'll have to fix this, its nasty.
> > 
> > Cc: Joshua
> 
> Its not a hashequiv issue directly although the QA warnings not being
> cached is am unrelated problem.
> 
> It seems if you build igt-gpu-tools with /usr/lib64/ it works (as on
> the autobuilder where multilib is enabled), if you build with
> /usr/lib/
> it gives the QA warning despite actually having the right RDEPENDS
> anyway.

I see the same failure locally even when using the autobuilder
configuration so it's probably not related to multilib.

I guess it's happening because procps was split up recently to have the
lib installed in a separate package and that didn't result in a rebuild
of igt-gpu-tools?

Thanks,

Anuj

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
       [not found]       ` <165FCEE5FAACF69D.16314@lists.openembedded.org>
@ 2021-02-02  3:03         ` Anuj Mittal
  0 siblings, 0 replies; 8+ messages in thread
From: Anuj Mittal @ 2021-02-02  3:03 UTC (permalink / raw)
  To: Qi.Chen, richard.purdie, openembedded-core

On Tue, 2021-02-02 at 02:57 +0000, Anuj Mittal wrote:
> I guess it's happening because procps was split up recently to have
> the

I meant "it's not happening on autobuilder because" ...

> lib installed in a separate package and that didn't result in a
> rebuild
> of igt-gpu-tools?


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
  2021-02-02  2:57       ` Anuj Mittal
@ 2021-02-03  0:18         ` Richard Purdie
       [not found]         ` <166014C846A3C62E.24362@lists.openembedded.org>
  1 sibling, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2021-02-03  0:18 UTC (permalink / raw)
  To: Mittal, Anuj, Qi.Chen, openembedded-core; +Cc: JPEW.hacker

On Tue, 2021-02-02 at 02:57 +0000, Mittal, Anuj wrote:
> I see the same failure locally even when using the autobuilder
> configuration so it's probably not related to multilib.
> 
> I guess it's happening because procps was split up recently to have the
> lib installed in a separate package and that didn't result in a rebuild
> of igt-gpu-tools?

It seems related to this. It doesn't seem to happen on a clean build
but in my older TMPDIRs, shlibs2/procps.list seems to be persisting for
some reason and is making the package RDEPEND on procps instead of
procps-libs. I've run out of time today to dig further though...

Cheers,

Richard


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS
       [not found]         ` <166014C846A3C62E.24362@lists.openembedded.org>
@ 2021-02-03 14:41           ` Richard Purdie
  0 siblings, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2021-02-03 14:41 UTC (permalink / raw)
  To: Mittal, Anuj, Qi.Chen, openembedded-core; +Cc: JPEW.hacker

On Wed, 2021-02-03 at 00:18 +0000, Richard Purdie via
lists.openembedded.org wrote:
> On Tue, 2021-02-02 at 02:57 +0000, Mittal, Anuj wrote:
> > I see the same failure locally even when using the autobuilder
> > configuration so it's probably not related to multilib.
> > 
> > I guess it's happening because procps was split up recently to have the
> > lib installed in a separate package and that didn't result in a rebuild
> > of igt-gpu-tools?
> 
> It seems related to this. It doesn't seem to happen on a clean build
> but in my older TMPDIRs, shlibs2/procps.list seems to be persisting for
> some reason and is making the package RDEPEND on procps instead of
> procps-libs. I've run out of time today to dig further though...

I found the problem, its an issue in do_packagedata when TMPDIR isn't
clean. I've sent a patch. I'm going to drop this RDEPENDS patch in
favour of that.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-02-03 14:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20  5:03 [OE-core][PATCH] igt-gpu-tools: add procps-lib to RDEPENDS Chen Qi
2021-01-31 11:41 ` Richard Purdie
     [not found] ` <165F4E547FA339C3.13584@lists.openembedded.org>
2021-01-31 11:56   ` Richard Purdie
     [not found]   ` <165F4F23A9F2744A.13584@lists.openembedded.org>
2021-02-01 11:34     ` Richard Purdie
2021-02-02  2:57       ` Anuj Mittal
2021-02-03  0:18         ` Richard Purdie
     [not found]         ` <166014C846A3C62E.24362@lists.openembedded.org>
2021-02-03 14:41           ` Richard Purdie
     [not found]       ` <165FCEE5FAACF69D.16314@lists.openembedded.org>
2021-02-02  3:03         ` Anuj Mittal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.