All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] genirq: spurious.c: fix regression that broke irqfixup,irqpoll
@ 2011-11-01 19:29 edward.donovan
  2011-11-02 18:02 ` Thomas Gleixner
  0 siblings, 1 reply; 3+ messages in thread
From: edward.donovan @ 2011-11-01 19:29 UTC (permalink / raw)
  To: tglx; +Cc: linux-kernel, maciej.rutecki

From: Edward Donovan <edward.donovan@numble.net>

commit  d05c65fff0 ("genirq: spurious: Run only one poller at a time")
introduced a regression, leaving the boot options 'irqfixup' and
'irqpoll' non-functional.  The patch placed tests in each function, to
exit if the function is already running.  The test in 'misrouted_irq'
exited when it should have proceeded, effectively disabling
'misrouted_irq' and 'poll_spurious_irqs'.  Reversing the "==" operator
to "!=" fixes the regression.

Signed-off-by: Edward Donovan <edward.donovan@numble.net>
---
 kernel/irq/spurious.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index aa57d5d..b5f4742 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -115,7 +115,7 @@ static int misrouted_irq(int irq)
 	struct irq_desc *desc;
 	int i, ok = 0;
 
-	if (atomic_inc_return(&irq_poll_active) == 1)
+	if (atomic_inc_return(&irq_poll_active) != 1)
 		goto out;
 
 	irq_poll_cpu = smp_processor_id();
-- 
1.7.5.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] genirq: spurious.c: fix regression that broke irqfixup,irqpoll
  2011-11-01 19:29 [PATCH] genirq: spurious.c: fix regression that broke irqfixup,irqpoll edward.donovan
@ 2011-11-02 18:02 ` Thomas Gleixner
  2011-11-03 20:25   ` Edward Donovan
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2011-11-02 18:02 UTC (permalink / raw)
  To: edward.donovan; +Cc: linux-kernel, maciej.rutecki

On Tue, 1 Nov 2011, edward.donovan@numble.net wrote:

> From: Edward Donovan <edward.donovan@numble.net>
> 
> commit  d05c65fff0 ("genirq: spurious: Run only one poller at a time")
> introduced a regression, leaving the boot options 'irqfixup' and
> 'irqpoll' non-functional.  The patch placed tests in each function, to
> exit if the function is already running.  The test in 'misrouted_irq'
> exited when it should have proceeded, effectively disabling
> 'misrouted_irq' and 'poll_spurious_irqs'.  Reversing the "==" operator
> to "!=" fixes the regression.
> 
> Signed-off-by: Edward Donovan <edward.donovan@numble.net>

Good catch! I was staring at it with my conference and flu damaged
brain ....

Thanks,

	tglx

> ---
>  kernel/irq/spurious.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
> index aa57d5d..b5f4742 100644
> --- a/kernel/irq/spurious.c
> +++ b/kernel/irq/spurious.c
> @@ -115,7 +115,7 @@ static int misrouted_irq(int irq)
>  	struct irq_desc *desc;
>  	int i, ok = 0;
>  
> -	if (atomic_inc_return(&irq_poll_active) == 1)
> +	if (atomic_inc_return(&irq_poll_active) != 1)
>  		goto out;
>  
>  	irq_poll_cpu = smp_processor_id();
> -- 
> 1.7.5.4
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] genirq: spurious.c: fix regression that broke irqfixup,irqpoll
  2011-11-02 18:02 ` Thomas Gleixner
@ 2011-11-03 20:25   ` Edward Donovan
  0 siblings, 0 replies; 3+ messages in thread
From: Edward Donovan @ 2011-11-03 20:25 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: maciej.rutecki, linux-kernel

On Nov 2, 2011 2:02 PM, "Thomas Gleixner" <tglx@linutronix.de> wrote:
>
> Good catch! I was staring at it with my conference and flu damaged
> brain ....
>

Thanks, Thomas.  It had me running around for quite a while before I
caught it. :)

I hoped this had nailed the failure of irqfixup/poll, since the .39
merge window.  But I have one machine where this fix doesn't help.
(With this patch, 2.6.39+ went from never handling that bad irq, to
handling it in a fraction of bootups.  I have to dig into that
more.)

On my Ubuntu bug report I have asked the other reporters for
testing, but haven't heard yet.

It may be back to the bisecting board for me, and I'll post again
if I learn anything.

 Ed

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-11-03 20:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-01 19:29 [PATCH] genirq: spurious.c: fix regression that broke irqfixup,irqpoll edward.donovan
2011-11-02 18:02 ` Thomas Gleixner
2011-11-03 20:25   ` Edward Donovan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.